public inbox for gcc-bugs@sourceware.org
help / color / mirror / Atom feed
From: "rguenth at gcc dot gnu.org" <gcc-bugzilla@gcc.gnu.org>
To: gcc-bugs@gcc.gnu.org
Subject: [Bug middle-end/53676] [4.7 regression] empty loop is not always removed now
Date: Wed, 22 Aug 2012 09:18:00 -0000	[thread overview]
Message-ID: <bug-53676-4-v8s0rUjfN4@http.gcc.gnu.org/bugzilla/> (raw)
In-Reply-To: <bug-53676-4@http.gcc.gnu.org/bugzilla/>

http://gcc.gnu.org/bugzilla/show_bug.cgi?id=53676

--- Comment #15 from Richard Guenther <rguenth at gcc dot gnu.org> 2012-08-22 09:17:10 UTC ---
(In reply to comment #14)
> (In reply to comment #13)
> > No, it's only the commit referenced in this PR.  No optimization regressions
> > warrant a backport as they always come with the risk of regressing something
> > worse than performance.  Trivial restoring of old behavior might be worth
> > backporting but the patch introduces a completely new non-trivial transform
> > into a core analysis engine that is shared among many passes.
> 
> FWIW, it seems to me that small patches, even non-trivial ones, should be
> candidates for back-porting after they've been on the trunk or on a later
> release branch for a reasonable period of time. E.g. after 3 months on the GCC
> 4.8 trunk and with no resulting bugs reported, this patch should be considered
> for back-porting IMHO.

Testing coverage during stage1 isn't very good IMHO, so we should wait at
least until we enter stage3.  But again, patch size isn't a good metric, it is
the coverage that counts - for this patch, changing SCEV analysis in a
non-trivial way is very intrusive.


  parent reply	other threads:[~2012-08-22  9:18 UTC|newest]

Thread overview: 23+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-06-14 22:47 [Bug middle-end/53676] New: [4.7/4.8 regression] constant folding regression, shown as slowdown as measured by Adobe's C++Benchmark matt at use dot net
2012-06-14 22:49 ` [Bug middle-end/53676] " matt at use dot net
2012-06-14 23:00 ` matt at use dot net
2012-06-14 23:13 ` [Bug middle-end/53676] [4.7/4.8 regression] empty loop is not always removed now pinskia at gcc dot gnu.org
2012-06-15  0:02 ` hjl.tools at gmail dot com
2012-06-19 13:18 ` rguenth at gcc dot gnu.org
2012-06-25  8:19 ` rguenth at gcc dot gnu.org
2012-06-25 13:41 ` rguenth at gcc dot gnu.org
2012-06-27 11:33 ` [Bug middle-end/53676] [4.7 " rguenth at gcc dot gnu.org
2012-06-27 11:33 ` [Bug middle-end/53676] [4.7/4.8 " rguenth at gcc dot gnu.org
2012-06-27 11:33 ` [Bug middle-end/53676] [4.7 " rguenth at gcc dot gnu.org
2012-06-27 18:27 ` matt at use dot net
2012-06-28  8:26 ` rguenther at suse dot de
2012-08-21 21:40 ` matt at use dot net
2012-08-22  8:48 ` rguenth at gcc dot gnu.org
2012-08-22  8:56 ` steven at gcc dot gnu.org
2012-08-22  9:18 ` rguenth at gcc dot gnu.org [this message]
2012-08-23 18:01 ` matt at use dot net
2012-09-06 15:21 ` rguenth at gcc dot gnu.org
2012-09-20 10:16 ` jakub at gcc dot gnu.org
2013-04-10  8:11 ` rguenth at gcc dot gnu.org
2013-04-11  7:59 ` rguenth at gcc dot gnu.org
2014-05-06 11:58 ` rguenth at gcc dot gnu.org

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=bug-53676-4-v8s0rUjfN4@http.gcc.gnu.org/bugzilla/ \
    --to=gcc-bugzilla@gcc.gnu.org \
    --cc=gcc-bugs@gcc.gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).