[Bug go/53679] New: Build failure in libgo

[Bug go/53679] New: Build failure in libgo

[allan at archlinux dot org]

http://gcc.gnu.org/bugzilla/show_bug.cgi?id=53679

             Bug #: 53679
           Summary: Build failure in libgo
    Classification: Unclassified
           Product: gcc
           Version: 4.7.1
            Status: UNCONFIRMED
          Severity: normal
          Priority: P3
         Component: go
        AssignedTo: ian@airs.com
        ReportedBy: allan@archlinux.org


Since revision 187850, I get build failures for libgo due to the use of -Werror
and not checking the return value of write:

/build/src/gcc-4.7.1/libgo/runtime/print.c: In function 'gwrite':
/build/src/gcc-4.7.1/libgo/runtime/print.c:20:3: error: ignoring return value
of 'write', declared with attribute warn_unused_result [-Werror=unused-result]
cc1: all warnings being treated as errors

[Bug go/53679] Build failure in libgo

[safety0ff.bugz at gmail dot com]

http://gcc.gnu.org/bugzilla/show_bug.cgi?id=53679

--- Comment #1 from safety0ff.bugz at gmail dot com 2012-06-15 15:52:18 UTC ---
Created attachment 27626
  --> http://gcc.gnu.org/bugzilla/attachment.cgi?id=27626
Allows me to compile it, I do know if there's any value if checking for errors
writing to stdout

[Bug go/53679] Build failure in libgo

[safety0ff.bugz at gmail dot com]

http://gcc.gnu.org/bugzilla/show_bug.cgi?id=53679

safety0ff.bugz at gmail dot com changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #27626|Allows me to compile it, I  |Allows me to compile it, I
        description|do know if there's any      |do know if there's any
                   |value if checking for       |value if checking for
                   |errors writing to stdout    |errors writing to stderr

--- Comment #1 from safety0ff.bugz at gmail dot com 2012-06-15 15:52:18 UTC ---
Created attachment 27626
  --> http://gcc.gnu.org/bugzilla/attachment.cgi?id=27626
Allows me to compile it, I do know if there's any value if checking for errors
writing to stderr

[Bug go/53679] Build failure in libgo

[pinskia at gcc dot gnu.org]

http://gcc.gnu.org/bugzilla/show_bug.cgi?id=53679

--- Comment #2 from Andrew Pinski <pinskia at gcc dot gnu.org> 2012-06-15 16:41:53 UTC ---
Actually this is due to your modifications to gcc to enable fority by default
and glibc's bad idea that write needs to be check for error after each write.

[Bug go/53679] Build failure in libgo

[allan at archlinux dot org]

http://gcc.gnu.org/bugzilla/show_bug.cgi?id=53679

--- Comment #3 from Allan McRae <allan at archlinux dot org> 2012-06-15 22:36:54 UTC ---
Just to be clear, I have not modified the compiler to enable fortify by
default, but it is in my CFLAGS...

As this is the only place that glibc's decision to enforce a check on the
return value of write causes the build to fail with these CFLAGS, it would be
nice to include the posted work-around, or equivalently: 

- runtime_write(2, v, n)
+ if(runtime_write(2, v, n)) {}

[Bug go/53679] Build failure in libgo

[vapier at gentoo dot org]

http://gcc.gnu.org/bugzilla/show_bug.cgi?id=53679

Mike Frysinger <vapier at gentoo dot org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |toolchain at gentoo dot org

--- Comment #4 from Mike Frysinger <vapier at gentoo dot org> 2012-06-27 23:09:10 UTC ---
another alternative woul dbe to fix the libgo/ subdir to respect
--disable-werror like all the other places in the gcc tree

[Bug go/53679] Build failure in libgo

[vapier at gentoo dot org]

http://gcc.gnu.org/bugzilla/show_bug.cgi?id=53679

--- Comment #5 from Mike Frysinger <vapier at gentoo dot org> 2012-12-23 23:32:35 UTC ---
posted a patch here to add --disable-werror:
http://gcc.gnu.org/ml/gcc-patches/2012-12/msg01379.html

we need this for ChromiumOS ...

[Bug go/53679] Build failure in libgo

[vapier at gentoo dot org]

http://gcc.gnu.org/bugzilla/show_bug.cgi?id=53679

--- Comment #6 from Mike Frysinger <vapier at gentoo dot org> 2013-01-26 03:20:51 UTC ---
Ian has pushed the patch to trunk:
http://gcc.gnu.org/viewcvs?view=revision&revision=195482