public inbox for gcc-bugs@sourceware.org
help / color / mirror / Atom feed
From: "krebbel at gcc dot gnu.org" <gcc-bugzilla@gcc.gnu.org>
To: gcc-bugs@gcc.gnu.org
Subject: [Bug bootstrap/53681] s390 bootstrap failure since 187965
Date: Mon, 18 Jun 2012 07:09:00 -0000 [thread overview]
Message-ID: <bug-53681-4-hNCBeXXHbB@http.gcc.gnu.org/bugzilla/> (raw)
In-Reply-To: <bug-53681-4@http.gcc.gnu.org/bugzilla/>
http://gcc.gnu.org/bugzilla/show_bug.cgi?id=53681
--- Comment #5 from Andreas Krebbel <krebbel at gcc dot gnu.org> 2012-06-18 07:09:04 UTC ---
(In reply to comment #4)
> I don't see how r187965 could cause this, but I do see the problem.
> mark_sym_for_renaming (called via the s390 va_arg_expr expander) is called
> during, well, gimplification from GENERIC. At that point SSA isn't
> initialized yet, so cfun->gimple_df is still NULL, and so SYMS_TO_RENAME
> gives a segfault.
>
> You either have to guard the call to mark_sym_for_renaming with
> gimple_in_ssa_p(), or get rid of the call alltogether. I don't see how
> new va_arg expressions would be generated during SSA optimizers, so the latter
> solution would be safe. No other backend calls mark_sym_for_renaming either,
> so just remove it.
?! You appear to have added the call to mark_sym_for_renaming with your patch.
Since it isn't mentioned in the changelog perhaps it is a leftover from
something else in your tree? So the solution is to revert that change?
svn diff -r 187964:187965 gcc/config/s390/s390.c
Index: gcc/config/s390/s390.c
===================================================================
--- gcc/config/s390/s390.c (revision 187964)
+++ gcc/config/s390/s390.c (revision 187965)
@@ -9044,6 +9044,7 @@
lab_false = create_artificial_label (UNKNOWN_LOCATION);
lab_over = create_artificial_label (UNKNOWN_LOCATION);
addr = create_tmp_var (ptr_type_node, "addr");
+ mark_sym_for_renaming (addr);
t = fold_convert (TREE_TYPE (reg), size_int (max_reg));
t = build2 (GT_EXPR, boolean_type_node, reg, t);
next prev parent reply other threads:[~2012-06-18 7:09 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-06-15 8:21 [Bug bootstrap/53681] New: " krebbel at gcc dot gnu.org
2012-06-15 8:23 ` [Bug bootstrap/53681] " krebbel at gcc dot gnu.org
2012-06-15 8:26 ` rguenth at gcc dot gnu.org
2012-06-15 8:30 ` krebbel at gcc dot gnu.org
2012-06-15 8:42 ` jakub at gcc dot gnu.org
2012-06-15 14:21 ` matz at gcc dot gnu.org
2012-06-18 7:09 ` krebbel at gcc dot gnu.org [this message]
2012-06-18 8:25 ` rguenther at suse dot de
2012-06-18 11:06 ` krebbel at gcc dot gnu.org
2012-06-18 11:09 ` matz at gcc dot gnu.org
2012-06-18 11:09 ` matz at gcc dot gnu.org
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=bug-53681-4-hNCBeXXHbB@http.gcc.gnu.org/bugzilla/ \
--to=gcc-bugzilla@gcc.gnu.org \
--cc=gcc-bugs@gcc.gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).