[Bug rtl-optimization/53706] New: [4.8 Regression] [ia64]: Bootstrap failure due to "Invalid write of size 8 at 0xBDC35E: variable_htab_free (var-tracking.c:1418)

[Bug rtl-optimization/53706] New: [4.8 Regression] [ia64]: Bootstrap failure due to "Invalid write of size 8 at 0xBDC35E: variable_htab_free (var-tracking.c:1418)

[ubizjak at gmail dot com]

http://gcc.gnu.org/bugzilla/show_bug.cgi?id=53706

             Bug #: 53706
           Summary: [4.8 Regression] [ia64]: Bootstrap failure due to
                    "Invalid write of size 8 at 0xBDC35E:
                    variable_htab_free (var-tracking.c:1418)
    Classification: Unclassified
           Product: gcc
           Version: 4.8.0
            Status: UNCONFIRMED
          Severity: normal
          Priority: P3
         Component: rtl-optimization
        AssignedTo: unassigned@gcc.gnu.org
        ReportedBy: ubizjak@gmail.com


Recent 4.8 regression on ia64. The bootstrap fail with:

*** glibc detected *** /home/uros/gcc-build/prev-gcc/cc1plus: corrupted
double-linked list: 0x60000000027ec0d0 ***
======= Backtrace: =========
/lib/libc.so.6.1(+0xd7800)[0x200000000021f800]
/lib/libc.so.6.1(+0xd81f0)[0x20000000002201f0]
/lib/libc.so.6.1(+0xdb5e0)[0x20000000002235e0]
/lib/libc.so.6.1(cfree-0x1cfed0)[0x200000000022be10]
/home/uros/gcc-build/prev-gcc/cc1plus(htab_delete+0x20000000014501a0)[0x400000000184be90]
/home/uros/gcc-build/prev-gcc/cc1plus[0x40000000014063a0]
/home/uros/gcc-build/prev-gcc/cc1plus(_Z22variable_tracking_mainv+0x2000000001012b50)[0x400000000140c530]
/home/uros/gcc-build/prev-gcc/cc1plus[0x400000000145f840]
/home/uros/gcc-build/prev-gcc/cc1plus[0x4000000000d72d10]
/home/uros/gcc-build/prev-gcc/cc1plus(_Z16execute_one_passP8opt_pass+0x20000000008a3860)[0x4000000000c9f560]
/home/uros/gcc-build/prev-gcc/cc1plus(_Z17execute_pass_listP8opt_pass+0x20000000008a4c90)[0x4000000000ca0310]
/home/uros/gcc-build/prev-gcc/cc1plus(_Z17execute_pass_listP8opt_pass+0x20000000008a4ce0)[0x4000000000ca0360]

This corrupted double linked list problem can be exposed with a cross to
ia64-unknown-linux-gnu under valgrind, with attached gimplify.ii:

$ valgrind ~/gcc-build-ia64/gcc/cc1plus -O2 -g -fno-common -fno-exceptions
-fno-rtti gimplify.ii

...
==2911== Invalid write of size 8
==2911==    at 0xBDC35E: variable_htab_free (var-tracking.c:1418)
==2911==    by 0xDA819A: htab_delete (hashtab.c:430)
==2911==    by 0xBE93EA: vt_emit_notes (var-tracking.c:9132)
==2911==    by 0xBE9631: variable_tracking_main (var-tracking.c:9875)
==2911==    by 0xC06995: ia64_reorg (ia64.c:9834)
==2911==    by 0x9923F9: rest_of_handle_machine_reorg (reorg.c:4151)
==2911==    by 0x945C26: execute_one_pass (passes.c:2164)
==2911==    by 0x945FD4: execute_pass_list (passes.c:2219)
==2911==    by 0x945FE6: execute_pass_list (passes.c:2220)
==2911==    by 0x945FE6: execute_pass_list (passes.c:2220)
==2911==    by 0x745047: expand_function (cgraphunit.c:1615)
==2911==    by 0x746936: compile (cgraphunit.c:1720)
==2911==  Address 0xf16ea18 is 40 bytes inside a block of size 2,568 free'd
==2911==    at 0x4A079AE: free (vg_replace_malloc.c:427)
==2911==    by 0x6DA9F7: empty_alloc_pool (alloc-pool.c:210)
==2911==    by 0x6DAA68: free_alloc_pool (alloc-pool.c:230)
==2911==    by 0xBE93D3: vt_emit_notes (var-tracking.c:9130)
==2911==    by 0xBE9631: variable_tracking_main (var-tracking.c:9875)
==2911==    by 0xC06995: ia64_reorg (ia64.c:9834)
==2911==    by 0x9923F9: rest_of_handle_machine_reorg (reorg.c:4151)
==2911==    by 0x945C26: execute_one_pass (passes.c:2164)
==2911==    by 0x945FD4: execute_pass_list (passes.c:2219)
==2911==    by 0x945FE6: execute_pass_list (passes.c:2220)
==2911==    by 0x945FE6: execute_pass_list (passes.c:2220)
==2911==    by 0x745047: expand_function (cgraphunit.c:1615)

[Bug rtl-optimization/53706] [4.8 Regression] [ia64]: Bootstrap failure due to "Invalid write of size 8 at 0xBDC35E: variable_htab_free (var-tracking.c:1418)

[ubizjak at gmail dot com]

http://gcc.gnu.org/bugzilla/show_bug.cgi?id=53706

--- Comment #1 from Uros Bizjak <ubizjak at gmail dot com> 2012-06-17 12:42:32 UTC ---
Created attachment 27641
  --> http://gcc.gnu.org/bugzilla/attachment.cgi?id=27641
Preprocessed source

[Bug rtl-optimization/53706] [4.8 Regression] [ia64]: Bootstrap failure due to "Invalid write of size 8 at 0xBDC35E: variable_htab_free (var-tracking.c:1418)

[ubizjak at gmail dot com]

http://gcc.gnu.org/bugzilla/show_bug.cgi?id=53706

Uros Bizjak <ubizjak at gmail dot com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
   Target Milestone|---                         |4.8.0

--- Comment #2 from Uros Bizjak <ubizjak at gmail dot com> 2012-06-17 16:49:19 UTC ---
r188529 works OK.

[Bug rtl-optimization/53706] [4.8 Regression] [ia64]: Bootstrap failure due to "Invalid write of size 8 at 0xBDC35E: variable_htab_free (var-tracking.c:1418)

[ubizjak at gmail dot com]

http://gcc.gnu.org/bugzilla/show_bug.cgi?id=53706

Uros Bizjak <ubizjak at gmail dot com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|UNCONFIRMED                 |NEW
   Last reconfirmed|                            |2012-06-17
                 CC|                            |aoliva at gcc dot gnu.org
     Ever Confirmed|0                           |1

--- Comment #3 from Uros Bizjak <ubizjak at gmail dot com> 2012-06-17 17:00:44 UTC ---
r188530 fails.

2012-06-13  Alexandre Oliva  <aoliva@redhat.com>

        PR debug/47624
        * var-tracking.c (loc_exp_dep_pool): New.
        (vt_emit_notes): Create and release the pool.
        (compute_bb_dataflow): Use value-based locations in MO_VAL_SET.
        (emit_notes_in_bb): Likewise.
        (loc_exp_dep_insert): Deal with NOT_ONEPART vars.
        (notify_dependents_of_changed_value): Likewise.
        (notify_dependents_of_resolved_value): Check that NOT_ONEPART
        variables don't have a VAR_LOC_DEP_LST.
        (emit_note_insn_var_location): Expand NOT_ONEPART locs that are
        VALUEs or MEMs of VALUEs.

[Bug rtl-optimization/53706] [4.8 Regression] [ia64]: Bootstrap failure due to "Invalid write of size 8 at 0xBDC35E: variable_htab_free (var-tracking.c:1418)

[hjl.tools at gmail dot com]

http://gcc.gnu.org/bugzilla/show_bug.cgi?id=53706

H.J. Lu <hjl.tools at gmail dot com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |hjl.tools at gmail dot com

--- Comment #4 from H.J. Lu <hjl.tools at gmail dot com> 2012-06-17 21:58:44 UTC ---
*** Bug 53710 has been marked as a duplicate of this bug. ***

[Bug rtl-optimization/53706] [4.8 Regression] [ia64]: Bootstrap failure due to "Invalid write of size 8 at 0xBDC35E: variable_htab_free (var-tracking.c:1418)

[hjl.tools at gmail dot com]

http://gcc.gnu.org/bugzilla/show_bug.cgi?id=53706

--- Comment #5 from H.J. Lu <hjl.tools at gmail dot com> 2012-06-17 22:00:43 UTC ---
Created attachment 27646
  --> http://gcc.gnu.org/bugzilla/attachment.cgi?id=27646
A testcase for x86-64

valgrind ./cc1plus -fpreprocessed x.ii -quiet -dumpbase x.ii -march=corei7-avx
-mcx16 -msahf -mmovbe -maes -mpclmul -mpopcnt -mabm -mno-lwp -mfma -mno-fma4
-mno-xop -mbmi -mbmi2 -mno-tbm -mavx -mavx2 -msse4.2 -msse4.1 -mlzcnt -auxbase
x -g -O2 -Wextra -Wall -Wno-narrowing -Wwrite-strings -Wcast-qual
-Wsuggest-attribute=format -Wpedantic -Wno-long-long -Wno-variadic-macros
-Wno-overlength-strings -Werror -version -fno-exceptions -fno-rtti -fno-common
-o x.s
==15175== Memcheck, a memory error detector
==15175== Copyright (C) 2002-2011, and GNU GPL'd, by Julian Seward et al.
==15175== Using Valgrind-3.7.0 and LibVEX; rerun with -h for copyright info
==15175== Command: ./cc1plus -fpreprocessed x.ii -quiet -dumpbase x.ii
-march=corei7-avx -mcx16 -msahf -mmovbe -maes -mpclmul -mpopcnt -mabm -mno-lwp
-mfma -mno-fma4 -mno-xop -mbmi -mbmi2 -mno-tbm -mavx -mavx2 -msse4.2 -msse4.1
-mlzcnt -auxbase x -g -O2 -Wextra -Wall -Wno-narrowing -Wwrite-strings
-Wcast-qual -Wsuggest-attribute=format -Wpedantic -Wno-long-long
-Wno-variadic-macros -Wno-overlength-strings -Werror -version -fno-exceptions
-fno-rtti -fno-common -o x.s
==15175== 
GNU C++ (GCC) version 4.8.0 20120616 (experimental) (x86_64-unknown-linux-gnu)
    compiled by GNU C version 4.7.0 20120604 (Red Hat 4.7.0-7), GMP version
5.0.2, MPFR version 3.1.0, MPC version 0.9
GGC heuristics: --param ggc-min-expand=30 --param ggc-min-heapsize=4096
GNU C++ (GCC) version 4.8.0 20120616 (experimental) (x86_64-unknown-linux-gnu)
    compiled by GNU C version 4.7.0 20120604 (Red Hat 4.7.0-7), GMP version
5.0.2, MPFR version 3.1.0, MPC version 0.9
GGC heuristics: --param ggc-min-expand=30 --param ggc-min-heapsize=4096
Compiler executable checksum: 79196506890681890a6020f62ba12f85
==15175== Invalid write of size 8
==15175==    at 0x1176677: variable_htab_free (var-tracking.c:1418)
==15175==    by 0x15F75FC: htab_delete (hashtab.c:430)
==15175==    by 0x118F11D: vt_emit_notes (var-tracking.c:9132)
==15175==    by 0x119161D: variable_tracking_main_1 (var-tracking.c:9875)
==15175==    by 0x1191653: variable_tracking_main (var-tracking.c:9889)
==15175==    by 0xD51511: execute_one_pass (passes.c:2164)
==15175==    by 0xD516F7: execute_pass_list (passes.c:2219)
==15175==    by 0xD51718: execute_pass_list (passes.c:2220)
==15175==    by 0xD51718: execute_pass_list (passes.c:2220)
==15175==    by 0x9C0F9F: expand_function (cgraphunit.c:1615)
==15175==    by 0x9C1686: expand_all_functions (cgraphunit.c:1720)
==15175==    by 0x9C2205: compile (cgraphunit.c:2018)
==15175==  Address 0xfcb2bf8 is 40 bytes inside a block of size 2,568 free'd
==15175==    at 0x4C289AE: free (vg_replace_malloc.c:427)
==15175==    by 0x9007EA: empty_alloc_pool (alloc-pool.c:210)
==15175==    by 0x900867: free_alloc_pool (alloc-pool.c:230)
==15175==    by 0x118F103: vt_emit_notes (var-tracking.c:9130)
==15175==    by 0x119161D: variable_tracking_main_1 (var-tracking.c:9875)
==15175==    by 0x1191653: variable_tracking_main (var-tracking.c:9889)
==15175==    by 0xD51511: execute_one_pass (passes.c:2164)
==15175==    by 0xD516F7: execute_pass_list (passes.c:2219)
==15175==    by 0xD51718: execute_pass_list (passes.c:2220)
==15175==    by 0xD51718: execute_pass_list (passes.c:2220)
==15175==    by 0x9C0F9F: expand_function (cgraphunit.c:1615)
==15175==    by 0x9C1686: expand_all_functions (cgraphunit.c:1720)
==15175==

[Bug rtl-optimization/53706] [4.8 Regression] Bootstrap failure due to "Invalid write of size 8 at 0xBDC35E: variable_htab_free (var-tracking.c:1418)

[jakub at gcc dot gnu.org]

http://gcc.gnu.org/bugzilla/show_bug.cgi?id=53706

--- Comment #6 from Jakub Jelinek <jakub at gcc dot gnu.org> 2012-06-18 07:50:33 UTC ---
Created attachment 27648
  --> http://gcc.gnu.org/bugzilla/attachment.cgi?id=27648
gcc48-pr53706.patch

The attached patch fixes the problem for me.  Alex, what do you think about it?

[Bug rtl-optimization/53706] [4.8 Regression] Bootstrap failure due to "Invalid write of size 8 at 0xBDC35E: variable_htab_free (var-tracking.c:1418)

[aoliva at gcc dot gnu.org]

http://gcc.gnu.org/bugzilla/show_bug.cgi?id=53706

--- Comment #7 from Alexandre Oliva <aoliva at gcc dot gnu.org> 2012-06-18 09:50:01 UTC ---
It's a bit surprising, but I guess it makes sense.  I'd reorder the
initializers too, so that we release stuff in the reverse order of allocation.

[Bug rtl-optimization/53706] [4.8 Regression] Bootstrap failure due to "Invalid write of size 8 at 0xBDC35E: variable_htab_free (var-tracking.c:1418)

[ubizjak at gmail dot com]

http://gcc.gnu.org/bugzilla/show_bug.cgi?id=53706

--- Comment #8 from Uros Bizjak <ubizjak at gmail dot com> 2012-06-21 06:55:50 UTC ---
(In reply to comment #6)
> Created attachment 27648 [details]
> gcc48-pr53706.patch
> 
> The attached patch fixes the problem for me.  Alex, what do you think about it?

With this patch, I still see invalid write, but the path is a bit different
(through vt_finalize instead of vt_emit_nodes):

tree_node* shortcut_cond_r(tree, tree_node**, tree_node**, location_t)
==27489== Invalid write of size 8
==27489==    at 0xBD719E: variable_htab_free (var-tracking.c:1418)
==27489==    by 0xD7361A: htab_delete (hashtab.c:430)
==27489==    by 0xBD17B3: vt_finalize (var-tracking.c:9792)
==27489==    by 0xBE447F: variable_tracking_main (var-tracking.c:9839)
==27489==    by 0xC018A5: ia64_reorg (ia64.c:9833)
==27489==    by 0x98BF09: rest_of_handle_machine_reorg (reorg.c:4151)
==27489==    by 0x93F736: execute_one_pass (passes.c:2164)
==27489==    by 0x93FAE4: execute_pass_list (passes.c:2219)
==27489==    by 0x93FAF6: execute_pass_list (passes.c:2220)
==27489==    by 0x93FAF6: execute_pass_list (passes.c:2220)
==27489==    by 0x73DE47: expand_function (cgraphunit.c:1615)
==27489==    by 0x73F736: compile (cgraphunit.c:1720)
==27489==  Address 0xb853708 is 120 bytes inside a block of size 2,568 free'd
==27489==    at 0x4A05D21: free (vg_replace_malloc.c:325)
==27489==    by 0x6D42E7: empty_alloc_pool (alloc-pool.c:210)
==27489==    by 0x6D4358: free_alloc_pool (alloc-pool.c:230)
==27489==    by 0xBE421F: vt_emit_notes (var-tracking.c:9131)
==27489==    by 0xBE4471: variable_tracking_main (var-tracking.c:9875)
==27489==    by 0xC018A5: ia64_reorg (ia64.c:9833)
==27489==    by 0x98BF09: rest_of_handle_machine_reorg (reorg.c:4151)
==27489==    by 0x93F736: execute_one_pass (passes.c:2164)
==27489==    by 0x93FAE4: execute_pass_list (passes.c:2219)
==27489==    by 0x93FAF6: execute_pass_list (passes.c:2220)
==27489==    by 0x93FAF6: execute_pass_list (passes.c:2220)
==27489==    by 0x73DE47: expand_function (cgraphunit.c:1615)
==27489==

[Bug rtl-optimization/53706] [4.8 Regression] Bootstrap failure due to "Invalid write of size 8 at 0xBDC35E: variable_htab_free (var-tracking.c:1418)

[ubizjak at gmail dot com]

http://gcc.gnu.org/bugzilla/show_bug.cgi?id=53706

Uros Bizjak <ubizjak at gmail dot com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |jakub at gcc dot gnu.org

--- Comment #9 from Uros Bizjak <ubizjak at gmail dot com> 2012-06-21 06:58:38 UTC ---
(In reply to comment #8)

> With this patch, I still see invalid write, but the path is a bit different
> (through vt_finalize instead of vt_emit_nodes):

(crosscompiler x86_64-pc-linux-gnu -> ia64-unknown-linux-gnu on the original
testcase):

$ valgrind ~/gcc-build-ia64/gcc/cc1plus -O2 -g -fno-common -fno-exceptions
-fno-rtti gimplify.ii

[Bug rtl-optimization/53706] [4.8 Regression] Bootstrap failure due to "Invalid write of size 8 at 0xBDC35E: variable_htab_free (var-tracking.c:1418)

[ubizjak at gmail dot com]

http://gcc.gnu.org/bugzilla/show_bug.cgi?id=53706

--- Comment #10 from Uros Bizjak <ubizjak at gmail dot com> 2012-06-21 07:33:34 UTC ---
Patch that fixes all valgrind issues, but I have no idea if it is OK or not:

--cut here--
Index: var-tracking.c
===================================================================
--- var-tracking.c      (revision 188848)
+++ var-tracking.c      (working copy)
@@ -9126,11 +9126,7 @@ vt_emit_notes (void)
   dataflow_set_destroy (&cur);

   if (MAY_HAVE_DEBUG_INSNS)
-    {
-      free_alloc_pool (loc_exp_dep_pool);
-      loc_exp_dep_pool = NULL;
-      htab_delete (dropped_values);
-    }
+    htab_delete (dropped_values);

   emit_notes = false;
 }
@@ -9797,6 +9793,8 @@ vt_finalize (void)

   if (MAY_HAVE_DEBUG_INSNS)
     {
+      free_alloc_pool (loc_exp_dep_pool);
+      loc_exp_dep_pool = NULL;
       free_alloc_pool (valvar_pool);
       VEC_free (rtx, heap, preserved_values);
       cselib_finish ();
--cut here--

[Bug rtl-optimization/53706] [4.8 Regression] Bootstrap failure due to "Invalid write of size 8 at 0xBDC35E: variable_htab_free (var-tracking.c:1418)

[uweigand at gcc dot gnu.org]

http://gcc.gnu.org/bugzilla/show_bug.cgi?id=53706

Ulrich Weigand <uweigand at gcc dot gnu.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |uweigand at gcc dot gnu.org

--- Comment #11 from Ulrich Weigand <uweigand at gcc dot gnu.org> 2012-06-21 13:18:53 UTC ---
I'm seeing what appears to be a similar issue bootstrapping powerpc64:

*** glibc detected ***
/home/uweigand/fsf/gcc-head-build-ppu/./prev-gcc/cc1plus: corrupted
double-linked list: 0x0000000011afd980 ***
======= Backtrace: =========
/lib64/power6x/libc.so.6[0x80f2ff9bd0]
/lib64/power6x/libc.so.6[0x80f2ffba4c]
/lib64/power6x/libc.so.6(cfree-0x117fc8)[0x80f2ffc050]
/home/uweigand/fsf/gcc-head-build-ppu/./prev-gcc/cc1plus(_Z16empty_alloc_poolP14alloc_pool_def-0xd186ac)[0x1035da6c]
/home/uweigand/fsf/gcc-head-build-ppu/./prev-gcc/cc1plus(_Z15free_alloc_poolP14alloc_pool_def-0xd18638)[0x1035daf8]
/home/uweigand/fsf/gcc-head-build-ppu/./prev-gcc/cc1plus[0x109b81dc]
/home/uweigand/fsf/gcc-head-build-ppu/./prev-gcc/cc1plus(_Z22variable_tracking_mainv-0x6e1734)[0x109cd57c]
/home/uweigand/fsf/gcc-head-build-ppu/./prev-gcc/cc1plus(_Z16execute_one_passP8opt_pass-0xa1248c)[0x1067f7cc]
/home/uweigand/fsf/gcc-head-build-ppu/./prev-gcc/cc1plus(_Z17execute_pass_listP8opt_pass-0xa1203c)[0x1067fc34]
/home/uweigand/fsf/gcc-head-build-ppu/./prev-gcc/cc1plus(_Z17execute_pass_listP8opt_pass-0xa12024)[0x1067fc4c]
/home/uweigand/fsf/gcc-head-build-ppu/./prev-gcc/cc1plus(_Z17execute_pass_listP8opt_pass-0xa12024)[0x1067fc4c]
/home/uweigand/fsf/gcc-head-build-ppu/./prev-gcc/cc1plus[0x103e4ea8]
/home/uweigand/fsf/gcc-head-build-ppu/./prev-gcc/cc1plus(_Z7compilev-0xc935c4)[0x103e7474]
/home/uweigand/fsf/gcc-head-build-ppu/./prev-gcc/cc1plus(_Z25finalize_compilation_unitv-0xc92e84)[0x103e7bcc]
/home/uweigand/fsf/gcc-head-build-ppu/./prev-gcc/cc1plus(_Z28cp_write_global_declarationsv-0xeb57fc)[0x101b5414]
/home/uweigand/fsf/gcc-head-build-ppu/./prev-gcc/cc1plus[0x1074b894]
/home/uweigand/fsf/gcc-head-build-ppu/./prev-gcc/cc1plus(_Z11toplev_mainiPPc-0x94c944)[0x1074da44]
/home/uweigand/fsf/gcc-head-build-ppu/./prev-gcc/cc1plus(main-0x436788)[0x10c8d4b0]
/lib64/power6x/libc.so.6[0x80f2f99d34]
/lib64/power6x/libc.so.6(__libc_start_main-0x176cf0)[0x80f2f99fd0]

[Bug rtl-optimization/53706] [4.8 Regression] Bootstrap failure due to "Invalid write of size 8 at 0xBDC35E: variable_htab_free (var-tracking.c:1418)

[ubizjak at gmail dot com]

http://gcc.gnu.org/bugzilla/show_bug.cgi?id=53706

--- Comment #12 from Uros Bizjak <ubizjak at gmail dot com> 2012-06-21 15:23:51 UTC ---
(In reply to comment #10)
> Patch that fixes all valgrind issues, but I have no idea if it is OK or not:

The patch doesn't pass the bootstrap.

[Bug rtl-optimization/53706] [4.8 Regression] Bootstrap failure due to "Invalid write of size 8 at 0xBDC35E: variable_htab_free (var-tracking.c:1418)

[ro at gcc dot gnu.org]

http://gcc.gnu.org/bugzilla/show_bug.cgi?id=53706

Rainer Orth <ro at gcc dot gnu.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |ro at gcc dot gnu.org

--- Comment #13 from Rainer Orth <ro at gcc dot gnu.org> 2012-06-25 14:55:41 UTC ---
I'm seeing SEGVs in i386-pc-solaris2.* bootstraps which a reghunt traced back
to the same patch.  I'm trying a bootstrap with Jakub's patch now.

  Rainer

[Bug rtl-optimization/53706] [4.8 Regression] Bootstrap failure due to "Invalid write of size 8 at 0xBDC35E: variable_htab_free (var-tracking.c:1418)

[ro at CeBiTec dot Uni-Bielefeld.DE]

http://gcc.gnu.org/bugzilla/show_bug.cgi?id=53706

--- Comment #14 from ro at CeBiTec dot Uni-Bielefeld.DE <ro at CeBiTec dot Uni-Bielefeld.DE> 2012-06-25 15:16:42 UTC ---
> --- Comment #13 from Rainer Orth <ro at gcc dot gnu.org> 2012-06-25 14:55:41 UTC ---
> I'm seeing SEGVs in i386-pc-solaris2.* bootstraps which a reghunt traced back
> to the same patch.  I'm trying a bootstrap with Jakub's patch now.

Unfortunately, the patch doesn't help: I still get the SEGV in stage 2:

g++: internal compiler error: Segmentation Fault (program cc1plus)
Please submit a full bug report,
with preprocessed source if appropriate.
See <http://gcc.gnu.org/bugs.html> for instructions.
make[3]: *** [tree-ssa-loop-prefetch.o] Error 4

    Rainer

[Bug rtl-optimization/53706] [4.8 Regression] Bootstrap failure due to "Invalid write of size 8 at 0xBDC35E: variable_htab_free (var-tracking.c:1418)

[wschmidt at gcc dot gnu.org]

http://gcc.gnu.org/bugzilla/show_bug.cgi?id=53706

William J. Schmidt <wschmidt at gcc dot gnu.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |wschmidt at gcc dot gnu.org

--- Comment #15 from William J. Schmidt <wschmidt at gcc dot gnu.org> 2012-06-26 16:25:08 UTC ---
*** Bug 53779 has been marked as a duplicate of this bug. ***

[Bug rtl-optimization/53706] [4.8 Regression] Bootstrap failure due to "Invalid write of size 8 at 0xBDC35E: variable_htab_free (var-tracking.c:1418)

[aoliva at gcc dot gnu.org]

http://gcc.gnu.org/bugzilla/show_bug.cgi?id=53706

Alexandre Oliva <aoliva at gcc dot gnu.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         AssignedTo|unassigned at gcc dot       |aoliva at gcc dot gnu.org
                   |gnu.org                     |

--- Comment #16 from Alexandre Oliva <aoliva at gcc dot gnu.org> 2012-06-26 20:29:28 UTC ---
I'm taking this over, at Jakub's request.

[Bug rtl-optimization/53706] [4.8 Regression] Bootstrap failure due to "Invalid write of size 8 at 0xBDC35E: variable_htab_free (var-tracking.c:1418)

[aoliva at gcc dot gnu.org]

http://gcc.gnu.org/bugzilla/show_bug.cgi?id=53706

Alexandre Oliva <aoliva at gcc dot gnu.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |ASSIGNED

--- Comment #17 from Alexandre Oliva <aoliva at gcc dot gnu.org> 2012-06-27 01:59:22 UTC ---
Rainer, I pretty sure Uros' revised patch in comment 10 should fix the problem.
 We shouldn't release th pool before we destroy the dataflow sets, because they
will access and release backrefs that may be in the pool.

Uros, you reported it ddn't bootstrap, bu you didn't provide any details.  Are
you sure it wasn't for some unrelated reason?

I'll momentarily test a variant of that patch on ia64, but I don't see why it
would fare any different.

[Bug rtl-optimization/53706] [4.8 Regression] Bootstrap failure due to "Invalid write of size 8 at 0xBDC35E: variable_htab_free (var-tracking.c:1418)

[aoliva at gcc dot gnu.org]

http://gcc.gnu.org/bugzilla/show_bug.cgi?id=53706

--- Comment #18 from Alexandre Oliva <aoliva at gcc dot gnu.org> 2012-06-27 05:43:33 UTC ---
I've just successfully bootstrapped a recent tree with (and without) the patch
on ia64-linux-gnu, so I'm going to regtest it and post it (with proper credit).

[Bug rtl-optimization/53706] [4.8 Regression] Bootstrap failure due to "Invalid write of size 8 at 0xBDC35E: variable_htab_free (var-tracking.c:1418)

[aoliva at gcc dot gnu.org]

http://gcc.gnu.org/bugzilla/show_bug.cgi?id=53706

--- Comment #19 from Alexandre Oliva <aoliva at gcc dot gnu.org> 2012-06-27 06:30:05 UTC ---
Alas, it doesn't work on i686 or x86_64: the free_alloc_pool in vt_finalize has
to be conditional on non-NULL, because we will skip vt_emit_notes (and thus the
initializer) in some cases.  I'm in awe that this didn't happen on ia64!

[Bug rtl-optimization/53706] [4.8 Regression] Bootstrap failure due to "Invalid write of size 8 at 0xBDC35E: variable_htab_free (var-tracking.c:1418)

[ro at CeBiTec dot Uni-Bielefeld.DE]

http://gcc.gnu.org/bugzilla/show_bug.cgi?id=53706

--- Comment #20 from ro at CeBiTec dot Uni-Bielefeld.DE <ro at CeBiTec dot Uni-Bielefeld.DE> 2012-06-27 09:00:52 UTC ---
> --- Comment #19 from Alexandre Oliva <aoliva at gcc dot gnu.org> 2012-06-27
> 06:30:05 UTC ---
> Alas, it doesn't work on i686 or x86_64: the free_alloc_pool in vt_finalize has
> to be conditional on non-NULL, because we will skip vt_emit_notes (and thus the
> initializer) in some cases.  I'm in awe that this didn't happen on ia64!

An i386-pc-solaris2.10 bootstrap with Uros' patch and the guard added is
now well into building the target libraries, so the bootstrap failure is
gone.  I'll report if I notice any testsuite regressions.

Thanks.
    Rainer

[Bug rtl-optimization/53706] [4.8 Regression] Bootstrap failure due to "Invalid write of size 8 at 0xBDC35E: variable_htab_free (var-tracking.c:1418)

[hp at gcc dot gnu.org]

http://gcc.gnu.org/bugzilla/show_bug.cgi?id=53706

Hans-Peter Nilsson <hp at gcc dot gnu.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |hp at gcc dot gnu.org

--- Comment #21 from Hans-Peter Nilsson <hp at gcc dot gnu.org> 2012-06-27 20:08:34 UTC ---
Adding me to CC as the revision range conincides with some cris-elf regressions
I see but haven't found the time to investigate...

[Bug rtl-optimization/53706] [4.8 Regression] Bootstrap failure due to "Invalid write of size 8 at 0xBDC35E: variable_htab_free (var-tracking.c:1418)

[aoliva at gcc dot gnu.org]

http://gcc.gnu.org/bugzilla/show_bug.cgi?id=53706

Alexandre Oliva <aoliva at gcc dot gnu.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|ASSIGNED                    |RESOLVED
         Resolution|                            |FIXED

--- Comment #22 from Alexandre Oliva <aoliva at gcc dot gnu.org> 2012-06-28 07:39:59 UTC ---
Author: aoliva
Date: Thu Jun 28 07:39:51 2012
New Revision: 189037

URL: http://gcc.gnu.org/viewcvs?root=gcc&view=rev&rev=189037
Log:
PR debug/53706
PR debug/47624
* var-tracking.c (vt_emit_notes): Release loc_exp_dep_pool...
(vt_finalize): ... here instead, if needed.

Modified:
    trunk/gcc/ChangeLog
    trunk/gcc/var-tracking.c

--- Comment #23 from Alexandre Oliva <aoliva at gcc dot gnu.org> 2012-06-28 07:45:58 UTC ---
Fixed

[Bug rtl-optimization/53706] [4.8 Regression] Bootstrap failure due to "Invalid write of size 8 at 0xBDC35E: variable_htab_free (var-tracking.c:1418)

[dcb314 at hotmail dot com]

http://gcc.gnu.org/bugzilla/show_bug.cgi?id=53706

dcb <dcb314 at hotmail dot com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |dcb314 at hotmail dot com

--- Comment #24 from dcb <dcb314 at hotmail dot com> 2012-07-01 10:58:15 UTC ---
*** Bug 53809 has been marked as a duplicate of this bug. ***