public inbox for gcc-bugs@sourceware.org
help / color / mirror / Atom feed
From: "janus at gcc dot gnu.org" <gcc-bugzilla@gcc.gnu.org>
To: gcc-bugs@gcc.gnu.org
Subject: [Bug fortran/53718] [4.7/4.8 regression] [OOP] gfortran generates asm label twice in the same output file
Date: Tue, 19 Jun 2012 13:13:00 -0000 [thread overview]
Message-ID: <bug-53718-4-Rdny1YXDoA@http.gcc.gnu.org/bugzilla/> (raw)
In-Reply-To: <bug-53718-4@http.gcc.gnu.org/bugzilla/>
http://gcc.gnu.org/bugzilla/show_bug.cgi?id=53718
--- Comment #7 from janus at gcc dot gnu.org 2012-06-19 13:13:03 UTC ---
(In reply to comment #6)
> > Could it be revision 181505?
>
> Very likely. If it is, I'm betting on the PR50640 part of that commit.
Indeed the following patch, which is practically a revert of the trans-decl.c
part of the above commit, makes the errors go away:
Index: gcc/fortran/trans-decl.c
===================================================================
--- gcc/fortran/trans-decl.c (revision 188334)
+++ gcc/fortran/trans-decl.c (working copy)
@@ -1483,7 +1483,6 @@ gfc_get_symbol_decl (gfc_symbol * sym)
|| (sym->name[0] == '_' && strncmp ("__def_init", sym->name, 10) == 0))
{
TREE_READONLY (decl) = 1;
- GFC_DECL_PUSH_TOPLEVEL (decl) = 1;
}
return decl;
@@ -1913,8 +1912,7 @@ build_function_decl (gfc_symbol * sym, bool global
/* Layout the function declaration and put it in the binding level
of the current function. */
- if (global
- || (sym->name[0] == '_' && strncmp ("__copy", sym->name, 6) == 0))
+ if (global)
pushdecl_top_level (fndecl);
else
pushdecl (fndecl);
next prev parent reply other threads:[~2012-06-19 13:13 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-06-18 17:43 [Bug fortran/53718] New: " adrian at llnl dot gov
2012-06-18 18:46 ` [Bug fortran/53718] [4.7/4.8 regression] [OOP] " janus at gcc dot gnu.org
2012-06-18 18:55 ` adrian at llnl dot gov
2012-06-18 20:04 ` janus at gcc dot gnu.org
2012-06-18 20:36 ` dominiq at lps dot ens.fr
2012-06-18 20:45 ` dominiq at lps dot ens.fr
2012-06-19 9:15 ` rguenth at gcc dot gnu.org
2012-06-19 10:35 ` janus at gcc dot gnu.org
2012-06-19 13:13 ` janus at gcc dot gnu.org [this message]
2012-06-19 17:36 ` dominiq at lps dot ens.fr
2012-06-20 9:19 ` janus at gcc dot gnu.org
2012-09-07 8:13 ` rguenth at gcc dot gnu.org
2012-09-11 13:48 ` burnus at gcc dot gnu.org
2012-09-11 15:57 ` janus at gcc dot gnu.org
2012-09-20 10:28 ` jakub at gcc dot gnu.org
2012-10-31 21:56 ` janus at gcc dot gnu.org
2012-10-31 22:03 ` [Bug fortran/53718] [4.7 " janus at gcc dot gnu.org
2013-01-27 21:32 ` janus at gcc dot gnu.org
2013-04-11 8:00 ` rguenth at gcc dot gnu.org
2014-06-12 13:12 ` rguenth at gcc dot gnu.org
2014-06-12 13:33 ` dominiq at lps dot ens.fr
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=bug-53718-4-Rdny1YXDoA@http.gcc.gnu.org/bugzilla/ \
--to=gcc-bugzilla@gcc.gnu.org \
--cc=gcc-bugs@gcc.gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).