[Bug c++/53752] New: ice in write_array_type

[Bug c++/53752] New: ice in write_array_type

[dcb314 at hotmail dot com]

http://gcc.gnu.org/bugzilla/show_bug.cgi?id=53752

             Bug #: 53752
           Summary: ice in write_array_type
    Classification: Unclassified
           Product: gcc
           Version: 4.8.0
            Status: UNCONFIRMED
          Severity: normal
          Priority: P3
         Component: c++
        AssignedTo: unassigned@gcc.gnu.org
        ReportedBy: dcb314@hotmail.com


I just tried to compile the package device-mapper-persistent-data-0.1.4-1
on gcc-4.8 trunk dated 20120620 on an AMD x86_64 box.

The compiler said

btree.tcc:495:1: internal compiler error: in write_array_type, at
cp/mangle.c:3124
 btree<Levels, ValueTraits>::remove(key const &key)
 ^
Please submit a full bug report,
with preprocessed source if appropriate.
See <http://gcc.gnu.org/bugs.html> for instructions.

Preprocessed source code attached. Flag -g required.

[Bug c++/53752] ice in write_array_type

[dcb314 at hotmail dot com]

http://gcc.gnu.org/bugzilla/show_bug.cgi?id=53752

--- Comment #1 from dcb <dcb314 at hotmail dot com> 2012-06-23 08:22:17 UTC ---
Created attachment 27689
  --> http://gcc.gnu.org/bugzilla/attachment.cgi?id=27689
gzipped C++ source code

[Bug c++/53752] ice in write_array_type

[hjl.tools at gmail dot com]

http://gcc.gnu.org/bugzilla/show_bug.cgi?id=53752

H.J. Lu <hjl.tools at gmail dot com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|UNCONFIRMED                 |NEW
   Last reconfirmed|                            |2012-06-23
                 CC|                            |rguenth at gcc dot gnu.org
   Target Milestone|---                         |4.8.0
     Ever Confirmed|0                           |1

--- Comment #2 from H.J. Lu <hjl.tools at gmail dot com> 2012-06-23 13:44:53 UTC ---
It is caused by revision 188386:

http://gcc.gnu.org/ml/gcc-cvs/2012-06/msg00296.html

[Bug c++/53752] [4.8 Regression] ice in write_array_type

[rguenth at gcc dot gnu.org]

http://gcc.gnu.org/bugzilla/show_bug.cgi?id=53752

Richard Guenther <rguenth at gcc dot gnu.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |ASSIGNED
      Known to work|                            |4.7.1
         AssignedTo|unassigned at gcc dot       |rguenth at gcc dot gnu.org
                   |gnu.org                     |
            Summary|ice in write_array_type     |[4.8 Regression] ice in
                   |                            |write_array_type

--- Comment #3 from Richard Guenther <rguenth at gcc dot gnu.org> 2012-06-25 08:01:19 UTC ---
Mine.  Interestingly enough works on the 4.7 branch (which has the same patch).

[Bug c++/53752] [4.8 Regression] ice in write_array_type

[rguenth at gcc dot gnu.org]

http://gcc.gnu.org/bugzilla/show_bug.cgi?id=53752

--- Comment #4 from Richard Guenther <rguenth at gcc dot gnu.org> 2012-06-25 08:44:35 UTC ---
Created attachment 27698
  --> http://gcc.gnu.org/bugzilla/attachment.cgi?id=27698
autoreduced testcase

We mangle an array with TYPE_DOMAIN [0, UINT_MAX], so it has UINT_MAX + 1
number
of elements.  The old code read

          /* The ABI specifies that we should mangle the number of
             elements in the array, not the largest allowed index.  */
          max = size_binop (PLUS_EXPR, max, size_one_node);
          write_unsigned_number (tree_low_cst (max, 1));

which of course simply truncated the result to zero, and only the verifying
that it fits into an unsigned host-wide-int.

[Bug c++/53752] [4.8 Regression] ice in write_array_type

[rguenth at gcc dot gnu.org]

http://gcc.gnu.org/bugzilla/show_bug.cgi?id=53752

Richard Guenther <rguenth at gcc dot gnu.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |jason at gcc dot gnu.org

--- Comment #5 from Richard Guenther <rguenth at gcc dot gnu.org> 2012-06-25 08:49:30 UTC ---
Jason - is that what is expected?  Or should we have rejected the array
before?  I suppose a value of zero is unused (apart from for the GNU extension
of array[0]).  But array[0] and array[ULONG_MAX] would mangle the same.

Patch that restores previous behavior:

Index: gcc/cp/mangle.c
===================================================================
--- gcc/cp/mangle.c     (revision 188927)
+++ gcc/cp/mangle.c     (working copy)
@@ -3121,6 +3121,9 @@ write_array_type (const tree type)
             elements in the array, not the largest allowed index.  */
          double_int dmax
            = double_int_add (tree_to_double_int (max), double_int_one);
+         /* Truncate the result - this will mangle [0, SIZE_INT_MAX]
+            number of elements as zero.  */
+         dmax = double_int_zext (dmax, TYPE_PRECISION (TREE_TYPE (max)));
          gcc_assert (double_int_fits_in_uhwi_p (dmax));
          write_unsigned_number (dmax.low);
        }

[Bug c++/53752] [4.8 Regression] ice in write_array_type

[jason at gcc dot gnu.org]

http://gcc.gnu.org/bugzilla/show_bug.cgi?id=53752

--- Comment #6 from Jason Merrill <jason at gcc dot gnu.org> 2012-06-25 17:36:18 UTC ---
(In reply to comment #4)
> We mangle an array with TYPE_DOMAIN [0, UINT_MAX], so it has UINT_MAX + 1
> number of elements.

Well, since that's how we represent an array of length 0, we need to mangle it
as 0.  This testcase isn't creating an array of length UINT_MAX+1, it's
creating an array of length 0.

[Bug c++/53752] [4.8 Regression] ice in write_array_type

[rguenth at gcc dot gnu.org]

http://gcc.gnu.org/bugzilla/show_bug.cgi?id=53752

--- Comment #7 from Richard Guenther <rguenth at gcc dot gnu.org> 2012-06-26 13:55:39 UTC ---
Author: rguenth
Date: Tue Jun 26 13:55:34 2012
New Revision: 188986

URL: http://gcc.gnu.org/viewcvs?root=gcc&view=rev&rev=188986
Log:
2012-06-26  Richard Guenther  <rguenther@suse.de>

    PR c++/53752
    * mangle.c (write_array_type): Truncate the number-of-elements
    result.

    * g++.dg/torture/pr53752.C: New testcase.

Added:
    trunk/gcc/testsuite/g++.dg/torture/pr53752.C
Modified:
    trunk/gcc/cp/ChangeLog
    trunk/gcc/cp/mangle.c
    trunk/gcc/testsuite/ChangeLog

[Bug c++/53752] [4.8 Regression] ice in write_array_type

[rguenth at gcc dot gnu.org]

http://gcc.gnu.org/bugzilla/show_bug.cgi?id=53752

Richard Guenther <rguenth at gcc dot gnu.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|ASSIGNED                    |RESOLVED
         Resolution|                            |FIXED

--- Comment #8 from Richard Guenther <rguenth at gcc dot gnu.org> 2012-06-26 14:03:06 UTC ---
Author: rguenth
Date: Tue Jun 26 14:03:02 2012
New Revision: 188987

URL: http://gcc.gnu.org/viewcvs?root=gcc&view=rev&rev=188987
Log:
2012-06-26  Richard Guenther  <rguenther@suse.de>

    PR c++/53752
    * mangle.c (write_array_type): Truncate the number-of-elements
    result.

    * g++.dg/torture/pr53752.C: New testcase.

Added:
    branches/gcc-4_7-branch/gcc/testsuite/g++.dg/torture/pr53752.C
Modified:
    branches/gcc-4_7-branch/gcc/cp/mangle.c
    branches/gcc-4_7-branch/gcc/testsuite/ChangeLog

--- Comment #9 from Richard Guenther <rguenth at gcc dot gnu.org> 2012-06-26 14:03:27 UTC ---
Fixed.

[Bug c++/53752] [4.8 Regression] ice in write_array_type

[rguenth at gcc dot gnu.org]

http://gcc.gnu.org/bugzilla/show_bug.cgi?id=53752

--- Comment #8 from Richard Guenther <rguenth at gcc dot gnu.org> 2012-06-26 14:03:06 UTC ---
Author: rguenth
Date: Tue Jun 26 14:03:02 2012
New Revision: 188987

URL: http://gcc.gnu.org/viewcvs?root=gcc&view=rev&rev=188987
Log:
2012-06-26  Richard Guenther  <rguenther@suse.de>

    PR c++/53752
    * mangle.c (write_array_type): Truncate the number-of-elements
    result.

    * g++.dg/torture/pr53752.C: New testcase.

Added:
    branches/gcc-4_7-branch/gcc/testsuite/g++.dg/torture/pr53752.C
Modified:
    branches/gcc-4_7-branch/gcc/cp/mangle.c
    branches/gcc-4_7-branch/gcc/testsuite/ChangeLog

[Bug c++/53752] [4.8 Regression] ice in write_array_type

[rguenth at gcc dot gnu.org]

http://gcc.gnu.org/bugzilla/show_bug.cgi?id=53752

Richard Guenther <rguenth at gcc dot gnu.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|ASSIGNED                    |RESOLVED
         Resolution|                            |FIXED

--- Comment #9 from Richard Guenther <rguenth at gcc dot gnu.org> 2012-06-26 14:03:27 UTC ---
Fixed.

[Bug c++/53752] [4.8 Regression] ice in write_array_type

[paolo.carlini at oracle dot com]

http://gcc.gnu.org/bugzilla/show_bug.cgi?id=53752

Paolo Carlini <paolo.carlini at oracle dot com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |jasongross9+bugzilla at
                   |                            |gmail dot com

--- Comment #10 from Paolo Carlini <paolo.carlini at oracle dot com> 2012-11-27 21:50:30 UTC ---
*** Bug 55495 has been marked as a duplicate of this bug. ***