[Bug middle-end/53850] New: [4.8 Regression] ICE: in expand_call_tm, at trans-mem.c:2289 with -fgnu-tm -O3

[Bug middle-end/53850] New: [4.8 Regression] ICE: in expand_call_tm, at trans-mem.c:2289 with -fgnu-tm -O3

[zsojka at seznam dot cz]

http://gcc.gnu.org/bugzilla/show_bug.cgi?id=53850

             Bug #: 53850
           Summary: [4.8 Regression] ICE: in expand_call_tm, at
                    trans-mem.c:2289 with -fgnu-tm -O3
    Classification: Unclassified
           Product: gcc
           Version: 4.8.0
            Status: UNCONFIRMED
          Severity: normal
          Priority: P3
         Component: middle-end
        AssignedTo: unassigned@gcc.gnu.org
        ReportedBy: zsojka@seznam.cz


Created attachment 27741
  --> http://gcc.gnu.org/bugzilla/attachment.cgi?id=27741
reduced testcase

Compiler flags:
-fgnu-tm -O3
or
-fgnu-tm -O2 -ftree-loop-distribute-patterns

Compiler output:
$ gcc -fgnu-tm -O2 -ftree-loop-distribute-patterns testcase.c 
testcase.c: In function 'foo':
testcase.c:4:1: internal compiler error: in expand_call_tm, at trans-mem.c:2289
 foo (void)
 ^
Please submit a full bug report,
with preprocessed source if appropriate.
See <http://gcc.gnu.org/bugs.html> for instructions.

(gdb) bt
#0  fancy_abort (file=0x12277d0 "/mnt/svn/gcc-trunk/gcc/trans-mem.c",
line=2289, function=0x1228230 "expand_call_tm")
    at /mnt/svn/gcc-trunk/gcc/diagnostic.c:1010
#1  0x0000000000a02b6a in expand_call_tm (gsi=0x7fffffffd410, region=0x194b820)
at /mnt/svn/gcc-trunk/gcc/trans-mem.c:2289
#2  expand_block_tm (bb=<optimized out>, region=0x194b820) at
/mnt/svn/gcc-trunk/gcc/trans-mem.c:2379
#3  execute_tm_mark () at /mnt/svn/gcc-trunk/gcc/trans-mem.c:2519
#4  0x000000000090c7d5 in execute_one_pass (pass=0x1757ac0) at
/mnt/svn/gcc-trunk/gcc/passes.c:2165
#5  0x000000000090cb95 in execute_pass_list (pass=0x1757ac0) at
/mnt/svn/gcc-trunk/gcc/passes.c:2220
#6  0x000000000090cba7 in execute_pass_list (pass=0x1757b20) at
/mnt/svn/gcc-trunk/gcc/passes.c:2221
#7  0x00000000006b7f98 in expand_function (node=0x7ffff6cef750) at
/mnt/svn/gcc-trunk/gcc/cgraphunit.c:1615
#8  0x00000000006b9d74 in expand_all_functions () at
/mnt/svn/gcc-trunk/gcc/cgraphunit.c:1720
#9  compile () at /mnt/svn/gcc-trunk/gcc/cgraphunit.c:2018
#10 0x00000000006ba335 in finalize_compilation_unit () at
/mnt/svn/gcc-trunk/gcc/cgraphunit.c:2095
#11 0x000000000059bb10 in c_write_global_declarations () at
/mnt/svn/gcc-trunk/gcc/c/c-decl.c:10116
#12 0x00000000009f6ff5 in compile_file () at
/mnt/svn/gcc-trunk/gcc/toplev.c:564
#13 0x00000000009f8b98 in do_compile () at /mnt/svn/gcc-trunk/gcc/toplev.c:1867
#14 toplev_main (argc=16, argv=0x7fffffffd6c8) at
/mnt/svn/gcc-trunk/gcc/toplev.c:1943
#15 0x00007ffff6f052ad in __libc_start_main () from /lib64/libc.so.6
#16 0x000000000057ef11 in _start ()

Tested revisions:
r189246 - crash
4.7 r188682 - OK

[Bug middle-end/53850] [4.8 Regression] ICE: in expand_call_tm, at trans-mem.c:2289 with -fgnu-tm -O3

[rguenth at gcc dot gnu.org]

http://gcc.gnu.org/bugzilla/show_bug.cgi?id=53850

Richard Guenther <rguenth at gcc dot gnu.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
   Target Milestone|---                         |4.8.0

[Bug middle-end/53850] [4.8 Regression] ICE: in expand_call_tm, at trans-mem.c:2289 with -fgnu-tm -O3

[patrick.marlier at gmail dot com]

http://gcc.gnu.org/bugzilla/show_bug.cgi?id=53850

Patrick Marlier <patrick.marlier at gmail dot com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |aldyh at gcc dot gnu.org,
                   |                            |patrick.marlier at gmail
                   |                            |dot com

--- Comment #1 from Patrick Marlier <patrick.marlier at gmail dot com> 2012-08-20 20:27:18 UTC ---
expand_call_tm fails because the memset builtin has no node associated to the
decl.
The problem here is that between tmipa and tmmark passes, some stores are
replaced by a memset. However tmipa is supposed to transform the memset builtin
to TM-aware memset (_ITM_memsetW). 
The solution I see is to postpone transformation of these builtins in tmmark
pass.

[Bug middle-end/53850] [4.8 Regression] ICE: in expand_call_tm, at trans-mem.c:2289 with -fgnu-tm -O3

[rguenth at gcc dot gnu.org]

http://gcc.gnu.org/bugzilla/show_bug.cgi?id=53850

Richard Guenther <rguenth at gcc dot gnu.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Priority|P3                          |P1

[Bug middle-end/53850] [4.8 Regression] ICE: in expand_call_tm, at trans-mem.c:2289 with -fgnu-tm -O3

[aldyh at gcc dot gnu.org]

http://gcc.gnu.org/bugzilla/show_bug.cgi?id=53850

Aldy Hernandez <aldyh at gcc dot gnu.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|UNCONFIRMED                 |NEW
   Last reconfirmed|                            |2012-09-21
         AssignedTo|unassigned at gcc dot       |aldyh at gcc dot gnu.org
                   |gnu.org                     |
     Ever Confirmed|0                           |1

--- Comment #2 from Aldy Hernandez <aldyh at gcc dot gnu.org> 2012-09-21 20:11:43 UTC ---
Mine.

[Bug middle-end/53850] [4.8 Regression] ICE: in expand_call_tm, at trans-mem.c:2289 with -fgnu-tm -O3

[aldyh at gcc dot gnu.org]

http://gcc.gnu.org/bugzilla/show_bug.cgi?id=53850

--- Comment #3 from Aldy Hernandez <aldyh at gcc dot gnu.org> 2012-09-21 20:12:55 UTC ---
Created attachment 28245
  --> http://gcc.gnu.org/bugzilla/attachment.cgi?id=28245
proposed patch being tested

[Bug middle-end/53850] [4.8 Regression] ICE: in expand_call_tm, at trans-mem.c:2289 with -fgnu-tm -O3

[aldyh at gcc dot gnu.org]

http://gcc.gnu.org/bugzilla/show_bug.cgi?id=53850

--- Comment #4 from Aldy Hernandez <aldyh at gcc dot gnu.org> 2012-09-25 18:47:40 UTC ---
Author: aldyh
Date: Tue Sep 25 18:47:35 2012
New Revision: 191742

URL: http://gcc.gnu.org/viewcvs?root=gcc&view=rev&rev=191742
Log:
    PR middle-end/53850
    * trans-mem.c (expand_call_tm): Handle late built built-ins.

Added:
    trunk/gcc/testsuite/gcc.dg/tm/pr53850.c
Modified:
    trunk/gcc/ChangeLog
    trunk/gcc/trans-mem.c

[Bug middle-end/53850] [4.8 Regression] ICE: in expand_call_tm, at trans-mem.c:2289 with -fgnu-tm -O3

[aldyh at gcc dot gnu.org]

http://gcc.gnu.org/bugzilla/show_bug.cgi?id=53850

Aldy Hernandez <aldyh at gcc dot gnu.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |RESOLVED
         Resolution|                            |FIXED

--- Comment #5 from Aldy Hernandez <aldyh at gcc dot gnu.org> 2012-09-25 18:59:11 UTC ---
fixed on mainline