public inbox for gcc-bugs@sourceware.org
help / color / mirror / Atom feed
From: "mikpe at it dot uu.se" <gcc-bugzilla@gcc.gnu.org>
To: gcc-bugs@gcc.gnu.org
Subject: [Bug rtl-optimization/53908] [4.6/4.7 Regression] csa removes needed memory load
Date: Tue, 10 Jul 2012 22:50:00 -0000	[thread overview]
Message-ID: <bug-53908-4-KAjAMfsbZd@http.gcc.gnu.org/bugzilla/> (raw)
In-Reply-To: <bug-53908-4@http.gcc.gnu.org/bugzilla/>

http://gcc.gnu.org/bugzilla/show_bug.cgi?id=53908

--- Comment #5 from Mikael Pettersson <mikpe at it dot uu.se> 2012-07-10 22:50:24 UTC ---
On x86_64-linux the SEGV went away on trunk with r186159:
http://gcc.gnu.org/ml/gcc-cvs/2012-04/msg00108.html
http://gcc.gnu.org/ml/gcc-patches/2012-04/msg00202.html

The patch description makes it sound more like a cleanup than fixing actual
bugs, but when I diff the assembly code for the test case with r186158 and
r186159 I see:

--- pr53908.s-r186158   2012-07-11 00:28:57.000000000 +0200
+++ pr53908.s-r186159   2012-07-11 00:34:32.000000000 +0200
...
        call    is_basic
        testl   %eax, %eax
-       movq    8(%rsp), %rbp
-       js      .L68
-.L29:
+       js      .L29
+.L33:
        movq    users(%rip), %rbx
+       movq    8(%rsp), %rbp
        testq   %rbx, %rbx
...

That is, a load is being moved across a control flow insn.  All other diffs
seem to just be changed label numbers.

I'll give it some more testing tomorrow.


  parent reply	other threads:[~2012-07-10 22:50 UTC|newest]

Thread overview: 23+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-07-10  3:06 [Bug rtl-optimization/53908] New: [4.7 " hp at gcc dot gnu.org
2012-07-10  9:05 ` [Bug rtl-optimization/53908] " mikpe at it dot uu.se
2012-07-10  9:09 ` rguenth at gcc dot gnu.org
2012-07-10 10:11 ` mikpe at it dot uu.se
2012-07-10 17:03 ` hp at gcc dot gnu.org
2012-07-10 19:55 ` mikpe at it dot uu.se
2012-07-10 22:50 ` mikpe at it dot uu.se [this message]
2012-07-11  6:27 ` [Bug rtl-optimization/53908] [4.6/4.7 " hjl.tools at gmail dot com
2012-07-11  8:05 ` hjl.tools at gmail dot com
2012-07-11  9:46 ` mikpe at it dot uu.se
2012-07-11 12:38 ` hjl.tools at gmail dot com
2012-07-13  6:53 ` hp at gcc dot gnu.org
2012-07-13  8:53 ` hp at gcc dot gnu.org
2012-07-13  8:59 ` hp at gcc dot gnu.org
2012-07-13 17:22 ` hp at gcc dot gnu.org
2012-07-13 17:23 ` hp at gcc dot gnu.org
2012-07-13 17:27 ` hp at gcc dot gnu.org
2012-07-13 17:39 ` [Bug rtl-optimization/53908] [4.6 " steven at gcc dot gnu.org
2012-07-13 17:41 ` steven at gcc dot gnu.org
2012-07-13 19:05 ` steven at gcc dot gnu.org
2012-07-13 19:10 ` hp at gcc dot gnu.org
2012-07-16  9:36 ` steven at gcc dot gnu.org
2012-11-08 22:23 ` steven at gcc dot gnu.org

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=bug-53908-4-KAjAMfsbZd@http.gcc.gnu.org/bugzilla/ \
    --to=gcc-bugzilla@gcc.gnu.org \
    --cc=gcc-bugs@gcc.gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).