public inbox for gcc-bugs@sourceware.org
help / color / mirror / Atom feed
From: "olegendo at gcc dot gnu.org" <gcc-bugzilla@gcc.gnu.org>
To: gcc-bugs@gcc.gnu.org
Subject: [Bug target/53976] [SH] Unnecessary clrt after bt
Date: Thu, 21 Nov 2013 09:03:00 -0000 [thread overview]
Message-ID: <bug-53976-4-Q00LIFikxy@http.gcc.gnu.org/bugzilla/> (raw)
In-Reply-To: <bug-53976-4@http.gcc.gnu.org/bugzilla/>
http://gcc.gnu.org/bugzilla/show_bug.cgi?id=53976
--- Comment #6 from Oleg Endo <olegendo at gcc dot gnu.org> ---
(In reply to Oleg Endo from comment #4)
> One option to get rid of the redundant clrt and sett in BBs that are reached
> with a conditional branch would be to add an SH specific RTL pass that
> analyses the BBs and eliminates the insns in question.
>
> Another option could be to try and inject artificial sett / clrt insns at
> the start of BBs that are reached by conditional branches, and then split
> them away to nops or output empty asm with insn length 0. The idea would be
> to let other already existing RTL passes figure out the redundant T bit sets.
I've decided to do it with an RTL pass, as it's easier and less obscure.
The initial version committed in r205191 only eliminates redundant sett / clrt
insns. However, there are also some opportunities to e.g. hoist sett / clrt
insns out of loops:
long long test0 (long long* a, unsigned int c)
{
long long s = 0;
do s += *a++; while (--c);
return s;
}
Currently compiles to:
_test0:
mov #0,r0
mov #0,r1
.align 2
.L3:
mov.l @r4+,r2
mov.l @r4+,r3
clrt
addc r3,r1
addc r2,r0
add #-1,r5
tst r5,r5
bf .L3
rts
nop
The previous T bit value at the clrt insn in the loop basic block is currently
detected to have an unknown value from the first basic block and value = 0
after the end of the loop.
In this case the clrt insn can be removed from the loop and put into the first
basic block:
_test0:
mov #0,r0
mov #0,r1
clrt
.align 2
.L3:
mov.l @r4+,r2
mov.l @r4+,r3
addc r3,r1
addc r2,r0
add #-1,r5
tst r5,r5
bf .L3
rts
nop
next prev parent reply other threads:[~2013-11-21 9:03 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-07-15 20:43 [Bug target/53976] New: " olegendo at gcc dot gnu.org
2012-09-23 20:50 ` [Bug target/53976] " olegendo at gcc dot gnu.org
2012-09-23 21:27 ` olegendo at gcc dot gnu.org
2013-08-03 8:08 ` olegendo at gcc dot gnu.org
2013-11-21 8:19 ` olegendo at gcc dot gnu.org
2013-11-21 9:03 ` olegendo at gcc dot gnu.org [this message]
2013-11-25 16:47 ` olegendo at gcc dot gnu.org
2014-08-13 22:02 ` [Bug target/53976] [SH] Unnecessary clrt/sett after bt/bf olegendo at gcc dot gnu.org
2014-11-23 17:37 ` olegendo at gcc dot gnu.org
2014-11-23 21:17 ` olegendo at gcc dot gnu.org
2014-11-23 21:45 ` olegendo at gcc dot gnu.org
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=bug-53976-4-Q00LIFikxy@http.gcc.gnu.org/bugzilla/ \
--to=gcc-bugzilla@gcc.gnu.org \
--cc=gcc-bugs@gcc.gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).