[Bug ada/53996] New: [PATCH] fixed format string issue in /gcc/gcc/ada/gcc-interface/utils.c

[Bug ada/53996] New: [PATCH] fixed format string issue in /gcc/gcc/ada/gcc-interface/utils.c

[ettl.martin at gmx dot de]

http://gcc.gnu.org/bugzilla/show_bug.cgi?id=53996

             Bug #: 53996
           Summary: [PATCH] fixed format string issue in
                    /gcc/gcc/ada/gcc-interface/utils.c
    Classification: Unclassified
           Product: gcc
           Version: unknown
            Status: UNCONFIRMED
          Severity: minor
          Priority: P3
         Component: ada
        AssignedTo: unassigned@gcc.gnu.org
        ReportedBy: ettl.martin@gmx.de


Created attachment 27813
  --> http://gcc.gnu.org/bugzilla/attachment.cgi?id=27813
proposed patch

Please review the attached patch. It fixes a format string issue in file:
/gcc/gcc/ada/gcc-interface/utils.c


This patch replaces the format string in an sprintf expression from %d to %u:

      sprintf (type_name, "%sSIGNED_%d", unsignedp ? "UN" : "", precision);

because the variable precision is of type unsigned, which requires %u.

Best regards

Ettl Martin

[Bug ada/53996] format string issue in gcc-interface/utils.c

[ebotcazou at gcc dot gnu.org]

http://gcc.gnu.org/bugzilla/show_bug.cgi?id=53996

Eric Botcazou <ebotcazou at gcc dot gnu.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|UNCONFIRMED                 |NEW
   Last reconfirmed|                            |2012-12-15
                 CC|                            |ebotcazou at gcc dot
                   |                            |gnu.org
            Version|unknown                     |4.8.0
            Summary|[PATCH] fixed format string |format string issue in
                   |issue in                    |gcc-interface/utils.c
                   |/gcc/gcc/ada/gcc-interface/ |
                   |utils.c                     |
     Ever Confirmed|0                           |1

--- Comment #1 from Eric Botcazou <ebotcazou at gcc dot gnu.org> 2012-12-15 12:01:08 UTC ---
Confirmed, will apply.

[Bug ada/53996] format string issue in gcc-interface/utils.c

[ebotcazou at gcc dot gnu.org]

http://gcc.gnu.org/bugzilla/show_bug.cgi?id=53996

--- Comment #2 from Eric Botcazou <ebotcazou at gcc dot gnu.org> 2012-12-15 17:50:55 UTC ---
Author: ebotcazou
Date: Sat Dec 15 17:50:49 2012
New Revision: 194520

URL: http://gcc.gnu.org/viewcvs?root=gcc&view=rev&rev=194520
Log:
    PR ada/53996
    * gcc-interface/utils.c (gnat_type_for_size): Use %u in lieu of %d.

Modified:
    trunk/gcc/ada/ChangeLog
    trunk/gcc/ada/gcc-interface/utils.c

[Bug ada/53996] format string issue in gcc-interface/utils.c

[ebotcazou at gcc dot gnu.org]

http://gcc.gnu.org/bugzilla/show_bug.cgi?id=53996

Eric Botcazou <ebotcazou at gcc dot gnu.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |RESOLVED
         Resolution|                            |FIXED
   Target Milestone|---                         |4.8.0

--- Comment #3 from Eric Botcazou <ebotcazou at gcc dot gnu.org> 2012-12-15 17:53:31 UTC ---
Thanks for reporting the issue.