From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: by sourceware.org (Postfix, from userid 48) id 0B1133858D3C; Wed, 21 Jun 2023 20:32:49 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 0B1133858D3C DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gcc.gnu.org; s=default; t=1687379570; bh=XBE3rsoYyD6Yr9nroezU7dTdTATveOe/BxoHTND0dTg=; h=From:To:Subject:Date:In-Reply-To:References:From; b=lXNa87erPnp7Dnpy/+THnSuOYP5B075qH8oY3DGmSGHkdiE39Ga7rZ6m7cz9b69jI 31O1M83r65Y3bYp6u7M0zTT6jPjLohrcLW//jM1djOL87eKcyJ4TA9EWEMGPGY2VQn +ZcmOkzI9fWSqvD4bqspZ8a8LZpNxIRqAoN+jnmo= From: "segher at gcc dot gnu.org" To: gcc-bugs@gcc.gnu.org Subject: [Bug target/54089] [SH] Refactor shift patterns Date: Wed, 21 Jun 2023 20:32:49 +0000 X-Bugzilla-Reason: CC X-Bugzilla-Type: changed X-Bugzilla-Watch-Reason: None X-Bugzilla-Product: gcc X-Bugzilla-Component: target X-Bugzilla-Version: 4.8.0 X-Bugzilla-Keywords: X-Bugzilla-Severity: enhancement X-Bugzilla-Who: segher at gcc dot gnu.org X-Bugzilla-Status: ASSIGNED X-Bugzilla-Resolution: X-Bugzilla-Priority: P3 X-Bugzilla-Assigned-To: olegendo at gcc dot gnu.org X-Bugzilla-Target-Milestone: --- X-Bugzilla-Flags: X-Bugzilla-Changed-Fields: Message-ID: In-Reply-To: References: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Bugzilla-URL: http://gcc.gnu.org/bugzilla/ Auto-Submitted: auto-generated MIME-Version: 1.0 List-Id: https://gcc.gnu.org/bugzilla/show_bug.cgi?id=3D54089 --- Comment #88 from Segher Boessenkool --- (In reply to Oleg Endo from comment #85) > > +/* { dg-final { scan-assembler "_f_loop1_rshift:.*mov\.l\\t(\.L\[0-9\]= +),(r\[0-9\]+).*sts.l\\tpr,@-r15.*(\.L\[0-9\]+):.*jsr\\t@\\2.*bf\.s\\t\\3.*= \\1:\\n\\t\.long\\t___ashiftrt_r4_6.*_f_loop2_rshift:" { target { ! has_dyn= _shift } } } } */ >=20 > Can you try to somehow write this in a simpler way? Maybe omit some of t= he > register number matches, as they don't matter etc. Do not use double-quoted strings unless you need interpolation? If you use= {} around the string you do not need to backslash-quote (and double-quote) so = much at all. [0-9] is \d whitespace is \s See the Tcl re_syntax manual page :-)=