From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <gcc-bugs-return-400650-listarch-gcc-bugs=gcc.gnu.org@gcc.gnu.org>
Received: (qmail 31746 invoked by alias); 10 Sep 2012 21:27:46 -0000
Received: (qmail 31737 invoked by uid 22791); 10 Sep 2012 21:27:45 -0000
X-SWARE-Spam-Status: No, hits=-4.3 required=5.0	tests=ALL_TRUSTED,AWL,BAYES_00,KHOP_THREADED
X-Spam-Check-By: sourceware.org
Received: from localhost (HELO gcc.gnu.org) (127.0.0.1)    by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Mon, 10 Sep 2012 21:27:31 +0000
From: "olegendo at gcc dot gnu.org" <gcc-bugzilla@gcc.gnu.org>
To: gcc-bugs@gcc.gnu.org
Subject: [Bug target/54089] [SH] Refactor shift patterns
Date: Mon, 10 Sep 2012 21:27:00 -0000
X-Bugzilla-Reason: CC
X-Bugzilla-Type: changed
X-Bugzilla-Watch-Reason: None
X-Bugzilla-Product: gcc
X-Bugzilla-Component: target
X-Bugzilla-Keywords:
X-Bugzilla-Severity: enhancement
X-Bugzilla-Who: olegendo at gcc dot gnu.org
X-Bugzilla-Status: ASSIGNED
X-Bugzilla-Priority: P3
X-Bugzilla-Assigned-To: olegendo at gcc dot gnu.org
X-Bugzilla-Target-Milestone: ---
X-Bugzilla-Changed-Fields:
Message-ID: <bug-54089-4-lJKBi7ooEA@http.gcc.gnu.org/bugzilla/>
In-Reply-To: <bug-54089-4@http.gcc.gnu.org/bugzilla/>
References: <bug-54089-4@http.gcc.gnu.org/bugzilla/>
X-Bugzilla-URL: http://gcc.gnu.org/bugzilla/
Auto-Submitted: auto-generated
Content-Type: text/plain; charset="UTF-8"
MIME-Version: 1.0
Mailing-List: contact gcc-bugs-help@gcc.gnu.org; run by ezmlm
Precedence: bulk
List-Id: <gcc-bugs.gcc.gnu.org>
List-Archive: <http://gcc.gnu.org/ml/gcc-bugs/>
List-Post: <mailto:gcc-bugs@gcc.gnu.org>
List-Help: <mailto:gcc-bugs-help@gcc.gnu.org>
Sender: gcc-bugs-owner@gcc.gnu.org
X-SW-Source: 2012-09/txt/msg00816.txt.bz2

http://gcc.gnu.org/bugzilla/show_bug.cgi?id=54089

--- Comment #17 from Oleg Endo <olegendo at gcc dot gnu.org> 2012-09-10 21:27:30 UTC ---
Created attachment 28163
  --> http://gcc.gnu.org/bugzilla/attachment.cgi?id=28163
Alternative dropped software dynamic ashlsi3,lshrsi3 patch

(In reply to comment #16)
> Author: olegendo
> Date: Mon Sep 10 20:35:25 2012
> New Revision: 191161
> 
> URL: http://gcc.gnu.org/viewcvs?root=gcc&view=rev&rev=191161
> Log:
>     PR target/54089
>     * config/sh/sh.h (SH_DYNAMIC_SHIFT_COST): Set always to 1 if
>     dynamic shifts are available.
>     (SHIFT_COUNT_TRUNCATED): Always define to 0.  Correct comment.
>     * config/sh/sh.c (ashl_lshr_seq, ext_ashl_lshr_seq): Add comments.
>     * config/sh/predicates.md (shift_count_operand): Allow
>     arith_reg_operand even if TARGET_DYNSHIFT is false.
>     * config/sh/sh.md (ashlsi3, lshrsi3): Expand library call patterns
>     if needed.
>     (ashlsi3_d_call, lshrsi3_d_call): New insns.
> 
>     PR target/54089
>     * config/sh/lib1funcs.S (ashlsi3): Reimplement as ashlsi3_r0.
>     (lshrsi3): Reimplement as lshrsi3_r0.
> 
>     PR target/54089
>     * gcc.target/sh/pr54089-3.c: New.
> 
> 
> Added:
>     trunk/gcc/testsuite/gcc.target/sh/pr54089-3.c
> Modified:
>     trunk/gcc/ChangeLog
>     trunk/gcc/config/sh/predicates.md
>     trunk/gcc/config/sh/sh.c
>     trunk/gcc/config/sh/sh.h
>     trunk/gcc/config/sh/sh.md
>     trunk/gcc/testsuite/ChangeLog
>     trunk/libgcc/ChangeLog
>     trunk/libgcc/config/sh/lib1funcs.S

This patch is just for the record/reference.  It is a little bit more complex
than the committed patch.  The main difference is the clobber list and the
input/output regs of the shift insns.  The committed version seemed more
beneficial.