public inbox for gcc-bugs@sourceware.org
help / color / mirror / Atom feed
From: "hubicka at ucw dot cz" <gcc-bugzilla@gcc.gnu.org>
To: gcc-bugs@gcc.gnu.org
Subject: [Bug middle-end/54146] Very slow compile with attribute((flatten))
Date: Fri, 10 Aug 2012 03:46:00 -0000	[thread overview]
Message-ID: <bug-54146-4-YqRBqR3yfO@http.gcc.gnu.org/bugzilla/> (raw)
In-Reply-To: <bug-54146-4@http.gcc.gnu.org/bugzilla/>

http://gcc.gnu.org/bugzilla/show_bug.cgi?id=54146

--- Comment #37 from Jan Hubicka <hubicka at ucw dot cz> 2012-08-10 03:45:31 UTC ---
> 
> I suppose it's the old issue that we update fibheap keys along each
> inlining decision - and with flatten there are just very many ... Honza?

Well, I killed most of updating for mainline and at flattening time the keys
are not
even computed.  So it is probably some other bookeping.  I will profile it.

> It also seems we flatten depth-first (thus inline leafs) instead of
> the other way around:
> 
>       orig_callee = callee;
>       inline_call (e, true, NULL, NULL);
>       if (e->callee != orig_callee)
>         orig_callee->symbol.aux = (void *) node;
>       flatten_function (e->callee, early);
>       if (e->callee != orig_callee)
>         orig_callee->symbol.aux = NULL;
> 
> This means we will materialize all intermediate flattenings in
> functions that will not be reclaimed, right?  flattening foo
> should inline everything into foo, but not affect remaining
> callee bodies.

I do not follow here.  Callee is already the inline clone, so we will
not affect other copies of foo...

Honza
> 
> Richard.
> 
> -- 
> Configure bugmail: http://gcc.gnu.org/bugzilla/userprefs.cgi?tab=email
> ------- You are receiving this mail because: -------
> You are on the CC list for the bug.


  parent reply	other threads:[~2012-08-10  3:46 UTC|newest]

Thread overview: 66+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-07-31 18:33 [Bug middle-end/54146] New: Very slow compile at -O1 (expand vars) glisse at gcc dot gnu.org
2012-07-31 18:38 ` [Bug middle-end/54146] " pinskia at gcc dot gnu.org
2012-07-31 18:48 ` glisse at gcc dot gnu.org
2012-07-31 20:17 ` steven at gcc dot gnu.org
2012-07-31 20:34 ` steven at gcc dot gnu.org
2012-07-31 22:17 ` steven at gcc dot gnu.org
2012-07-31 23:00 ` steven at gcc dot gnu.org
2012-08-01 12:22 ` steven at gcc dot gnu.org
2012-08-01 14:08 ` steven at gcc dot gnu.org
2012-08-01 14:14 ` steven at gcc dot gnu.org
2012-08-01 14:25 ` steven at gcc dot gnu.org
2012-08-01 14:32 ` rguenth at gcc dot gnu.org
2012-08-01 16:00 ` glisse at gcc dot gnu.org
2012-08-02 10:01 ` [Bug tree-optimization/54146] Very slow compile with attribute((flatten)) steven at gcc dot gnu.org
2012-08-02 10:37 ` rguenther at suse dot de
2012-08-03  9:00 ` steven at gcc dot gnu.org
2012-08-03 14:44 ` matz at gcc dot gnu.org
2012-08-05 11:39 ` steven at gcc dot gnu.org
2012-08-05 18:49 ` steven at gcc dot gnu.org
2012-08-05 21:14 ` steven at gcc dot gnu.org
2012-08-06  8:46 ` rguenth at gcc dot gnu.org
2012-08-06  9:10 ` stevenb.gcc at gmail dot com
2012-08-06 15:36 ` steven at gcc dot gnu.org
2012-08-06 19:37 ` steven at gcc dot gnu.org
2012-08-06 20:22 ` steven at gcc dot gnu.org
2012-08-06 20:56 ` steven at gcc dot gnu.org
2012-08-06 22:43 ` steven at gcc dot gnu.org
2012-08-06 22:59 ` steven at gcc dot gnu.org
2012-08-07 11:59 ` rguenth at gcc dot gnu.org
2012-08-07 19:58 ` steven at gcc dot gnu.org
2012-08-07 22:28 ` steven at gcc dot gnu.org
2012-08-07 22:37 ` steven at gcc dot gnu.org
2012-08-08  6:28 ` steven at gcc dot gnu.org
2012-08-08  6:29 ` steven at gcc dot gnu.org
2012-08-08  6:30 ` [Bug middle-end/54146] " steven at gcc dot gnu.org
2012-08-08  6:30 ` steven at gcc dot gnu.org
2012-08-08  8:10 ` rguenth at gcc dot gnu.org
2012-08-08 10:11 ` steven at gcc dot gnu.org
2012-08-08 11:49 ` rguenth at gcc dot gnu.org
2012-08-08 17:40 ` steven at gcc dot gnu.org
2012-08-10  3:46 ` hubicka at ucw dot cz [this message]
2012-08-10  3:51 ` hubicka at ucw dot cz
2012-08-10  3:54 ` hubicka at ucw dot cz
2012-08-10  4:35 ` hubicka at gcc dot gnu.org
2012-08-10  5:19 ` hubicka at gcc dot gnu.org
2012-08-10  6:33 ` steven at gcc dot gnu.org
2012-08-10  7:53 ` hubicka at gcc dot gnu.org
2012-08-14 12:39 ` rguenth at gcc dot gnu.org
2012-08-14 13:21 ` glisse at gcc dot gnu.org
2012-08-15 14:34 ` steven at gcc dot gnu.org
2012-08-15 15:07 ` steven at gcc dot gnu.org
2012-08-16 10:53 ` steven at gcc dot gnu.org
2012-08-16 12:11 ` rguenth at gcc dot gnu.org
2012-08-16 13:56 ` stevenb.gcc at gmail dot com
2012-08-16 14:07 ` rguenther at suse dot de
2012-08-16 14:28 ` rguenth at gcc dot gnu.org
2012-08-16 23:04 ` steven at gcc dot gnu.org
2012-08-17  9:43 ` steven at gcc dot gnu.org
2012-08-20 19:31 ` steven at gcc dot gnu.org
2012-08-21  7:56 ` rguenther at suse dot de
2012-08-21 13:35 ` rguenth at gcc dot gnu.org
2012-08-21 13:57 ` stevenb.gcc at gmail dot com
2012-09-02 22:55 ` steven at gcc dot gnu.org
2012-09-04 10:51 ` steven at gcc dot gnu.org
2012-09-10 16:05 ` hubicka at ucw dot cz
2012-10-15 21:32 ` steven at gcc dot gnu.org

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=bug-54146-4-YqRBqR3yfO@http.gcc.gnu.org/bugzilla/ \
    --to=gcc-bugzilla@gcc.gnu.org \
    --cc=gcc-bugs@gcc.gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).