public inbox for gcc-bugs@sourceware.org
help / color / mirror / Atom feed
* [Bug other/54150] New: [4.8 Regression] gimple dumps no longer honor -blocks
@ 2012-08-01 13:09 rguenth at gcc dot gnu.org
2012-08-01 13:12 ` [Bug other/54150] " rguenth at gcc dot gnu.org
` (6 more replies)
0 siblings, 7 replies; 8+ messages in thread
From: rguenth at gcc dot gnu.org @ 2012-08-01 13:09 UTC (permalink / raw)
To: gcc-bugs
http://gcc.gnu.org/bugzilla/show_bug.cgi?id=54150
Bug #: 54150
Summary: [4.8 Regression] gimple dumps no longer honor -blocks
Classification: Unclassified
Product: gcc
Version: 4.8.0
Status: UNCONFIRMED
Severity: normal
Priority: P3
Component: other
AssignedTo: unassigned@gcc.gnu.org
ReportedBy: rguenth@gcc.gnu.org
CC: stevenb.gcc@gmail.com
gimple dumps now by default dump a RTL-like bb header:
;; basic block 2, loop depth 0
;; pred: ENTRY
D.1602_12 = (sizetype) m_5(D);
D.1603_13 = D.1602_12 * 4;
goto <bb 6>;
;; succ: 6
previously TDF_blocks was required for that (and I'd like to have that back).
Also notice the extra newline before ;; succ: which seems to be caused by
pp_base_flush which does not only flush but also prints a newline, and that
independent on whether pp_needs_newline is set.
That said, the tree dumps still look remarkably ugly by default now.
^ permalink raw reply [flat|nested] 8+ messages in thread
* [Bug other/54150] [4.8 Regression] gimple dumps no longer honor -blocks
2012-08-01 13:09 [Bug other/54150] New: [4.8 Regression] gimple dumps no longer honor -blocks rguenth at gcc dot gnu.org
@ 2012-08-01 13:12 ` rguenth at gcc dot gnu.org
2012-08-01 13:18 ` steven at gcc dot gnu.org
` (5 subsequent siblings)
6 siblings, 0 replies; 8+ messages in thread
From: rguenth at gcc dot gnu.org @ 2012-08-01 13:12 UTC (permalink / raw)
To: gcc-bugs
http://gcc.gnu.org/bugzilla/show_bug.cgi?id=54150
Richard Guenther <rguenth at gcc dot gnu.org> changed:
What |Removed |Added
----------------------------------------------------------------------------
CC| |gdr at gcc dot gnu.org
Target Milestone|--- |4.8.0
--- Comment #1 from Richard Guenther <rguenth at gcc dot gnu.org> 2012-08-01 13:12:36 UTC ---
IMHO pp_base_flush should not output a newline ever and instead look like
/* Flush the content of BUFFER onto the attached stream. */
void
pp_base_flush (pretty_printer *pp)
{
pp_write_text_to_stream (pp);
pp_clear_state (pp);
fflush (pp->buffer->stream);
}
which co-incidentially does not need any documentation adjustments.
^ permalink raw reply [flat|nested] 8+ messages in thread
* [Bug other/54150] [4.8 Regression] gimple dumps no longer honor -blocks
2012-08-01 13:09 [Bug other/54150] New: [4.8 Regression] gimple dumps no longer honor -blocks rguenth at gcc dot gnu.org
2012-08-01 13:12 ` [Bug other/54150] " rguenth at gcc dot gnu.org
@ 2012-08-01 13:18 ` steven at gcc dot gnu.org
2012-08-03 8:22 ` steven at gcc dot gnu.org
` (4 subsequent siblings)
6 siblings, 0 replies; 8+ messages in thread
From: steven at gcc dot gnu.org @ 2012-08-01 13:18 UTC (permalink / raw)
To: gcc-bugs
http://gcc.gnu.org/bugzilla/show_bug.cgi?id=54150
Steven Bosscher <steven at gcc dot gnu.org> changed:
What |Removed |Added
----------------------------------------------------------------------------
Status|UNCONFIRMED |ASSIGNED
Last reconfirmed| |2012-08-01
Ever Confirmed|0 |1
--- Comment #2 from Steven Bosscher <steven at gcc dot gnu.org> 2012-08-01 13:18:06 UTC ---
(In reply to comment #0)
> That said, the tree dumps still look remarkably ugly by default now.
That is a debate of taste that I don't think we ought to get into.
I had technical reasons why I made this so: Various scripts that do CFG
analysis can now parse GIMPLE and RTL dumps without modification.
The dumper should honor TDF_BLOCKS, and I'll take care of fixing that.
^ permalink raw reply [flat|nested] 8+ messages in thread
* [Bug other/54150] [4.8 Regression] gimple dumps no longer honor -blocks
2012-08-01 13:09 [Bug other/54150] New: [4.8 Regression] gimple dumps no longer honor -blocks rguenth at gcc dot gnu.org
2012-08-01 13:12 ` [Bug other/54150] " rguenth at gcc dot gnu.org
2012-08-01 13:18 ` steven at gcc dot gnu.org
@ 2012-08-03 8:22 ` steven at gcc dot gnu.org
2012-08-03 8:42 ` rguenth at gcc dot gnu.org
` (3 subsequent siblings)
6 siblings, 0 replies; 8+ messages in thread
From: steven at gcc dot gnu.org @ 2012-08-03 8:22 UTC (permalink / raw)
To: gcc-bugs
http://gcc.gnu.org/bugzilla/show_bug.cgi?id=54150
--- Comment #3 from Steven Bosscher <steven at gcc dot gnu.org> 2012-08-03 08:22:12 UTC ---
Created attachment 27929
--> http://gcc.gnu.org/bugzilla/attachment.cgi?id=27929
Adjust pp_flush as per suggestion of comment #1, and honor ~TDF_BLOCKS
Could the OP please give this patch a try, and see if it adjusts the dumps to
satisfy his delicate taste? :-)
^ permalink raw reply [flat|nested] 8+ messages in thread
* [Bug other/54150] [4.8 Regression] gimple dumps no longer honor -blocks
2012-08-01 13:09 [Bug other/54150] New: [4.8 Regression] gimple dumps no longer honor -blocks rguenth at gcc dot gnu.org
` (2 preceding siblings ...)
2012-08-03 8:22 ` steven at gcc dot gnu.org
@ 2012-08-03 8:42 ` rguenth at gcc dot gnu.org
2012-08-06 11:44 ` steven at gcc dot gnu.org
` (2 subsequent siblings)
6 siblings, 0 replies; 8+ messages in thread
From: rguenth at gcc dot gnu.org @ 2012-08-03 8:42 UTC (permalink / raw)
To: gcc-bugs
http://gcc.gnu.org/bugzilla/show_bug.cgi?id=54150
--- Comment #4 from Richard Guenther <rguenth at gcc dot gnu.org> 2012-08-03 08:42:02 UTC ---
The excessive newline is gone! Nice. Unfortunately tree dumps, like
-fdump-tree-pre still show TDF_BLOCKS info by default and there is no
-fdump-tree-pre-no-blocks. I'd like to have -fdump-tree-pre _not_ enable
TDF_BLOCKS as it was before (you seem to have changed debug_bb only?)
^ permalink raw reply [flat|nested] 8+ messages in thread
* [Bug other/54150] [4.8 Regression] gimple dumps no longer honor -blocks
2012-08-01 13:09 [Bug other/54150] New: [4.8 Regression] gimple dumps no longer honor -blocks rguenth at gcc dot gnu.org
` (3 preceding siblings ...)
2012-08-03 8:42 ` rguenth at gcc dot gnu.org
@ 2012-08-06 11:44 ` steven at gcc dot gnu.org
2012-08-06 11:58 ` rguenth at gcc dot gnu.org
2012-09-19 14:15 ` rguenth at gcc dot gnu.org
6 siblings, 0 replies; 8+ messages in thread
From: steven at gcc dot gnu.org @ 2012-08-06 11:44 UTC (permalink / raw)
To: gcc-bugs
http://gcc.gnu.org/bugzilla/show_bug.cgi?id=54150
Steven Bosscher <steven at gcc dot gnu.org> changed:
What |Removed |Added
----------------------------------------------------------------------------
Attachment #27929|0 |1
is obsolete| |
--- Comment #5 from Steven Bosscher <steven at gcc dot gnu.org> 2012-08-06 11:44:14 UTC ---
Created attachment 27951
--> http://gcc.gnu.org/bugzilla/attachment.cgi?id=27951
Patch, 2nd try
Here's take 2. A few test cases also needed fixing.
BTW, the dumps are also ugly because the alias dumper doesn't honor
TDF_DETAILS. If I ask for just the -fdump-tree-pre dump, I get the function
_and_ all the alias analysis constraints and solutions. It would be nice if
that can be fixed as well.
^ permalink raw reply [flat|nested] 8+ messages in thread
* [Bug other/54150] [4.8 Regression] gimple dumps no longer honor -blocks
2012-08-01 13:09 [Bug other/54150] New: [4.8 Regression] gimple dumps no longer honor -blocks rguenth at gcc dot gnu.org
` (4 preceding siblings ...)
2012-08-06 11:44 ` steven at gcc dot gnu.org
@ 2012-08-06 11:58 ` rguenth at gcc dot gnu.org
2012-09-19 14:15 ` rguenth at gcc dot gnu.org
6 siblings, 0 replies; 8+ messages in thread
From: rguenth at gcc dot gnu.org @ 2012-08-06 11:58 UTC (permalink / raw)
To: gcc-bugs
http://gcc.gnu.org/bugzilla/show_bug.cgi?id=54150
--- Comment #6 from Richard Guenther <rguenth at gcc dot gnu.org> 2012-08-06 11:58:07 UTC ---
Looks good to me (aka, ok if it bootstraps & regtests). Thanks for fixing
this.
Yes, the PTA dumps in -pre are annoying (PTA is triggered by a TODO here ...).
I'll put it on my TODO list of things to clean up.
^ permalink raw reply [flat|nested] 8+ messages in thread
* [Bug other/54150] [4.8 Regression] gimple dumps no longer honor -blocks
2012-08-01 13:09 [Bug other/54150] New: [4.8 Regression] gimple dumps no longer honor -blocks rguenth at gcc dot gnu.org
` (5 preceding siblings ...)
2012-08-06 11:58 ` rguenth at gcc dot gnu.org
@ 2012-09-19 14:15 ` rguenth at gcc dot gnu.org
6 siblings, 0 replies; 8+ messages in thread
From: rguenth at gcc dot gnu.org @ 2012-09-19 14:15 UTC (permalink / raw)
To: gcc-bugs
http://gcc.gnu.org/bugzilla/show_bug.cgi?id=54150
Richard Guenther <rguenth at gcc dot gnu.org> changed:
What |Removed |Added
----------------------------------------------------------------------------
Status|ASSIGNED |RESOLVED
Resolution| |FIXED
--- Comment #7 from Richard Guenther <rguenth at gcc dot gnu.org> 2012-09-19 14:15:06 UTC ---
Fixed.
^ permalink raw reply [flat|nested] 8+ messages in thread
end of thread, other threads:[~2012-09-19 14:15 UTC | newest]
Thread overview: 8+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2012-08-01 13:09 [Bug other/54150] New: [4.8 Regression] gimple dumps no longer honor -blocks rguenth at gcc dot gnu.org
2012-08-01 13:12 ` [Bug other/54150] " rguenth at gcc dot gnu.org
2012-08-01 13:18 ` steven at gcc dot gnu.org
2012-08-03 8:22 ` steven at gcc dot gnu.org
2012-08-03 8:42 ` rguenth at gcc dot gnu.org
2012-08-06 11:44 ` steven at gcc dot gnu.org
2012-08-06 11:58 ` rguenth at gcc dot gnu.org
2012-09-19 14:15 ` rguenth at gcc dot gnu.org
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).