[Bug preprocessor/54160] New: gcc should not define __OBJC2__ when lang is not set to ObjC (gcc 4.6 and later)

[Bug preprocessor/54160] New: gcc should not define __OBJC2__ when lang is not set to ObjC (gcc 4.6 and later)

[jeremyhu at macports dot org]

http://gcc.gnu.org/bugzilla/show_bug.cgi?id=54160

             Bug #: 54160
           Summary: gcc should not define __OBJC2__ when lang is not set
                    to ObjC (gcc 4.6 and later)
    Classification: Unclassified
           Product: gcc
           Version: 4.8.0
            Status: UNCONFIRMED
          Severity: normal
          Priority: P3
         Component: preprocessor
        AssignedTo: unassigned@gcc.gnu.org
        ReportedBy: jeremyhu@macports.org


gcc should not be defining the __OBJC2__ preprocessor macro when it is not
building for the Objective C or Objective C++ languages.

~ $ echo "" | gcc-mp-4.5 -x objective-c -E -dM - | grep OBJ
#define __OBJC__ 1

~ $ echo "" | gcc-mp-4.5 -E -dM - | grep OBJ

~ $ echo "" | gcc-mp-4.6 -x objective-c -E -dM - | grep OBJ
#define __OBJC__ 1
#define __OBJC2__ 1

~ $ echo "" | gcc-mp-4.6 -E -dM - | grep OBJ
#define __OBJC2__ 1

This is a regression that entered gcc 4.6 and is present in current versions of
4.6, 4.7, and 4.8 snapshots

[Bug preprocessor/54160] [4.6/4.7/4.8 Regression] gcc should not define __OBJC2__ when lang is not set to ObjC (gcc 4.6 and later)

[rguenth at gcc dot gnu.org]

http://gcc.gnu.org/bugzilla/show_bug.cgi?id=54160

Richard Guenther <rguenth at gcc dot gnu.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|UNCONFIRMED                 |NEW
   Last reconfirmed|                            |2012-08-03
   Target Milestone|---                         |4.6.4
            Summary|gcc should not define       |[4.6/4.7/4.8 Regression]
                   |__OBJC2__ when lang is not  |gcc should not define
                   |set to ObjC (gcc 4.6 and    |__OBJC2__ when lang is not
                   |later)                      |set to ObjC (gcc 4.6 and
                   |                            |later)
     Ever Confirmed|0                           |1

--- Comment #1 from Richard Guenther <rguenth at gcc dot gnu.org> 2012-08-03 08:06:30 UTC ---
Confirmed.

[Bug target/54160] [4.6/4.7/4.8 Regression] gcc should not define __OBJC2__ when lang is not set to ObjC (gcc 4.6 and later)

[steven at gcc dot gnu.org]

http://gcc.gnu.org/bugzilla/show_bug.cgi?id=54160

Steven Bosscher <steven at gcc dot gnu.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Target|                            |darwin*
                 CC|                            |nicola at gcc dot gnu.org
          Component|preprocessor                |target

--- Comment #2 from Steven Bosscher <steven at gcc dot gnu.org> 2012-08-03 09:28:20 UTC ---
Darwin only. See http://gcc.gnu.org/viewcvs?view=revision&revision=170260

[Bug target/54160] [4.6/4.7/4.8 Regression] gcc should not define __OBJC2__ when lang is not set to ObjC (gcc 4.6 and later)

[rguenth at gcc dot gnu.org]

http://gcc.gnu.org/bugzilla/show_bug.cgi?id=54160

Richard Guenther <rguenth at gcc dot gnu.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Priority|P3                          |P2

[Bug target/54160] [4.6/4.7/4.8 Regression] gcc should not define __OBJC2__ when lang is not set to ObjC (gcc 4.6 and later)

[aldyh at gcc dot gnu.org]

http://gcc.gnu.org/bugzilla/show_bug.cgi?id=54160

Aldy Hernandez <aldyh at gcc dot gnu.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |aldyh at gcc dot gnu.org
         AssignedTo|unassigned at gcc dot       |aldyh at gcc dot gnu.org
                   |gnu.org                     |

--- Comment #3 from Aldy Hernandez <aldyh at gcc dot gnu.org> 2012-12-04 20:35:54 UTC ---
I'll take a look.

[Bug target/54160] [4.6/4.7/4.8 Regression] gcc should not define __OBJC2__ when lang is not set to ObjC (gcc 4.6 and later)

[aldyh at gcc dot gnu.org]

http://gcc.gnu.org/bugzilla/show_bug.cgi?id=54160

--- Comment #4 from Aldy Hernandez <aldyh at gcc dot gnu.org> 2012-12-04 22:28:54 UTC ---
Proposed patch.
http://gcc.gnu.org/ml/gcc-patches/2012-12/msg00261.html

[Bug target/54160] [4.6/4.7/4.8 Regression] gcc should not define __OBJC2__ when lang is not set to ObjC (gcc 4.6 and later)

[aldyh at gcc dot gnu.org]

http://gcc.gnu.org/bugzilla/show_bug.cgi?id=54160

--- Comment #5 from Aldy Hernandez <aldyh at gcc dot gnu.org> 2012-12-05 21:10:25 UTC ---
Author: aldyh
Date: Wed Dec  5 21:10:18 2012
New Revision: 194227

URL: http://gcc.gnu.org/viewcvs?root=gcc&view=rev&rev=194227
Log:
    PR target/54160
    * config/t-darwin (darwin-c.o): Depend on $(CPP_INTERNAL_H).
    * config/darwin-c.c (darwin_cpp_builtins): Only set __OBJC2__
    when in obj mode.
    Include libcpp/internal.h.

Modified:
    trunk/gcc/ChangeLog
    trunk/gcc/config/darwin-c.c
    trunk/gcc/config/t-darwin

[Bug target/54160] [4.6/4.7/4.8 Regression] gcc should not define __OBJC2__ when lang is not set to ObjC (gcc 4.6 and later)

[aldyh at gcc dot gnu.org]

http://gcc.gnu.org/bugzilla/show_bug.cgi?id=54160

Aldy Hernandez <aldyh at gcc dot gnu.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |RESOLVED
         Resolution|                            |FIXED

--- Comment #6 from Aldy Hernandez <aldyh at gcc dot gnu.org> 2012-12-05 21:13:09 UTC ---
Fixed on trunk.