[Bug fortran/54189] New: ICE (segfault) with invalid assumed-size dummy

[Bug fortran/54189] New: ICE (segfault) with invalid assumed-size dummy

[burnus at gcc dot gnu.org]

http://gcc.gnu.org/bugzilla/show_bug.cgi?id=54189

             Bug #: 54189
           Summary: ICE (segfault) with invalid assumed-size dummy
    Classification: Unclassified
           Product: gcc
           Version: 4.8.0
            Status: UNCONFIRMED
          Keywords: ice-on-invalid-code
          Severity: normal
          Priority: P3
         Component: fortran
        AssignedTo: unassigned@gcc.gnu.org
        ReportedBy: burnus@gcc.gnu.org


Cf. http://gcc.gnu.org/ml/fortran/2012-08/msg00034.html

The following program ICEs in check_assumed_size_reference's
1386      if ((e->ref->u.ar.end[e->ref->u.ar.as->rank - 1] == NULL)
as e->ref == NULL.


implicit none
contains
function g()
  integer :: g(*)
end function g


subroutine test()
  procedure(g), pointer :: x
  x => g
end subroutine test
end

[Bug fortran/54189] ICE (segfault) with invalid assumed-size dummy

[janus at gcc dot gnu.org]

http://gcc.gnu.org/bugzilla/show_bug.cgi?id=54189

janus at gcc dot gnu.org changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|UNCONFIRMED                 |ASSIGNED
   Last reconfirmed|                            |2013-05-29
                 CC|                            |janus at gcc dot gnu.org
           Assignee|unassigned at gcc dot gnu.org      |janus at gcc dot gnu.org
     Ever confirmed|0                           |1

--- Comment #1 from janus at gcc dot gnu.org ---
Trivial patch:

Index: gcc/fortran/resolve.c
===================================================================
--- gcc/fortran/resolve.c    (revision 199388)
+++ gcc/fortran/resolve.c    (working copy)
@@ -1459,7 +1459,7 @@ check_assumed_size_reference (gfc_symbol *sym, gfc

   /* FIXME: The comparison "e->ref->u.ar.type == AR_FULL" is wrong.
      What should it be?  */
-  if ((e->ref->u.ar.end[e->ref->u.ar.as->rank - 1] == NULL)
+  if (e->ref && (e->ref->u.ar.end[e->ref->u.ar.as->rank - 1] == NULL)
       && (e->ref->u.ar.as->type == AS_ASSUMED_SIZE)
            && (e->ref->u.ar.type == AR_FULL))
     {

[Bug fortran/54189] ICE (segfault) with invalid assumed-size dummy

[janus at gcc dot gnu.org]

http://gcc.gnu.org/bugzilla/show_bug.cgi?id=54189

--- Comment #2 from janus at gcc dot gnu.org ---
(In reply to janus from comment #1)
> Trivial patch:

Regtests cleanly. Will commit as obvious.

[Bug fortran/54189] ICE (segfault) with invalid assumed-size dummy

[janus at gcc dot gnu.org]

http://gcc.gnu.org/bugzilla/show_bug.cgi?id=54189

janus at gcc dot gnu.org changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|ASSIGNED                    |RESOLVED
         Resolution|---                         |FIXED

--- Comment #3 from janus at gcc dot gnu.org ---
Fixed with r199445. Closing.




Author: janus
Date: Thu May 30 10:19:16 2013
New Revision: 199445

URL: http://gcc.gnu.org/viewcvs?rev=199445&root=gcc&view=rev
Log:
2013-05-30  Janus Weil  <janus@gcc.gnu.org>

    PR fortran/54189
    * resolve.c (check_assumed_size_reference): Check for e->ref.


2013-05-30  Janus Weil  <janus@gcc.gnu.org>

    PR fortran/54189
    * gfortran.dg/assumed_size_1.f90: New.

Added:
    trunk/gcc/testsuite/gfortran.dg/assumed_size_1.f90
Modified:
    trunk/gcc/fortran/ChangeLog
    trunk/gcc/fortran/resolve.c
    trunk/gcc/testsuite/ChangeLog