From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <gcc-bugs-return-398156-listarch-gcc-bugs=gcc.gnu.org@gcc.gnu.org>
Received: (qmail 10246 invoked by alias); 8 Aug 2012 10:46:43 -0000
Received: (qmail 10235 invoked by uid 22791); 8 Aug 2012 10:46:42 -0000
X-SWARE-Spam-Status: No, hits=-3.6 required=5.0	tests=ALL_TRUSTED,AWL,BAYES_00
X-Spam-Check-By: sourceware.org
Received: from localhost (HELO gcc.gnu.org) (127.0.0.1)    by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Wed, 08 Aug 2012 10:46:29 +0000
From: "burnus at gcc dot gnu.org" <gcc-bugzilla@gcc.gnu.org>
To: gcc-bugs@gcc.gnu.org
Subject: [Bug fortran/54199] New: Superfluous diagnostic "is also the name of an intrinsic" for internal procedures
Date: Wed, 08 Aug 2012 10:46:00 -0000
X-Bugzilla-Reason: CC
X-Bugzilla-Type: new
X-Bugzilla-Watch-Reason: None
X-Bugzilla-Product: gcc
X-Bugzilla-Component: fortran
X-Bugzilla-Keywords: diagnostic
X-Bugzilla-Severity: normal
X-Bugzilla-Who: burnus at gcc dot gnu.org
X-Bugzilla-Status: UNCONFIRMED
X-Bugzilla-Priority: P3
X-Bugzilla-Assigned-To: unassigned at gcc dot gnu.org
X-Bugzilla-Target-Milestone: ---
X-Bugzilla-Changed-Fields:
Message-ID: <bug-54199-4@http.gcc.gnu.org/bugzilla/>
X-Bugzilla-URL: http://gcc.gnu.org/bugzilla/
Auto-Submitted: auto-generated
Content-Type: text/plain; charset="UTF-8"
MIME-Version: 1.0
Mailing-List: contact gcc-bugs-help@gcc.gnu.org; run by ezmlm
Precedence: bulk
List-Id: <gcc-bugs.gcc.gnu.org>
List-Archive: <http://gcc.gnu.org/ml/gcc-bugs/>
List-Post: <mailto:gcc-bugs@gcc.gnu.org>
List-Help: <mailto:gcc-bugs-help@gcc.gnu.org>
Sender: gcc-bugs-owner@gcc.gnu.org
X-SW-Source: 2012-08/txt/msg00428.txt.bz2

http://gcc.gnu.org/bugzilla/show_bug.cgi?id=54199

             Bug #: 54199
           Summary: Superfluous diagnostic "is also the name of an
                    intrinsic" for internal procedures
    Classification: Unclassified
           Product: gcc
           Version: 4.8.0
            Status: UNCONFIRMED
          Keywords: diagnostic
          Severity: normal
          Priority: P3
         Component: fortran
        AssignedTo: unassigned@gcc.gnu.org
        ReportedBy: burnus@gcc.gnu.org


Compiling the following program with -Wall gives the message:

  function fraction(x)
  1
Warning: 'fraction' declared at (1) is also the name of an intrinsic.  It can
only be called via an explicit interface or if declared EXTERNAL.

I believe this message should not be printed for internal procedures.

(For module procedures, there is a different warning, which can stay:
"'fraction' declared at (1) may shadow the intrinsic of the same name.  In
order to call the intrinsic, explicit INTRINSIC declarations may be required.")


subroutine test()
contains
  function fraction(x)
    real :: x
  end function fraction
end subroutine test


Untested patch:

--- a/gcc/fortran/intrinsic.c
+++ b/gcc/fortran/intrinsic.c
@@ -4510,3 +4518,3 @@ gfc_warn_intrinsic_shadow (const gfc_symbol* sym, bool
in_module, bool func)
                 sym->name, &sym->declared_at);
-  else
+  else if (!sym->ns->proc_name)
     gfc_warning ("'%s' declared at %L is also the name of an intrinsic.  It
can"