[Bug middle-end/54211] New: [4.8 Regression] ICE: verify_gimple failed building freetype with -Os

[Bug middle-end/54211] New: [4.8 Regression] ICE: verify_gimple failed building freetype with -Os

[rmansfield at qnx dot com]

http://gcc.gnu.org/bugzilla/show_bug.cgi?id=54211

             Bug #: 54211
           Summary: [4.8 Regression] ICE: verify_gimple failed building
                    freetype with -Os
    Classification: Unclassified
           Product: gcc
           Version: 4.8.0
            Status: UNCONFIRMED
          Severity: normal
          Priority: P3
         Component: middle-end
        AssignedTo: unassigned@gcc.gnu.org
        ReportedBy: rmansfield@qnx.com
                CC: wschmidt@linux.vnet.ibm.com
              Host: x86_64-unknown-linux-gnu
            Target: x86_64-unknown-linux-gnu
             Build: x86_64-unknown-linux-gnu


Created attachment 27966
  --> http://gcc.gnu.org/bugzilla/attachment.cgi?id=27966
preprocessed src

After rev190220, freetype fails to build with -Os.  Seen on mips, ppc x86 and
x86_64.

Reduced testcase:

/home/ryan/ice.i: In function ‘tt_face_load_sbit_image’:
/home/ryan/ice.i:365:1: error: type mismatch in pointer plus expression
 tt_face_load_sbit_image (TT_Face face, FT_ULong strike_index,
 ^
sizetype

unsigned long

sizetype

D.2244_30 = D.2241_17 + slsr.98_48;

/home/ryan/ice.i:365:1: internal compiler error: verify_gimple failed
Please submit a full bug report,
with preprocessed source if appropriate.
See <http://gcc.gnu.org/bugs.html> for instructions.

[Bug middle-end/54211] [4.8 Regression] ICE: verify_gimple failed building freetype with -Os

[markus at trippelsdorf dot de]

http://gcc.gnu.org/bugzilla/show_bug.cgi?id=54211

Markus Trippelsdorf <markus at trippelsdorf dot de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |markus at trippelsdorf dot
                   |                            |de

--- Comment #1 from Markus Trippelsdorf <markus at trippelsdorf dot de> 2012-08-09 17:38:46 UTC ---
Further reduced:

int a, b;
unsigned char e;
void fn1 ()
{
    unsigned char *c=0;
    for (;; a++)
    {
        unsigned char d = *(c + b);
        for (; &e<&d; c++)
            goto Found_Top;
    }
Found_Top:
    if (0)
        goto Empty_Bitmap;
    for (;; a++)
    {
        unsigned char *e = c + b;
        for (; c < e; c++)
            goto Found_Bottom;
        c -= b;
    }
Found_Bottom:
Empty_Bitmap:
    ;
}

[Bug middle-end/54211] [4.8 Regression] ICE: verify_gimple failed building freetype with -Os

[wschmidt at gcc dot gnu.org]

http://gcc.gnu.org/bugzilla/show_bug.cgi?id=54211

William J. Schmidt <wschmidt at gcc dot gnu.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|UNCONFIRMED                 |ASSIGNED
   Last reconfirmed|                            |2012-08-09
                 CC|                            |wschmidt at gcc dot gnu.org
         AssignedTo|unassigned at gcc dot       |wschmidt at gcc dot gnu.org
                   |gnu.org                     |
   Target Milestone|---                         |4.8.0
     Ever Confirmed|0                           |1

--- Comment #2 from William J. Schmidt <wschmidt at gcc dot gnu.org> 2012-08-09 20:33:16 UTC ---
Confirmed.  I'll have a look.  For some reason a necessary cast is not being
introduced here.

[Bug middle-end/54211] [4.8 Regression] ICE: verify_gimple failed building freetype with -Os

[wschmidt at gcc dot gnu.org]

http://gcc.gnu.org/bugzilla/show_bug.cgi?id=54211

--- Comment #3 from William J. Schmidt <wschmidt at gcc dot gnu.org> 2012-08-09 21:06:22 UTC ---
Ah, actually we're generating a POINTER_PLUS_EXPR when a PLUS_EXPR is called
for.  I see what's going on, shouldn't be hard to fix.

[Bug middle-end/54211] [4.8 Regression] ICE: verify_gimple failed building freetype with -Os

[wschmidt at gcc dot gnu.org]

http://gcc.gnu.org/bugzilla/show_bug.cgi?id=54211

--- Comment #4 from William J. Schmidt <wschmidt at gcc dot gnu.org> 2012-08-10 01:14:41 UTC ---
The following patch is tested and awaiting approval:

Index: gcc/gimple-ssa-strength-reduction.c
===================================================================
--- gcc/gimple-ssa-strength-reduction.c    (revision 190260)
+++ gcc/gimple-ssa-strength-reduction.c    (working copy)
@@ -2534,7 +2534,7 @@ analyze_candidates_and_replace (void)
       /* Determine whether we'll be generating pointer arithmetic
          when replacing candidates.  */
       address_arithmetic_p = (c->kind == CAND_ADD
-                  && POINTER_TYPE_P (TREE_TYPE (c->base_expr)));
+                  && POINTER_TYPE_P (c->cand_type));

       /* If all candidates have already been replaced under other
          interpretations, nothing remains to be done.  */

[Bug middle-end/54211] [4.8 Regression] ICE: verify_gimple failed building freetype with -Os

[wschmidt at gcc dot gnu.org]

http://gcc.gnu.org/bugzilla/show_bug.cgi?id=54211

William J. Schmidt <wschmidt at gcc dot gnu.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |hjl.tools at gmail dot com

--- Comment #5 from William J. Schmidt <wschmidt at gcc dot gnu.org> 2012-08-10 01:16:07 UTC ---
*** Bug 54215 has been marked as a duplicate of this bug. ***

[Bug middle-end/54211] [4.8 Regression] ICE: verify_gimple failed building freetype with -Os

[wschmidt at gcc dot gnu.org]

http://gcc.gnu.org/bugzilla/show_bug.cgi?id=54211

--- Comment #6 from William J. Schmidt <wschmidt at gcc dot gnu.org> 2012-08-10 12:16:11 UTC ---
Author: wschmidt
Date: Fri Aug 10 12:16:04 2012
New Revision: 190294

URL: http://gcc.gnu.org/viewcvs?root=gcc&view=rev&rev=190294
Log:
gcc:

2012-08-10  Bill Schmidt  <wschmidt@linux.vnet.ibm.com>

    PR middle-end/54211
    * gimple-ssa-strength-reduction.c (analyze_candidates_and_replace):
    Use cand_type to determine whether pointer arithmetic will be generated.

gcc/testsuite:

2012-08-10  Bill Schmidt  <wschmidt@linux.vnet.ibm.com>

    PR middle-end/54211
    * gcc.dg/tree-ssa/pr54211.c: New test.


Added:
    trunk/gcc/testsuite/gcc.dg/tree-ssa/pr54211.c
Modified:
    trunk/gcc/ChangeLog
    trunk/gcc/gimple-ssa-strength-reduction.c
    trunk/gcc/testsuite/ChangeLog

[Bug middle-end/54211] [4.8 Regression] ICE: verify_gimple failed building freetype with -Os

[wschmidt at gcc dot gnu.org]

http://gcc.gnu.org/bugzilla/show_bug.cgi?id=54211

William J. Schmidt <wschmidt at gcc dot gnu.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|ASSIGNED                    |RESOLVED
         Resolution|                            |FIXED

--- Comment #6 from William J. Schmidt <wschmidt at gcc dot gnu.org> 2012-08-10 12:16:11 UTC ---
Author: wschmidt
Date: Fri Aug 10 12:16:04 2012
New Revision: 190294

URL: http://gcc.gnu.org/viewcvs?root=gcc&view=rev&rev=190294
Log:
gcc:

2012-08-10  Bill Schmidt  <wschmidt@linux.vnet.ibm.com>

    PR middle-end/54211
    * gimple-ssa-strength-reduction.c (analyze_candidates_and_replace):
    Use cand_type to determine whether pointer arithmetic will be generated.

gcc/testsuite:

2012-08-10  Bill Schmidt  <wschmidt@linux.vnet.ibm.com>

    PR middle-end/54211
    * gcc.dg/tree-ssa/pr54211.c: New test.


Added:
    trunk/gcc/testsuite/gcc.dg/tree-ssa/pr54211.c
Modified:
    trunk/gcc/ChangeLog
    trunk/gcc/gimple-ssa-strength-reduction.c
    trunk/gcc/testsuite/ChangeLog

--- Comment #7 from William J. Schmidt <wschmidt at gcc dot gnu.org> 2012-08-10 12:16:55 UTC ---
Fixed.

[Bug middle-end/54211] [4.8 Regression] ICE: verify_gimple failed building freetype with -Os

[wschmidt at gcc dot gnu.org]

http://gcc.gnu.org/bugzilla/show_bug.cgi?id=54211

William J. Schmidt <wschmidt at gcc dot gnu.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|ASSIGNED                    |RESOLVED
         Resolution|                            |FIXED

--- Comment #7 from William J. Schmidt <wschmidt at gcc dot gnu.org> 2012-08-10 12:16:55 UTC ---
Fixed.