[Bug target/54222] New: [avr] Implement fixed-point support

[Bug target/54222] New: [avr] Implement fixed-point support

[gjl at gcc dot gnu.org]

http://gcc.gnu.org/bugzilla/show_bug.cgi?id=54222

             Bug #: 54222
           Summary: [avr] Implement fixed-point support
    Classification: Unclassified
           Product: gcc
           Version: 4.8.0
            Status: UNCONFIRMED
          Severity: enhancement
          Priority: P3
         Component: target
        AssignedTo: gjl@gcc.gnu.org
        ReportedBy: gjl@gcc.gnu.org
                CC: eric.weddington@atmel.com
            Target: avr


There is a draft patch from Sean, see

http://lists.gnu.org/archive/html/avr-gcc-list/2012-07/msg00030.html

[Bug target/54222] [avr] Implement fixed-point support

[gjl at gcc dot gnu.org]

http://gcc.gnu.org/bugzilla/show_bug.cgi?id=54222

Georg-Johann Lay <gjl at gcc dot gnu.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Priority|P3                          |P5
             Status|UNCONFIRMED                 |ASSIGNED
   Last reconfirmed|                            |2012-08-10
                 CC|                            |geckosenator at gmail dot
                   |                            |com
   Target Milestone|---                         |4.8.0
     Ever Confirmed|0                           |1

[Bug target/54222] [avr] Implement fixed-point support

[gjl at gcc dot gnu.org]

http://gcc.gnu.org/bugzilla/show_bug.cgi?id=54222

--- Comment #1 from Georg-Johann Lay <gjl at gcc dot gnu.org> 2012-08-10 14:24:24 UTC ---
Created attachment 27984
  --> http://gcc.gnu.org/bugzilla/attachment.cgi?id=27984
Tentative patch against 4.8

libgcc/
    * config/avr/lib1funcs-fixed.S: New file.
    * config/avr/lib1funcs.S: Include it.  Undefine some divmodsi
    after they are used.
    (neg2, neg4): New macros.
    * config/avr/avr-lib.h (TA, UTA): Adjust according to gcc's
    avr-modes.def.
    * config/avr/t-avr (LIB1ASMFUNCS): Add: _fractqqsf, _fractuqqsf,
    _fracthqsf, _fractuhqsf, _fracthasf, _fractuhasf, _fractsasf,
    _fractusasf, _fractsfqq, _fractsfuqq, _fractsfhq, _fractsfuhq,
    _fractsfha, _fractsfsa, _mulqq3, _muluqq3, _mulhq3, _muluhq3,
    _mulha3, _muluha3, _mulsa3, _mulusa3, _divqq3, _udivuqq3, _divhq3,
    _udivuhq3, _divha3, _udivuha3, _divsa3, _udivusa3.

gcc/
    * config/avr/predicates.md (const0_operand): Allow const_fixed.
    (const_operand, const_or_immediate_operand): New.
    (nonmemory_or_const_operand): New.
    * config/avr/constraints.md (Ynn, Y00, Y01, Y02, Ym1, Ym2, YIJ):
    New constraints.

    * avr/avr-fixed.md: New file.
    * avr/avr.md: Include it.
    (cc): Add: minus.
    (adjust_len): Add: minus, minus64, ufract, sfract.
    (ALLQ, ALLH, ALLS, ALLQS, ORDERED234): New mode iterators.
    (MOVMODE): Add: QQ, UQQ, HQ, UHQ, HA, UHA, SQ, USQ, SA, USA.
    (MPUSH): Add: HQ, UHQ, HA, UHA, SQ, USQ, SA, USA.
    (pushqi1, xload8_A, xload_8, movqi_insn, *reload_inqi, addqi3,
    subqi3, ashlqi3, *ashlqi3, ashrqi3, lshrqi3, *lshrqi3, *cmpqi, 
    cbranchqi4, *cpse.eq): Generalize to handle all 8-bit modes in ALLQ.
    (*movhi, reload_inhi, addhi3, *addhi3, addhi3_clobber, subhi3,
    ashlhi3, *ashlhi3_const, ashrhi3, *ashirhi3_const, lshrhi3,
    *lshrhi3_const, *cmphi, cbranchhi4): Generalize to handle all
    16-bit modes in ALLH.
    (subhi3, casesi, strlenhi): Add clobber when expanding minus:HI.
    (*movsi, *reload_insi, addsi3, subsi3, ashlsi3, *ashlsi3_const,
    ashrsi3, *ashrhi3_const, *ashrsi3_const, lshrsi3, *lshrsi3_const,
    *reversed_tstsi, *cmpsi, cbranchsi4): Generalize to handle all
    32-bit modes in ALLS.
    * avr-dimode.md (ALLD): New mode iterator.
    (adddi3, adddi3_insn, adddi3_const_insn, subdi3, subdi3_insn,
    subdi3_const_insn, cbranchdi4, compare_di2,
    compare_const_di2, ashrdi3, lshrdi3, rotldi3, ashldi3_insn,
    ashrdi3_insn, lshrdi3_insn, rotldi3_insn): Generalize to handle
    all 64-bit modes in ALLD.
    * avr-modes.def (HA, SA, DA, TA, UTA): Adjust modes.

    * config/avr/avr-protos.h (avr_to_int_mode): New prototype.
    (avr_out_fract, avr_out_minus, avr_out_minus64): New prototypes.
    * config/avr/avr.c (TARGET_FIXED_POINT_SUPPORTED_P): Return true.
    (avr_scalar_mode_supported_p): Allow if ALL_FIXED_POINT_MODE_P.
    (avr_builtin_setjmp_frame_value): Use gen_subhi3 and return new
    pseudo instead of gen_rtx_MINUS.
    (avr_print_operand, avr_operand_rtx_cost): Handle: CONST_FIXED.
    (notice_update_cc): Handle: CC_MINUS.
    (output_movqi): Generalize to handle respective fixed-point modes.
    (output_movhi, output_movsisf, avr_2word_insn_p): Ditto.
    (avr_out_compare, avr_out_plus_1): Also handle fixed-point modes.
    (avr_assemble_integer): Ditto.
    (output_reload_in_const, output_reload_insisf): Ditto.
    (avr_out_fract, avr_out_minus, avr_out_minus64): New functions.
    (avr_out_plus64): Probe if PLUS or MINUS is shorter.
    (avr_to_int_mode): New function.
    (adjust_insn_length): Handle: ADJUST_LEN_SFRACT,
    ADJUST_LEN_UFRACT, ADJUST_LEN_MINUS, ADJUST_LEN_MINUS64.

[Bug target/54222] [avr] Implement fixed-point support

[gjl at gcc dot gnu.org]

http://gcc.gnu.org/bugzilla/show_bug.cgi?id=54222

Georg-Johann Lay <gjl at gcc dot gnu.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #27984|0                           |1
        is obsolete|                            |

--- Comment #2 from Georg-Johann Lay <gjl at gcc dot gnu.org> 2012-08-11 10:21:08 UTC ---
Created attachment 27988
  --> http://gcc.gnu.org/bugzilla/attachment.cgi?id=27988
Tentative patch against 4.8

Discussed here:

http://gcc.gnu.org/ml/gcc-patches/2012-08/msg00632.html

[Bug target/54222] [avr] Implement fixed-point support

[gjl at gcc dot gnu.org]

http://gcc.gnu.org/bugzilla/show_bug.cgi?id=54222

Georg-Johann Lay <gjl at gcc dot gnu.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Keywords|                            |patch

--- Comment #3 from Georg-Johann Lay <gjl at gcc dot gnu.org> 2012-08-11 10:26:19 UTC ---
...and here is the respective ChangeLogs for attachment 27988 from comment #2:

libgcc/
    PR target/54222
    * config/avr/lib1funcs-fixed.S: New file.
    * config/avr/lib1funcs.S: Include it.  Undefine some divmodsi
    after they are used.
    (neg2, neg4): New macros.
    * config/avr/avr-lib.h (TA, UTA): Adjust according to gcc's
    avr-modes.def.
    * config/avr/t-avr (LIB1ASMFUNCS): Add: _fractqqsf, _fractuqqsf,
    _fracthqsf, _fractuhqsf, _fracthasf, _fractuhasf, _fractsasf,
    _fractusasf, _fractsfqq, _fractsfuqq, _fractsfhq, _fractsfuhq,
    _fractsfha, _fractsfsa, _mulqq3, _muluqq3, _mulhq3, _muluhq3,
    _mulha3, _muluha3, _mulsa3, _mulusa3, _divqq3, _udivuqq3, _divhq3,
    _udivuhq3, _divha3, _udivuha3, _divsa3, _udivusa3.

gcc/
    PR target/54222
    * avr-modes.def (HA, SA, DA, TA, UTA): Adjust modes.
    * avr/avr-fixed.md: New file.
    * avr/avr.md: Include it.
    (cc): Add: minus.
    (adjust_len): Add: minus, minus64, ufract, sfract.
    (ALL1, ALL2, ALL4, ORDERED234): New mode iterators.
    (MOVMODE): Add: QQ, UQQ, HQ, UHQ, HA, UHA, SQ, USQ, SA, USA.
    (MPUSH): Add: HQ, UHQ, HA, UHA, SQ, USQ, SA, USA.
    (pushqi1, xload8_A, xload_8, movqi_insn, *reload_inqi, addqi3,
    subqi3, ashlqi3, *ashlqi3, ashrqi3, lshrqi3, *lshrqi3, *cmpqi,
    cbranchqi4, *cpse.eq): Generalize to handle all 8-bit modes in ALL1.
    (*movhi, reload_inhi, addhi3, *addhi3, addhi3_clobber, subhi3,
    ashlhi3, *ashlhi3_const, ashrhi3, *ashirhi3_const, lshrhi3,
    *lshrhi3_const, *cmphi, cbranchhi4): Generalize to handle all
    16-bit modes in ALL2.
    (subhi3, casesi, strlenhi): Add clobber when expanding minus:HI.
    (*movsi, *reload_insi, addsi3, subsi3, ashlsi3, *ashlsi3_const,
    ashrsi3, *ashrhi3_const, *ashrsi3_const, lshrsi3, *lshrsi3_const,
    *reversed_tstsi, *cmpsi, cbranchsi4): Generalize to handle all
    32-bit modes in ALL4.
    * avr-dimode.md (ALL8): New mode iterator.
    (adddi3, adddi3_insn, adddi3_const_insn, subdi3, subdi3_insn,
    subdi3_const_insn, cbranchdi4, compare_di2,
    compare_const_di2, ashrdi3, lshrdi3, rotldi3, ashldi3_insn,
    ashrdi3_insn, lshrdi3_insn, rotldi3_insn): Generalize to handle
    all 64-bit modes in ALL8.
    * config/avr/avr-protos.h (avr_to_int_mode): New prototype.
    (avr_out_fract, avr_out_minus, avr_out_minus64): New prototypes.
    * config/avr/avr.c (TARGET_FIXED_POINT_SUPPORTED_P): Return true.
    (avr_scalar_mode_supported_p): Allow if ALL_FIXED_POINT_MODE_P.
    (avr_builtin_setjmp_frame_value): Use gen_subhi3 and return new
    pseudo instead of gen_rtx_MINUS.
    (avr_print_operand, avr_operand_rtx_cost): Handle: CONST_FIXED.
    (notice_update_cc): Handle: CC_MINUS.
    (output_movqi): Generalize to handle respective fixed-point modes.
    (output_movhi, output_movsisf, avr_2word_insn_p): Ditto.
    (avr_out_compare, avr_out_plus_1): Also handle fixed-point modes.
    (avr_assemble_integer): Ditto.
    (output_reload_in_const, output_reload_insisf): Ditto.
    (avr_out_fract, avr_out_minus, avr_out_minus64): New functions.
    (avr_to_int_mode): New function.
    (adjust_insn_length): Handle: ADJUST_LEN_SFRACT,
    ADJUST_LEN_UFRACT, ADJUST_LEN_MINUS, ADJUST_LEN_MINUS64.
    * config/avr/predicates.md (const0_operand): Allow const_fixed.
    (const_operand, const_or_immediate_operand): New.
    (nonmemory_or_const_operand): New.
    * config/avr/constraints.md (Ynn, Y00, Y01, Y02, Ym1, Ym2, YIJ):
    New constraints.

[Bug target/54222] [avr] Implement fixed-point support

[gjl at gcc dot gnu.org]

http://gcc.gnu.org/bugzilla/show_bug.cgi?id=54222

--- Comment #4 from Georg-Johann Lay <gjl at gcc dot gnu.org> 2012-08-24 12:42:53 UTC ---
Author: gjl
Date: Fri Aug 24 12:42:48 2012
New Revision: 190644

URL: http://gcc.gnu.org/viewcvs?root=gcc&view=rev&rev=190644
Log:
libgcc/
    PR target/54222
    * config/avr/lib1funcs-fixed.S: New file.
    * config/avr/lib1funcs.S: Include it.  Undefine some divmodsi
    after they are used.
    (neg2, neg4): New macros.
    (__mulqihi3,__umulqihi3,__mulhi3): Rewrite non-MUL variants.
    (__mulhisi3,__umulhisi3,__mulsi3): Rewrite non-MUL variants.
    (__umulhisi3): Speed up MUL variant if there is enough flash.
    * config/avr/avr-lib.h (TA, UTA): Adjust according to gcc's
    avr-modes.def.
    * config/avr/t-avr (LIB1ASMFUNCS): Add: _fractqqsf, _fractuqqsf,
    _fracthqsf, _fractuhqsf, _fracthasf, _fractuhasf, _fractsasf,
    _fractusasf, _fractsfqq, _fractsfuqq, _fractsfhq, _fractsfuhq,
    _fractsfha, _fractsfsa, _mulqq3, _muluqq3, _mulhq3, _muluhq3,
    _mulha3, _muluha3, _mulsa3, _mulusa3, _divqq3, _udivuqq3, _divhq3,
    _udivuhq3, _divha3, _udivuha3, _divsa3, _udivusa3.
    (LIB2FUNCS_EXCLUDE): Add supported functions.

gcc/
    PR target/54222
    * avr-modes.def (HA, SA, DA, TA, UTA): Adjust modes.
    * avr/avr-fixed.md: New file.
    * avr/avr.md: Include it.
    (cc): Add: minus.
    (adjust_len): Add: minus, minus64, ufract, sfract.
    (ALL1, ALL2, ALL4, ORDERED234): New mode iterators.
    (MOVMODE): Add: QQ, UQQ, HQ, UHQ, HA, UHA, SQ, USQ, SA, USA.
    (MPUSH): Add: HQ, UHQ, HA, UHA, SQ, USQ, SA, USA.
    (pushqi1, xload8_A, xload_8, movqi_insn, *reload_inqi, addqi3,
    subqi3, ashlqi3, *ashlqi3, ashrqi3, lshrqi3, *lshrqi3, *cmpqi, 
    cbranchqi4, *cpse.eq): Generalize to handle all 8-bit modes in ALL1.
    (*movhi, reload_inhi, addhi3, *addhi3, addhi3_clobber, subhi3,
    ashlhi3, *ashlhi3_const, ashrhi3, *ashirhi3_const, lshrhi3,
    *lshrhi3_const, *cmphi, cbranchhi4): Generalize to handle all
    16-bit modes in ALL2.
    (subhi3, casesi, strlenhi): Add clobber when expanding minus:HI.
    (*movsi, *reload_insi, addsi3, subsi3, ashlsi3, *ashlsi3_const,
    ashrsi3, *ashrhi3_const, *ashrsi3_const, lshrsi3, *lshrsi3_const,
    *reversed_tstsi, *cmpsi, cbranchsi4): Generalize to handle all
    32-bit modes in ALL4.
    * avr-dimode.md (ALL8): New mode iterator.
    (adddi3, adddi3_insn, adddi3_const_insn, subdi3, subdi3_insn,
    subdi3_const_insn, cbranchdi4, compare_di2,
    compare_const_di2, ashrdi3, lshrdi3, rotldi3, ashldi3_insn,
    ashrdi3_insn, lshrdi3_insn, rotldi3_insn): Generalize to handle
    all 64-bit modes in ALL8.
    * config/avr/avr-protos.h (avr_to_int_mode): New prototype.
    (avr_out_fract, avr_out_minus, avr_out_minus64): New prototypes.
    * config/avr/avr.c (TARGET_FIXED_POINT_SUPPORTED_P): Define to...
    (avr_fixed_point_supported_p): ...this new static function.
    (TARGET_BUILD_BUILTIN_VA_LIST): Define to...
    (avr_build_builtin_va_list): ...this new static function.
    (avr_adjust_type_node): New static function.
    (avr_scalar_mode_supported_p): Allow if ALL_FIXED_POINT_MODE_P.
    (avr_builtin_setjmp_frame_value): Use gen_subhi3 and return new
    pseudo instead of gen_rtx_MINUS.
    (avr_print_operand, avr_operand_rtx_cost): Handle: CONST_FIXED.
    (notice_update_cc): Handle: CC_MINUS.
    (output_movqi): Generalize to handle respective fixed-point modes.
    (output_movhi, output_movsisf, avr_2word_insn_p): Ditto.
    (avr_out_compare, avr_out_plus_1): Also handle fixed-point modes.
    (avr_assemble_integer): Ditto.
    (output_reload_in_const, output_reload_insisf): Ditto.
    (avr_compare_pattern): Skip all modes > 4 bytes.
    (avr_2word_insn_p): Skip movuqq_insn, movqq_insn.
    (avr_out_fract, avr_out_minus, avr_out_minus64): New functions.
    (avr_to_int_mode): New function.
    (adjust_insn_length): Handle: ADJUST_LEN_SFRACT,
    ADJUST_LEN_UFRACT, ADJUST_LEN_MINUS, ADJUST_LEN_MINUS64.
    * config/avr/predicates.md (const0_operand): Allow const_fixed.
    (const_operand, const_or_immediate_operand): New.
    (nonmemory_or_const_operand): New.
    * config/avr/constraints.md (Ynn, Y00, Y01, Y02, Ym1, Ym2, YIJ):
    New constraints.
    * config/avr/avr.h (LONG_LONG_ACCUM_TYPE_SIZE): Define.


Added:
    trunk/gcc/config/avr/avr-fixed.md
    trunk/libgcc/config/avr/lib1funcs-fixed.S
Modified:
    trunk/gcc/ChangeLog
    trunk/gcc/config/avr/avr-dimode.md
    trunk/gcc/config/avr/avr-modes.def
    trunk/gcc/config/avr/avr-protos.h
    trunk/gcc/config/avr/avr.c
    trunk/gcc/config/avr/avr.h
    trunk/gcc/config/avr/avr.md
    trunk/gcc/config/avr/constraints.md
    trunk/gcc/config/avr/predicates.md
    trunk/libgcc/ChangeLog
    trunk/libgcc/config/avr/avr-lib.h
    trunk/libgcc/config/avr/lib1funcs.S
    trunk/libgcc/config/avr/t-avr

[Bug target/54222] [avr] Implement fixed-point support

[gjl at gcc dot gnu.org]

http://gcc.gnu.org/bugzilla/show_bug.cgi?id=54222

--- Comment #5 from Georg-Johann Lay <gjl at gcc dot gnu.org> 2012-08-24 13:01:58 UTC ---
Author: gjl
Date: Fri Aug 24 13:01:54 2012
New Revision: 190646

URL: http://gcc.gnu.org/viewcvs?root=gcc&view=rev&rev=190646
Log:
    PR target/54222
    * config/avr/t-avr (conv_X): Rename to func_X.


Modified:
    trunk/libgcc/ChangeLog
    trunk/libgcc/config/avr/t-avr

[Bug target/54222] [avr] Implement fixed-point support

[gjl at gcc dot gnu.org]

http://gcc.gnu.org/bugzilla/show_bug.cgi?id=54222

--- Comment #6 from Georg-Johann Lay <gjl at gcc dot gnu.org> 2012-09-15 15:52:35 UTC ---
Author: gjl
Date: Sat Sep 15 15:52:28 2012
New Revision: 191345

URL: http://gcc.gnu.org/viewcvs?root=gcc&view=rev&rev=191345
Log:
gcc/
    PR target/54222
    * config/avr/avr-fixed.md (ALL2S, ALL4S, ALL24S, ALL124S,
    ALL124U): New mode iterators.
    (<code_stdname><mode>3): New insns for SS_PLUS, SS_MINUS.
    (<code_stdname><mode>3): New insns for US_PLUS, US_MINUS.
    (usneg<mode>2): New insns.
    (<code_stdname><mode>2): New expanders for SS_NEG, SS_ABS.
    (*<code_stdname><mode>2): New insns for SS_NEG, SS_ABS.
    * config/avr/avr-dimode.md (ALL8U, ALL8S): New mode iterators.
    (avr_out_plus64, avr_out_minus64): Use avr_out_plus instead.
    (<code_stdname><mode>3): New expanders for SS_PLUS, SS_MINUS.
    (<code_stdname><mode>3): New expanders for US_PLUS, US_MINUS.
    (<code_stdname><mode>3_insn): New insns.
    (<code_stdname><mode>3_const_insn): New insns.
    * config/avr/avr.md (cc): Add: plus. Remove: out_plus,
    out_plus_noclobber, minus.
    (length): Add: plus.  Remove: out_plus, out_plus_noclobber,
    plus64, minus, minus64.
    (abelian): New code_attr.
    (code_stdname): Handle: ss_plus, ss_minus, ss_neg, ss_abs,
    us_plus, us_minus, us_neg.
    (*add<mode>3, add<mode>3_clobber, add<mode>3, addpsi3, sub<mode>3):
    Use avr_out_plus to output.
    * config/avr/avr-protos.h (avr_out_plus): Change prototype.
    (avr_out_plus_noclobber, avr_out_minus): Remove.
    (avr_out_plus64, avr_out_minus64): Remove.
    * config/avr/avr.c (avr_out_plus_1): Add new default arguments
    code_sat, sign.  Saturate after operation if code_sat != UNKNOWN.
    (avr_out_plus_symbol): New static function.
    (avr_out_plus): Rewrite.
    (adjust_insn_length): Handle: ADJUST_LEN_PLUS.  Remove handling
    of: ADJUST_LEN_OUT_PLUS, ADJUST_LEN_PLUS64, ADJUST_LEN_MINUS, 
    ADJUST_LEN_MINUS64, ADJUST_LEN_OUT_PLUS_NOCLOBBER.
    (notice_update_cc): Handle: CC_PLUS.  Remove handling of: CC_MINUS,
    CC_OUT_PLUS, CC_OUT_PLUS_NOCLOBBER
    (avr_out_plus_noclobber, avr_out_minus): Remove.
    (avr_out_plus64, avr_out_minus64): Remove.
    (avr_print_operand): Print raw REGNO if 'r' is used with REG.

libgcc/
    PR target/54222
    * config/avr/lib1funcs-fixed.S (__ssneg_2, __ssabs_2, __ssneg_4,
    __ssabs_4, __clr_8, __ssneg_8, __ssabs_8,
    __usadd_8, __ussub_8, __ssadd_8, __sssub_8): New functions.
    (__divsa3): Use __negsi2 to negate r_quoL.
    * config/avr/lib1funcs.S (FALIAS): New macro.
    (__divmodsi4): Break out and use __divmodsi4_neg1 as...
    (__negsi2): ...this new function.
    * config/avr/t-avr (LIB1ASMFUNCS): Add _negsi2, _clr_8,
    _ssneg_2, _ssneg_4, _ssneg_8, _ssabs_2, _ssabs_4,
    _ssabs_8, _ssadd_8, _sssub_8, _usadd_8, _ussub_8.
    (LIB2FUNCS_EXCLUDE): Fix typo for _add _sub.
    Add: _ssadd*, _sssub*, _ssneg*, _ssabs* for signed fixed modes.
    Add: _usadd*, _ussub*, _usneg* for unsigned fixed modes.

gcc/testsuite/
    PR target/54222
    * gcc.target/avr/torture/fix-types.h: New.
    * gcc.target/avr/torture/vals-hr.def: New.
    * gcc.target/avr/torture/vals-r.def: New.
    * gcc.target/avr/torture/vals-k.def: New.
    * gcc.target/avr/torture/vals-ur.def: New.
    * gcc.target/avr/torture/vals-uk.def: New.
    * gcc.target/avr/torture/vals-uhr.def: New.
    * gcc.target/avr/torture/vals-llk.def: New.
    * gcc.target/avr/torture/vals-ullk.def: New.
    * gcc.target/avr/torture/sat-hr-plus-minus.c: New.
    * gcc.target/avr/torture/sat-r-plus-minus.c: New.
    * gcc.target/avr/torture/sat-k-plus-minus.c: New.
    * gcc.target/avr/torture/sat-ur-plus-minus.c: New.
    * gcc.target/avr/torture/sat-uk-plus-minus.c: New.
    * gcc.target/avr/torture/sat-uhr-plus-minus.c: New.
    * gcc.target/avr/torture/sat-llk-plus-minus.c: New.
    * gcc.target/avr/torture/sat-ullk-plus-minus.c: New.


Added:
    trunk/gcc/testsuite/gcc.target/avr/torture/fix-types.h
    trunk/gcc/testsuite/gcc.target/avr/torture/sat-hr-plus-minus.c
    trunk/gcc/testsuite/gcc.target/avr/torture/sat-k-plus-minus.c
    trunk/gcc/testsuite/gcc.target/avr/torture/sat-llk-plus-minus.c
    trunk/gcc/testsuite/gcc.target/avr/torture/sat-r-plus-minus.c
    trunk/gcc/testsuite/gcc.target/avr/torture/sat-uhr-plus-minus.c
    trunk/gcc/testsuite/gcc.target/avr/torture/sat-uk-plus-minus.c
    trunk/gcc/testsuite/gcc.target/avr/torture/sat-ullk-plus-minus.c
    trunk/gcc/testsuite/gcc.target/avr/torture/sat-ur-plus-minus.c
    trunk/gcc/testsuite/gcc.target/avr/torture/vals-hr.def
    trunk/gcc/testsuite/gcc.target/avr/torture/vals-k.def
    trunk/gcc/testsuite/gcc.target/avr/torture/vals-llk.def
    trunk/gcc/testsuite/gcc.target/avr/torture/vals-r.def
    trunk/gcc/testsuite/gcc.target/avr/torture/vals-uhr.def
    trunk/gcc/testsuite/gcc.target/avr/torture/vals-uk.def
    trunk/gcc/testsuite/gcc.target/avr/torture/vals-ullk.def
    trunk/gcc/testsuite/gcc.target/avr/torture/vals-ur.def
Modified:
    trunk/gcc/ChangeLog
    trunk/gcc/config/avr/avr-dimode.md
    trunk/gcc/config/avr/avr-fixed.md
    trunk/gcc/config/avr/avr-protos.h
    trunk/gcc/config/avr/avr.c
    trunk/gcc/config/avr/avr.md
    trunk/gcc/testsuite/ChangeLog
    trunk/libgcc/ChangeLog
    trunk/libgcc/config/avr/lib1funcs-fixed.S
    trunk/libgcc/config/avr/lib1funcs.S
    trunk/libgcc/config/avr/t-avr

[Bug target/54222] [avr] Implement fixed-point support

[gjl at gcc dot gnu.org]

http://gcc.gnu.org/bugzilla/show_bug.cgi?id=54222

--- Comment #7 from Georg-Johann Lay <gjl at gcc dot gnu.org> 2012-09-17 07:59:34 UTC ---
Author: gjl
Date: Mon Sep 17 07:59:29 2012
New Revision: 191376

URL: http://gcc.gnu.org/viewcvs?root=gcc&view=rev&rev=191376
Log:
    PR target/54222
    * config/avr/avr.c (avr_out_plus_symbol): Fix typo if PLUS and PSImode.
    (avr_out_plus_1): Remove log comments from assembler output.


Modified:
    trunk/gcc/ChangeLog
    trunk/gcc/config/avr/avr.c

[Bug target/54222] [avr] Implement fixed-point support

[gjl at gcc dot gnu.org]

http://gcc.gnu.org/bugzilla/show_bug.cgi?id=54222

--- Comment #8 from Georg-Johann Lay <gjl at gcc dot gnu.org> 2012-11-22 10:00:24 UTC ---
Author: gjl
Date: Thu Nov 22 10:00:13 2012
New Revision: 193721

URL: http://gcc.gnu.org/viewcvs?root=gcc&view=rev&rev=193721
Log:
libgcc/
    Adjust decimal point of signed accum mode to GCC default.

    PR target/54222
    * config/avr/t-avr (LIB1ASMFUNCS): Add _fractsfsq _fractsfusq,
    _divqq_helper.
    * config/avr/lib1funcs-fixed.S (__fractqqsf, __fracthqsf)
    (__fractsasf, __fractsfha, __fractusqsf, __fractsfsa)
    (__mulha3, __mulsa3)
    (__divqq3, __divha3, __divsa3): Adjust to new position of
    decimal point of signed accum types. 

    (__mulusa3_round): New function.
    (__mulusa3): Use it.
    (__divqq_helper): New function.
    (__udivuqq3): Use it.

gcc/
    Adjust decimal point of signed accum mode to GCC default.

    PR target/54222
    * config/avr/avr-modes.def (HA, SA, DA): Remove mode adjustments.
    (TA): Move decimal point one bit to the right.
    * config/avr/avr.c (avr_out_fract): Rewrite.


Modified:
    trunk/gcc/ChangeLog
    trunk/gcc/config/avr/avr-modes.def
    trunk/gcc/config/avr/avr.c
    trunk/libgcc/ChangeLog
    trunk/libgcc/config/avr/lib1funcs-fixed.S
    trunk/libgcc/config/avr/t-avr

[Bug target/54222] [avr] Implement fixed-point support

[gjl at gcc dot gnu.org]

http://gcc.gnu.org/bugzilla/show_bug.cgi?id=54222

--- Comment #9 from Georg-Johann Lay <gjl at gcc dot gnu.org> 2013-01-23 15:13:56 UTC ---
Author: gjl
Date: Wed Jan 23 15:13:51 2013
New Revision: 195407

URL: http://gcc.gnu.org/viewcvs?root=gcc&view=rev&rev=195407
Log:
    PR target/54222
    * config/avr/stdfix.h: New file.
    * t-avr (stdfix-gcc.h): New rule to build it.
    (EXTRA_HEADERS): Set it to install stdfix.h, stdfix-gcc.h.


Added:
    trunk/gcc/config/avr/stdfix.h
Modified:
    trunk/gcc/ChangeLog
    trunk/gcc/config/avr/t-avr

[Bug target/54222] [avr] Implement fixed-point support

[gjl at gcc dot gnu.org]

http://gcc.gnu.org/bugzilla/show_bug.cgi?id=54222

--- Comment #10 from Georg-Johann Lay <gjl at gcc dot gnu.org> 2013-01-25 09:28:14 UTC ---
Author: gjl
Date: Fri Jan 25 09:28:09 2013
New Revision: 195464

URL: http://gcc.gnu.org/viewcvs?root=gcc&view=rev&rev=195464
Log:
gcc/
    PR target/54222
    * config/avr/builtins.def (DEF_BUILTIN): Add LIBNAME argument.
    Add NULL LIBNAME argument to existing definitions.
    (ABSHR, ABSR, ABSLR, ABSLLR, ABSHK, ABSK, ABSLK, ABSLLK): New.
    * config/avr/avr-c.c (DEF_BUILTIN): Add LIBNAME argument.
    * config/avr/avr.c (DEF_BUILTIN): Same.
    (avr_init_builtins): Pass down LIBNAME to add_builtin_function.
    (avr_expand_builtin): Expand to a vanilla call if a libgcc
    implementation is available (DECL_ASSEMBLER_NAME is set).
    (avr_fold_absfx): New static function.
    (avr_fold_builtin): Use it to handle: AVR_BUILTIN_ABSHR,
    AVR_BUILTIN_ABSR, AVR_BUILTIN_ABSLR, AVR_BUILTIN_ABSLLR,
    AVR_BUILTIN_ABSHK, AVR_BUILTIN_ABSK, AVR_BUILTIN_ABSLK,
    AVR_BUILTIN_ABSLLK.
    * config/avr/stdfix.h (abshr, absr, abslr, absllr)
    (abshk, absk, abslk, absllk): Provide as static inline functions.

gcc/testsuite/
    PR target/54222
    * gcc.target/avr/torture/builtins-3-absfx.c: New test.


Added:
    trunk/gcc/testsuite/gcc.target/avr/torture/builtins-3-absfx.c
Modified:
    trunk/gcc/ChangeLog
    trunk/gcc/config/avr/avr-c.c
    trunk/gcc/config/avr/avr.c
    trunk/gcc/config/avr/builtins.def
    trunk/gcc/config/avr/stdfix.h
    trunk/gcc/testsuite/ChangeLog

[Bug target/54222] [avr] Implement fixed-point support

[gjl at gcc dot gnu.org]

http://gcc.gnu.org/bugzilla/show_bug.cgi?id=54222

--- Comment #11 from Georg-Johann Lay <gjl at gcc dot gnu.org> 2013-01-29 10:33:24 UTC ---
Author: gjl
Date: Tue Jan 29 10:33:18 2013
New Revision: 195532

URL: http://gcc.gnu.org/viewcvs?root=gcc&view=rev&rev=195532
Log:
    PR target/54222
    * config/avr/t-avr (LIB2FUNCS_EXCLUDE): Add:
    _mulQQ,  _mulHQ,  _mulHA,  _mulSA,
    _mulUQQ, _mulUHQ, _mulUHA, _mulUSA,
    _divQQ,  _divHQ,  _divHA,  _divSA,
    _divUQQ, _divUHQ, _divUHA, _divUSA.


Modified:
    trunk/libgcc/ChangeLog
    trunk/libgcc/config/avr/t-avr

[Bug target/54222] [avr] Implement fixed-point support

[gjl at gcc dot gnu.org]

http://gcc.gnu.org/bugzilla/show_bug.cgi?id=54222

--- Comment #12 from Georg-Johann Lay <gjl at gcc dot gnu.org> 2013-02-08 10:13:45 UTC ---
Author: gjl
Date: Fri Feb  8 10:13:37 2013
New Revision: 195878

URL: http://gcc.gnu.org/viewcvs?root=gcc&view=rev&rev=195878
Log:
gcc/
    PR target/54222
    * config/avr/avr.md (unspec) <UNSPEC_ROUND>: Add.
    * config/avr/avr-fixed.md (ALL4QA, ALL124QA): New mode iterators.
    (round<mode>3, round<mode>3_const): New expanders for fixed-mode.
    (*round<mode>3.libgcc): New insns for fixed-modes.
    * config/avr/builtins.def (ABSxx): Use a non-NULL LIBNAME.
    (ROUNDxx, COUNTLSxx, BITSxx, xxBITS): New DEF_BUILTINs.
    (ROUNDFX, COUNTLSFX, ABSFX): New DEF_BUILTINs.
    * config/avr/stdfix.h (absFX, bitsFX, FXbits): Remove inline
    implementations.  Define to __builtin_avr_absFX,
    __builtin_avr_bitsFX, __builtin_avr_FXbits, respectively.
    (roundFX, countlsFX): Define to __builtin_avr_roundFX,
    __builtin_avr_countlsFX, respectively.
    * config/avr/avr-c.c (target.h): Include it.
    (enum avr_builtin_id): New enum.
    (avr_resolve_overloaded_builtin): New static function.
    (avr_register_target_pragmas): Use it to set
    targetm.resolve_overloaded_builtin.
    * config/avr/avr.c (avr_init_builtins): Supply myriads of local
    tree nodes used by DEF_BUILTIN.
    (avr_expand_builtin) <AVR_BUILTIN_ROUNDxx>: Sanity-check them.
    (avr_fold_builtin) <AVR_BUILTIN_BITSxx>: Fold to VIEW_COVERT_EXPR.
    <AVR_BUILTIN_xxBITS>: Same.

libgcc/
    PR target/54222
    * config/avr/lib2funcs.c: New C sources for modules for libgcc.a.
    * config/avr/lib2-object.mk: New iterator to build objects from it.
    * config/avr/t-avr: Iterate lib2-object.mk to build objects from
    lib2funcs.c.
    (LIB2FUNCS_EXCLUDE): Add _clrsbdi2.
    (LIB1ASMFUNCS): Add: _ssabs_1, _mask1, _ret, _roundqq3, _rounduqq3,
    _round_s2, _round_u2, _round_2_const, _addmask_2, _round_s4,
    _round_u4, _round_4_const, _addmask_4, _round_x8, _rounddq3
    _roundudq3, _roundda3 _rounduda3, _roundta3 _rounduta3.
    * config/avr/lib1funcs-fixed.S: Implement them.

gcc/testsuite/
    PR target/54222
    * gcc.target/avr/torture/builtins-4-roundfx.c: New test.
    * gcc.target/avr/torture/builtins-5-countlsfx.c: New test.


Added:
    trunk/gcc/testsuite/gcc.target/avr/torture/builtins-4-roundfx.c
    trunk/gcc/testsuite/gcc.target/avr/torture/builtins-5-countlsfx.c
    trunk/libgcc/config/avr/lib2-object.mk
    trunk/libgcc/config/avr/lib2funcs.c
Modified:
    trunk/gcc/ChangeLog
    trunk/gcc/config/avr/avr-c.c
    trunk/gcc/config/avr/avr-fixed.md
    trunk/gcc/config/avr/avr.c
    trunk/gcc/config/avr/avr.md
    trunk/gcc/config/avr/builtins.def
    trunk/gcc/config/avr/stdfix.h
    trunk/gcc/testsuite/ChangeLog
    trunk/libgcc/ChangeLog
    trunk/libgcc/config/avr/lib1funcs-fixed.S
    trunk/libgcc/config/avr/lib1funcs.S
    trunk/libgcc/config/avr/t-avr

[Bug target/54222] [avr] Implement fixed-point support

[gjl at gcc dot gnu.org]

http://gcc.gnu.org/bugzilla/show_bug.cgi?id=54222

--- Comment #13 from Georg-Johann Lay <gjl at gcc dot gnu.org> 2013-02-12 14:55:22 UTC ---
Author: gjl
Date: Tue Feb 12 14:55:16 2013
New Revision: 195978

URL: http://gcc.gnu.org/viewcvs?root=gcc&view=rev&rev=195978
Log:
gcc/
    PR target/54222
    * config/avr/avr-dimode.md (umulsidi3, mulsidi3): New expanders.
    (umulsidi3_insn, mulsidi3_insn): New insns.

libgcc/
    PR target/54222
    * config/avr/t-avr (LIB2FUNCS_EXCLUDE): Add: _usmulUHA, _usmulUSA,
    _ssmulHA, _ssmulSA.
    (LIB1ASMFUNCS): Add: _muldi3_6, _mulsidi3, _umulsidi3, _usmuluha3,
    _ssmulha3, _usmulusa3, _ssmulsa3.
    * config/avr/lib1funcs.S (__muldi3_6): Break out of __muldi3.
    (__muldi3): XCALL __muldi3_6 instead of rcall.
    (__umulsidi3, __mulsidi3): New functions.
    (do_prologue_saves, do_epilogue_restores): New .macros.
    (__divdi3_moddi3): Use them.
    * config/avr/lib1funcs-fixed.S (__usmuluha3, __ssmulha3)
    (__usmulusa3, __ssmulsa3): New functions.


Modified:
    trunk/gcc/ChangeLog
    trunk/gcc/config/avr/avr-dimode.md
    trunk/libgcc/ChangeLog
    trunk/libgcc/config/avr/lib1funcs-fixed.S
    trunk/libgcc/config/avr/lib1funcs.S
    trunk/libgcc/config/avr/t-avr

[Bug target/54222] [avr] Implement fixed-point support

[gjl at gcc dot gnu.org]

http://gcc.gnu.org/bugzilla/show_bug.cgi?id=54222

Georg-Johann Lay <gjl at gcc dot gnu.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|ASSIGNED                    |RESOLVED
         Resolution|                            |FIXED

--- Comment #14 from Georg-Johann Lay <gjl at gcc dot gnu.org> 2013-02-20 08:43:57 UTC ---
#