[Bug bootstrap/54281] [4.8 Regression] Fails to bootstrap with --disable-nls

[Bug bootstrap/54281] [4.8 Regression] Fails to bootstrap with --disable-nls

[rguenth at gcc dot gnu.org]

http://gcc.gnu.org/bugzilla/show_bug.cgi?id=54281

Richard Guenther <rguenth at gcc dot gnu.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
   Target Milestone|---                         |4.8.0

[Bug bootstrap/54281] New: [4.8 Regression] Fails to bootstrap with --disable-nls

[rguenth at gcc dot gnu.org]

http://gcc.gnu.org/bugzilla/show_bug.cgi?id=54281

             Bug #: 54281
           Summary: [4.8 Regression] Fails to bootstrap with --disable-nls
    Classification: Unclassified
           Product: gcc
           Version: 4.8.0
            Status: UNCONFIRMED
          Keywords: build
          Severity: normal
          Priority: P3
         Component: bootstrap
        AssignedTo: unassigned@gcc.gnu.org
        ReportedBy: rguenth@gcc.gnu.org


With --disable-nls intl.h does

#ifdef ENABLE_NLS
#include <libintl.h>
extern void gcc_init_libintl (void);
extern size_t gcc_gettext_width (const char *);
#else
/* Stubs.  */
# undef textdomain
# define textdomain(domain) (domain)
# undef bindtextdomain
# define bindtextdomain(domain, directory) (domain)
# undef gettext
# define gettext(msgid) (msgid)

which wrecks an included libintl.h:

extern char *(__const char *__msgid) throw () __attribute__ 
               ((__format_arg__ (1)));

and g++ rightfully complains.

We end up including libintl.h through

gcc/double-int.h
#include <gmp.h>
  #include <iosfwd>  (here from GCC 4.1)
    #include <bits/c++locale.h>
      #include <libintl.h>

[Bug bootstrap/54281] [4.8 Regression] Fails to bootstrap with --disable-nls

[rguenth at gcc dot gnu.org]

http://gcc.gnu.org/bugzilla/show_bug.cgi?id=54281

Richard Guenther <rguenth at gcc dot gnu.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |dnovillo at gcc dot
                   |                            |gnu.org, iant at google dot
                   |                            |com

--- Comment #1 from Richard Guenther <rguenth at gcc dot gnu.org> 2012-08-16 11:01:51 UTC ---
Diego / Ian, can any of you try to fix this?  Possibly by looking for and
including libintl.h before re-defining those macros?  It's the toplevel
intl.h btw.

Broke all our autotesters ...

[Bug bootstrap/54281] [4.8 Regression] Fails to bootstrap with --disable-nls

[rguenth at gcc dot gnu.org]

http://gcc.gnu.org/bugzilla/show_bug.cgi?id=54281

--- Comment #2 from Richard Guenther <rguenth at gcc dot gnu.org> 2012-08-16 11:18:42 UTC ---
Another fix is to include all system headers (and thus gmp.h) from system.h
which always comes before includes of intl.h.

[Bug bootstrap/54281] [4.8 Regression] Fails to bootstrap with --disable-nls

[rguenth at gcc dot gnu.org]

http://gcc.gnu.org/bugzilla/show_bug.cgi?id=54281

--- Comment #3 from Richard Guenther <rguenth at gcc dot gnu.org> 2012-08-16 11:22:06 UTC ---
Fails with a 4.1 host libstdc++, succeeds with a 4.6 host libstdc++.

[Bug bootstrap/54281] [4.8 Regression] Fails to bootstrap with --disable-nls

[dnovillo at gcc dot gnu.org]

http://gcc.gnu.org/bugzilla/show_bug.cgi?id=54281

--- Comment #4 from Diego Novillo <dnovillo at gcc dot gnu.org> 2012-08-16 12:04:59 UTC ---
Tentative fix: http://gcc.gnu.org/ml/gcc-patches/2012-08/msg01046.html

Don't have an old enough compiler to test it myself.  Need help with testing.

[Bug bootstrap/54281] [4.8 Regression] Fails to bootstrap with --disable-nls

[dnovillo at gcc dot gnu.org]

http://gcc.gnu.org/bugzilla/show_bug.cgi?id=54281

--- Comment #5 from Diego Novillo <dnovillo at gcc dot gnu.org> 2012-08-16 13:28:27 UTC ---
Author: dnovillo
Date: Thu Aug 16 13:28:13 2012
New Revision: 190444

URL: http://gcc.gnu.org/viewcvs?root=gcc&view=rev&rev=190444
Log:
2012-08-16  Diego Novillo  <dnovillo@google.com>

    PR bootstrap/54281
    * double-int.h: Move including of gmp.h ...
    * system.h: ... here.
    * realmpfr.h: Do not include gmp.h.
    * tree-ssa-loop-niter.c: Do not include gmp.h.

fortran/ChangeLog
    * gfortran.h: Do not include gmp.h.

Modified:
    trunk/gcc/ChangeLog
    trunk/gcc/double-int.h
    trunk/gcc/fortran/ChangeLog
    trunk/gcc/fortran/gfortran.h
    trunk/gcc/realmpfr.h
    trunk/gcc/system.h
    trunk/gcc/tree-ssa-loop-niter.c

[Bug bootstrap/54281] [4.8 Regression] Fails to bootstrap with --disable-nls

[dnovillo at gcc dot gnu.org]

http://gcc.gnu.org/bugzilla/show_bug.cgi?id=54281

Diego Novillo <dnovillo at gcc dot gnu.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|UNCONFIRMED                 |RESOLVED
         Resolution|                            |FIXED

--- Comment #6 from Diego Novillo <dnovillo at gcc dot gnu.org> 2012-08-16 13:30:22 UTC ---
Fixed at rev 190444.

[Bug bootstrap/54281] [4.8 Regression] Fails to bootstrap with --disable-nls

[dnovillo at gcc dot gnu.org]

http://gcc.gnu.org/bugzilla/show_bug.cgi?id=54281

Diego Novillo <dnovillo at gcc dot gnu.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|RESOLVED                    |REOPENED
   Last reconfirmed|                            |2012-08-16
         Resolution|FIXED                       |
     Ever Confirmed|0                           |1

--- Comment #7 from Diego Novillo <dnovillo at gcc dot gnu.org> 2012-08-16 18:03:47 UTC ---
Mi fix broke Ada and in-tree cloog/isl.  I will revert and fix it without the
system.h modification.

[Bug bootstrap/54281] [4.8 Regression] Fails to bootstrap with --disable-nls

[dnovillo at gcc dot gnu.org]

http://gcc.gnu.org/bugzilla/show_bug.cgi?id=54281

--- Comment #8 from Diego Novillo <dnovillo at gcc dot gnu.org> 2012-08-16 18:24:30 UTC ---
Author: dnovillo
Date: Thu Aug 16 18:24:22 2012
New Revision: 190449

URL: http://gcc.gnu.org/viewcvs?root=gcc&view=rev&rev=190449
Log:
2012-08-16   Diego Novillo  <dnovillo@google.com>

    Revert

    PR bootstrap/54281
    * double-int.h: Move including of gmp.h ...
    * system.h: ... here.
    * realmpfr.h: Do not include gmp.h.
    * tree-ssa-loop-niter.c: Do not include gmp.h.

Modified:
    trunk/gcc/ChangeLog
    trunk/gcc/double-int.h
    trunk/gcc/fortran/ChangeLog
    trunk/gcc/fortran/gfortran.h
    trunk/gcc/realmpfr.h
    trunk/gcc/system.h
    trunk/gcc/tree-ssa-loop-niter.c

[Bug bootstrap/54281] [4.8 Regression] Fails to bootstrap with --disable-nls

[dnovillo at gcc dot gnu.org]

http://gcc.gnu.org/bugzilla/show_bug.cgi?id=54281

--- Comment #9 from Diego Novillo <dnovillo at gcc dot gnu.org> 2012-08-16 18:42:48 UTC ---
New proposed patch.  Needs testing with a 4.1 compiler.  I couldn't build my
own (fails to build).

http://gcc.gnu.org/ml/gcc-patches/2012-08/msg01090.html

[Bug bootstrap/54281] [4.8 Regression] Fails to bootstrap with --disable-nls

[dnovillo at gcc dot gnu.org]

http://gcc.gnu.org/bugzilla/show_bug.cgi?id=54281

--- Comment #10 from Diego Novillo <dnovillo at gcc dot gnu.org> 2012-08-17 15:38:03 UTC ---
Author: dnovillo
Date: Fri Aug 17 15:37:57 2012
New Revision: 190487

URL: http://gcc.gnu.org/viewcvs?root=gcc&view=rev&rev=190487
Log:
2012-08-17  Diego Novillo  <dnovillo@google.com>

    PR bootstrap/54281
    * configure.ac: Add libintl.h to AC_CHECK_HEADERS list.
    * config.in: Regenerate.
    * configure: Regenerate.
    * intl.h: Always include libintl.h if HAVE_LIBINTL_H is
    set.

Modified:
    trunk/gcc/ChangeLog
    trunk/gcc/config.in
    trunk/gcc/configure
    trunk/gcc/configure.ac
    trunk/gcc/intl.h

[Bug bootstrap/54281] [4.8 Regression] Fails to bootstrap with --disable-nls

[dnovillo at gcc dot gnu.org]

http://gcc.gnu.org/bugzilla/show_bug.cgi?id=54281

--- Comment #11 from Diego Novillo <dnovillo at gcc dot gnu.org> 2012-08-17 16:17:20 UTC ---
Fixed.  http://gcc.gnu.org/ml/gcc-patches/2012-08/msg01181.html

[Bug bootstrap/54281] [4.8 Regression] Fails to bootstrap with --disable-nls

[dnovillo at gcc dot gnu.org]

http://gcc.gnu.org/bugzilla/show_bug.cgi?id=54281

Diego Novillo <dnovillo at gcc dot gnu.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|REOPENED                    |RESOLVED
         Resolution|                            |FIXED

--- Comment #12 from Diego Novillo <dnovillo at gcc dot gnu.org> 2012-08-17 16:19:02 UTC ---
.

[Bug bootstrap/54281] [4.8 Regression] Fails to bootstrap with --disable-nls

[burnus at gcc dot gnu.org]

http://gcc.gnu.org/bugzilla/show_bug.cgi?id=54281

Tobias Burnus <burnus at gcc dot gnu.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |burnus at gcc dot gnu.org

--- Comment #13 from Tobias Burnus <burnus at gcc dot gnu.org> 2012-09-24 19:41:16 UTC ---
This patch kind of caused PR bootstrap/54281.

[Bug bootstrap/54281] [4.8 Regression] Fails to bootstrap with --disable-nls

[burnus at gcc dot gnu.org]

http://gcc.gnu.org/bugzilla/show_bug.cgi?id=54281

--- Comment #14 from Tobias Burnus <burnus at gcc dot gnu.org> 2012-09-24 19:43:07 UTC ---
(In reply to comment #13)
> This patch kind of caused PR bootstrap/54281.
                            [which is this PR ...]

I meant another PR, namely PR bootstrap/54659.