[Bug c/54306] New: ARM iwmmxt2 commit adds imbalanced #endif in mmintrin.h

[Bug c/54306] New: ARM iwmmxt2 commit adds imbalanced #endif in mmintrin.h

[dsd at laptop dot org]

http://gcc.gnu.org/bugzilla/show_bug.cgi?id=54306

             Bug #: 54306
           Summary: ARM iwmmxt2 commit adds imbalanced #endif in
                    mmintrin.h
    Classification: Unclassified
           Product: gcc
           Version: 4.8.0
            Status: UNCONFIRMED
          Severity: normal
          Priority: P3
         Component: c
        AssignedTo: unassigned@gcc.gnu.org
        ReportedBy: dsd@laptop.org
                CC: mattst88@gmail.com, nickc@redhat.com


The commit that added iwmmxt2 support:
http://gcc.gnu.org/git/?p=gcc.git;a=commitdiff;h=6b8f7c284d4443660a1ce94ae695940930a5708c

adds an imbalanced number of #endif to gcc/config/arm/mmintrin.h

This means that iwmmxt support doesn't work, compiles fail when building with
-march=iwmmxt2 due to this imbalance.

I believe the very last line added by the patch to mmintin.h should be removed:
+#endif /* __IWMMXT__ */

The __IWMMXT__ check was already done (and terminated) at the top of the file.

[Bug c/54306] ARM iwmmxt2 commit adds imbalanced #endif in mmintrin.h

[nickc at redhat dot com]

http://gcc.gnu.org/bugzilla/show_bug.cgi?id=54306

--- Comment #1 from Nick Clifton <nickc at redhat dot com> 2012-08-19 07:10:01 UTC ---
Created attachment 28049
  --> http://gcc.gnu.org/bugzilla/attachment.cgi?id=28049
Remove offending #endif

[Bug c/54306] ARM iwmmxt2 commit adds imbalanced #endif in mmintrin.h

[nickc at gcc dot gnu.org]

http://gcc.gnu.org/bugzilla/show_bug.cgi?id=54306

--- Comment #2 from Nick Clifton <nickc at gcc dot gnu.org> 2012-08-19 07:11:42 UTC ---
Author: nickc
Date: Sun Aug 19 07:11:35 2012
New Revision: 190511

URL: http://gcc.gnu.org/viewcvs?root=gcc&view=rev&rev=190511
Log:
    PR target/54306
    * config/arm/mmintrin.h: Remove spurious #endif.

Modified:
    trunk/gcc/ChangeLog
    trunk/gcc/config/arm/mmintrin.h

[Bug c/54306] ARM iwmmxt2 commit adds imbalanced #endif in mmintrin.h

[nickc at redhat dot com]

http://gcc.gnu.org/bugzilla/show_bug.cgi?id=54306

--- Comment #3 from Nick Clifton <nickc at redhat dot com> 2012-08-19 07:13:25 UTC ---
Hi Daniel,

  Thanks for catching this.  It was a snafu, corrected with the obvious fix you
suggested.

Cheers
  Nick

[Bug c/54306] ARM iwmmxt2 commit adds imbalanced #endif in mmintrin.h

[ramana at gcc dot gnu.org]

http://gcc.gnu.org/bugzilla/show_bug.cgi?id=54306

Ramana Radhakrishnan <ramana at gcc dot gnu.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|UNCONFIRMED                 |RESOLVED
                 CC|                            |ramana at gcc dot gnu.org
         Resolution|                            |FIXED
   Target Milestone|---                         |4.8.0

--- Comment #4 from Ramana Radhakrishnan <ramana at gcc dot gnu.org> 2012-11-28 02:41:53 UTC ---
fixed as per nickc's last comment

ramana