[Bug other/54308] New: build regression in 190498 on ppc64/linux: legitimate_indirect_address_p undefined

[Bug other/54308] New: build regression in 190498 on ppc64/linux: legitimate_indirect_address_p undefined

[PHHargrove at lbl dot gov]

http://gcc.gnu.org/bugzilla/show_bug.cgi?id=54308

             Bug #: 54308
           Summary: build regression in 190498 on ppc64/linux:
                    legitimate_indirect_address_p undefined
    Classification: Unclassified
           Product: gcc
           Version: 4.8.0
            Status: UNCONFIRMED
          Severity: normal
          Priority: P3
         Component: other
        AssignedTo: unassigned@gcc.gnu.org
        ReportedBy: PHHargrove@lbl.gov


I pulled gcc-trunk from svn (revision 190498) today hoping to build on my
PPC64/Linux host, knowing that bug 54142 had been fixed in 190427.

Unfortunately something (the build-with-cxx merge being the most obvious
candidate) seems to have broken this build for me when using Red Hat's gcc/g++
4.2.1 from the Linux distro (Fedora Core 6).  The key info appears below, but I
can provide any additional info that might be necessary.

As soon as I am able I will be trying the build on this host with a GCC more
recent than 4.2.1 (and not when patched up by Red Hat).  I will report
success/failure when that has been completed.

-Paul


Script started on Fri 17 Aug 2012 05:36:08 PM PDT
$ svn -q co svn://gcc.gnu.org/svn/gcc/trunk gcc-trunk
$ svn up gcc-trunkK
At revision 190498.
$ cd gcc-trunk
$ ./contrib/gcc_update --touch
[...]
$ cd ..
$ mkdir BLD
$ cd BLD
$ gcc --version
gcc (GCC) 4.1.2 20070626 (Red Hat 4.1.2-13)
Copyright (C) 2006 Free Software Foundation, Inc.
This is free software; see the source for copying conditions.  There is NO
warranty; not even for MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.

$ env 'CFLAGS=-g -O0' \
  ../gcc-trunk/configure --enable-languages=c \
    --disable-bootstrap --enable-checking 'CC=gcc -m64' 'CXX=g++ -m64' \
    --with-mpc=/usr/local/pkg/mpc-0.8.1 \
    --with-mpfr=/usr/local/pkg/mpfr-2.4.2 \
    --with-gmp=/usr/local/pkg/gmp-4.3.2
checking build system type... powerpc64-unknown-linux-gnu
checking host system type... powerpc64-unknown-linux-gnu
checking target system type... powerpc64-unknown-linux-gnu
[...]

$ make
[...]
g++ -m64 -c  -DIN_GCC_FRONTEND -g -O2 -DIN_GCC   -fno-exceptions -fno-rtti -W
-Wall -Wwrite-strings -Wcast-qual -Wmissing-format-attribute -fno-common 
-DHAVE_CONFIG_H -I. -I. -I../../gcc-trunk/gcc -I../../gcc-trunk/gcc/.
-I../../gcc-trunk/gcc/../include -I../../gcc-trunk/gcc/../libcpp/include
-I/usr/local/pkg/gmp-4.3.2/include -I/usr/local/pkg/mpfr-2.4.2/include
-I/usr/local/pkg/mpc-0.8.1/include  -I../../gcc-trunk/gcc/../libdecnumber
-I../../gcc-trunk/gcc/../libdecnumber/dpd -I../libdecnumber    cc1-checksum.c
-o cc1-checksum.o
g++ -m64   -g -O2 -DIN_GCC   -fno-exceptions -fno-rtti -W -Wall -Wwrite-strings
-Wcast-qual -Wmissing-format-attribute -fno-common  -DHAVE_CONFIG_H  -o cc1
c/c-lang.o c-family/stub-objc.o attribs.o c/c-errors.o c/c-decl.o c/c-typeck.o
c/c-convert.o c/c-aux-info.o c/c-objc-common.o c/c-parser.o c-family/c-common.o
c-family/c-cppbuiltin.o c-family/c-dump.o c-family/c-format.o
c-family/c-gimplify.o c-family/c-lex.o c-family/c-omp.o c-family/c-opts.o
c-family/c-pch.o c-family/c-ppoutput.o c-family/c-pragma.o
c-family/c-pretty-print.o c-family/c-semantics.o c-family/c-ada-spec.o
tree-mudflap.o default-c.o rs6000-c.o \
          cc1-checksum.o libbackend.a main.o tree-browser.o libcommon-target.a
libcommon.a ../libcpp/libcpp.a ../libdecnumber/libdecnumber.a libcommon.a
../libcpp/libcpp.a   ../libiberty/libiberty.a ../libdecnumber/libdecnumber.a  
-L/usr/local/pkg/gmp-4.3.2/lib -L/usr/local/pkg/mpfr-2.4.2/lib
-L/usr/local/pkg/mpc-0.8.1/lib -lmpc -lmpfr -lgmp -rdynamic -ldl  -L../zlib -lz
libbackend.a(insn-preds.o): In function `stmw_operation_1':
/home/phargrov/tmp/gcc/BLD/gcc/../../gcc-trunk/gcc/config/rs6000/predicates.md:1374:
undefined reference to `legitimate_indirect_address_p(rtx_def*, int)'
/home/phargrov/tmp/gcc/BLD/gcc/../../gcc-trunk/gcc/config/rs6000/predicates.md:1404:
undefined reference to `legitimate_indirect_address_p(rtx_def*, int)'
libbackend.a(insn-preds.o): In function `lmw_operation_1':
/home/phargrov/tmp/gcc/BLD/gcc/../../gcc-trunk/gcc/config/rs6000/predicates.md:1299:
undefined reference to `legitimate_indirect_address_p(rtx_def*, int)'
/home/phargrov/tmp/gcc/BLD/gcc/../../gcc-trunk/gcc/config/rs6000/predicates.md:1329:
undefined reference to `legitimate_indirect_address_p(rtx_def*, int)'
collect2: ld returned 1 exit status
make[2]: *** [cc1] Error 1
make[2]: Leaving directory `/home/phargrov/tmp/gcc/BLD/gcc'
make[1]: *** [all-gcc] Error 2
make[1]: Leaving directory `/home/phargrov/tmp/gcc/BLD'
make: *** [all] Error 2

[Bug other/54308] build regression in 190498 on ppc64/linux: legitimate_indirect_address_p undefined

[hp at gcc dot gnu.org]

http://gcc.gnu.org/bugzilla/show_bug.cgi?id=54308

Hans-Peter Nilsson <hp at gcc dot gnu.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |hp at gcc dot gnu.org

--- Comment #1 from Hans-Peter Nilsson <hp at gcc dot gnu.org> 2012-08-18 02:32:31 UTC ---
(Note, apparent s/4.2.1/4.1.2/g in initial description.)

I'd suggest updating to just a later gcc build, if you can find *only slightly
newer* rpm:s; as for a x86_64-linux F 8 with gcc-4.1.2-33 ("gcc (GCC) 4.1.2
20070925 (Red Hat 4.1.2-33)"), I'm well into stage 1 for r190498.

[Bug other/54308] build regression in 190498 on ppc64/linux: legitimate_indirect_address_p undefined

[PHHargrove at lbl dot gov]

http://gcc.gnu.org/bugzilla/show_bug.cgi?id=54308

--- Comment #2 from Paul H. Hargrove <PHHargrove at lbl dot gov> 2012-08-18 02:38:21 UTC ---
(In reply to comment #1)
> (Note, apparent s/4.2.1/4.1.2/g in initial description.)

Correct, I am sorry about that.

> I'd suggest updating to just a later gcc build, if you can find *only slightly
> newer* rpm:s; as for a x86_64-linux F 8 with gcc-4.1.2-33 ("gcc (GCC) 4.1.2
> 20070925 (Red Hat 4.1.2-33)"), I'm well into stage 1 for r190498.

I already have a 4.5.1 on that system and am well past the previous failure
point by using it.  I'll see how old I can go after that build is complete.

-Paul

[Bug other/54308] build regression in 190498 on ppc64/linux: legitimate_indirect_address_p undefined

[PHHargrove at lbl dot gov]

http://gcc.gnu.org/bugzilla/show_bug.cgi?id=54308

--- Comment #3 from Paul H. Hargrove <PHHargrove at lbl dot gov> 2012-08-18 03:02:36 UTC ---
(In reply to comment #1)
> I'd suggest updating to just a later gcc build, if you can find *only slightly
> newer* rpm:s; as for a x86_64-linux F 8 with gcc-4.1.2-33 ("gcc (GCC) 4.1.2
> 20070925 (Red Hat 4.1.2-33)"), I'm well into stage 1 for r190498.

Alas use of the Fedora 8 binary RPMs is out as the libmudflap depends on the
Fedora 8 glib, and therefore would require a complete update of my system.

I am looking at the SRPMS for 4.1.2-27.fc7 and later may try 4.1.2-33 as you've
suggested.

I CAN report that building w/ GCC 4.5.1 (built from pristine gcc.gnu.org
sources) works fine.

[Bug other/54308] [4.8 regression] build regression in 190498 on ppc64/linux: legitimate_indirect_address_p undefined

[schwab@linux-m68k.org]

http://gcc.gnu.org/bugzilla/show_bug.cgi?id=54308

Andreas Schwab <schwab@linux-m68k.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|UNCONFIRMED                 |NEW
   Last reconfirmed|                            |2012-08-18
   Target Milestone|---                         |4.8.0
            Summary|build regression in 190498  |[4.8 regression] build
                   |on ppc64/linux:             |regression in 190498 on
                   |legitimate_indirect_address |ppc64/linux:
                   |_p undefined                |legitimate_indirect_address
                   |                            |_p undefined
     Ever Confirmed|0                           |1

--- Comment #4 from Andreas Schwab <schwab@linux-m68k.org> 2012-08-18 07:26:35 UTC ---
legitimate_indirect_address_p is defined inline in rs6000.c, which has
different semantics between C and C++.

[Bug target/54308] [4.8 regression] build regression in 190498 on ppc64/linux: legitimate_indirect_address_p undefined

[gary at intrepid dot com]

http://gcc.gnu.org/bugzilla/show_bug.cgi?id=54308

--- Comment #5 from Gary Funck <gary at intrepid dot com> 2012-08-18 18:39:42 UTC ---
(In reply to comment #1)
> (Note, apparent s/4.2.1/4.1.2/g in initial description.)
> 
> I'd suggest updating to just a later gcc build, if you can find *only slightly
> newer* rpm:s; as for a x86_64-linux F 8 with gcc-4.1.2-33 ("gcc (GCC) 4.1.2
> 20070925 (Red Hat 4.1.2-33)"), I'm well into stage 1 for r190498.

FYI, the failing system has Redhat Release 8 (circa 2002).  Fedocra Core 8
didn't come out until circa 2007.  Thus, it would be surprising that an FC8 RPM
will build on the much older RH8 system.

[Bug target/54308] [4.8 regression] build regression in 190498 on ppc64/linux: legitimate_indirect_address_p undefined

[PHHargrove at lbl dot gov]

http://gcc.gnu.org/bugzilla/show_bug.cgi?id=54308

--- Comment #6 from Paul H. Hargrove <PHHargrove at lbl dot gov> 2012-08-18 19:05:19 UTC ---
(In reply to comment #5 by Gary Funck)
[...]
> FYI, the failing system has Redhat Release 8 (circa 2002).  Fedocra Core 8
> didn't come out until circa 2007.  Thus, it would be surprising that an FC8 RPM
> will build on the much older RH8 system.

Gary,

You are confusing my two failing systems.
This bug report is for a ppc64 system running FC6, making the F8 suggestion
reasonable.
The RH8 system is an x86 and only made it to the discuss list, not a full bug
report.


H-P,

I was unable to build 4.1.2-27.fc7 from the SRPM.
So, I've given up on finding the lowest supported compiler.


-Paul

[Bug target/54308] [4.8 regression] build regression in 190498 on ppc64/linux: legitimate_indirect_address_p undefined

[hp at gcc dot gnu.org]

http://gcc.gnu.org/bugzilla/show_bug.cgi?id=54308

--- Comment #7 from Hans-Peter Nilsson <hp at gcc dot gnu.org> 2012-08-19 18:29:27 UTC ---
(In reply to comment #6)
> I was unable to build 4.1.2-27.fc7 from the SRPM.

I'm not sure it would have helped, seeing as the breakage was in
rs6000-specific parts.

> So, I've given up on finding the lowest supported compiler.

Ok, but see comment 4; try just removing the "inline" there.  If necessary, the
inline can be wrapped in some #ifdef construct.  It depends on the maintainer
to deem it acceptable of course.

[Bug target/54308] [4.8 regression] build regression in 190498 on ppc64/linux: legitimate_indirect_address_p undefined

[PHHargrove at lbl dot gov]

http://gcc.gnu.org/bugzilla/show_bug.cgi?id=54308

--- Comment #8 from Paul H. Hargrove <PHHargrove at lbl dot gov> 2012-08-20 08:57:29 UTC ---
(In reply to comment #7)
[...]
> Ok, but see comment 4; try just removing the "inline" there.  If necessary, the
> inline can be wrapped in some #ifdef construct.  It depends on the maintainer
> to deem it acceptable of course.

I tried removing the "inline" keyword as suggested, from revision 190524 if it
matters.
I then attempted to build stage1 using gcc-4.1.2, just as I had originally.
I was able to build stage w/o any problems with just that 1-word change.

[Bug target/54308] [4.8 regression] build regression in 190498 on ppc64/linux: legitimate_indirect_address_p undefined

[jakub at gcc dot gnu.org]

http://gcc.gnu.org/bugzilla/show_bug.cgi?id=54308

--- Comment #9 from Jakub Jelinek <jakub at gcc dot gnu.org> 2012-11-08 20:09:20 UTC ---
Author: jakub
Date: Thu Nov  8 20:09:14 2012
New Revision: 193336

URL: http://gcc.gnu.org/viewcvs?root=gcc&view=rev&rev=193336
Log:
    PR target/54308
    * config/rs6000/rs6000.c (legitimate_indirect_address_p): Remove
    inline keyword.

Modified:
    trunk/gcc/ChangeLog
    trunk/gcc/config/rs6000/rs6000.c

[Bug target/54308] [4.8 regression] build regression in 190498 on ppc64/linux: legitimate_indirect_address_p undefined

[jakub at gcc dot gnu.org]

http://gcc.gnu.org/bugzilla/show_bug.cgi?id=54308

Jakub Jelinek <jakub at gcc dot gnu.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |RESOLVED
                 CC|                            |jakub at gcc dot gnu.org
         Resolution|                            |FIXED

--- Comment #10 from Jakub Jelinek <jakub at gcc dot gnu.org> 2012-11-08 20:19:00 UTC ---
Fixed.