[Bug tree-optimization/54317] New: [4.8 Regression] FAIL: c45532m c45532n c45532o c45532p

[Bug tree-optimization/54317] New: [4.8 Regression] FAIL: c45532m c45532n c45532o c45532p

[danglin at gcc dot gnu.org]

http://gcc.gnu.org/bugzilla/show_bug.cgi?id=54317

             Bug #: 54317
           Summary: [4.8 Regression] FAIL: c45532m c45532n c45532o c45532p
    Classification: Unclassified
           Product: gcc
           Version: 4.8.0
            Status: UNCONFIRMED
          Severity: normal
          Priority: P3
         Component: tree-optimization
        AssignedTo: unassigned@gcc.gnu.org
        ReportedBy: danglin@gcc.gnu.org
              Host: hppa*-*-* (32-bit)
            Target: hppa*-*-* (32-bit)
             Build: hppa*-*-* (32-bit)


All fails are similar:

BUILD c45532m.adb
gnatmake --GCC="/test/gnu/gcc/objdir/gcc/xgcc -B/test/gnu/gcc/objdir/gcc/"
-gnatws -O2 -I/test/gnu/gcc/objdir/gcc/testsuite/ada/acats/support c45532m.adb
-largs
 --GCC="/test/gnu/gcc/objdir/gcc/xgcc -B/test/gnu/gcc/objdir/gcc/"
/test/gnu/gcc/objdir/gcc/xgcc -c -B/test/gnu/gcc/objdir/gcc/ -gnatws -O2
-I/test
/gnu/gcc/objdir/gcc/testsuite/ada/acats/support c45532m.adbgnatbind
-I/test/gnu/gcc/objdir/gcc/testsuite/ada/acats/support -x c45532m.alignatlink
c45532m.ali -O2 --GCC=/test/gnu/gcc/objdir/gcc/xgcc -B/test/gnu/gcc/obj
dir/gcc/RUN c45532m

,.,. C45532M ACATS 2.5 12-08-17 21:15:16---- C45532M FIXED POINT OPERATOR "*".
   * C45532M RESULT OF "*" OUTSIDE RESULT MODEL INTERVAL WHEN A, B, AND 
                A * B ARE ALL MODEL NUMBERS.
   * C45532M RESULT OF "*" OUTSIDE RESULT MODEL INTERVAL WHEN A, B MODEL
                NUMBERS A * B NOT.
   * C45532M RESULT OF "*" OUTSIDE RESULT MODEL INTERVAL WHEN USING NO
                MODEL NUMBERS.
**** C45532M FAILED ****************************.
FAIL:   c45532m

BUILD c45532n.adb
gnatmake --GCC="/test/gnu/gcc/objdir/gcc/xgcc -B/test/gnu/gcc/objdir/gcc/"
-gnatws -O2 -I/test/gnu/gcc/objdir/gcc/testsuite/ada/acats/support c45532n.adb
-largs --GCC="/test/gnu/gcc/objdir/gcc/xgcc -B/test/gnu/gcc/objdir/gcc/"
/test/gnu/gcc/objdir/gcc/xgcc -c -B/test/gnu/gcc/objdir/gcc/ -gnatws -O2
-I/test/gnu/gcc/objdir/gcc/testsuite/ada/acats/support c45532n.adb
gnatbind -I/test/gnu/gcc/objdir/gcc/testsuite/ada/acats/support -x c45532n.ali
gnatlink c45532n.ali -O2 --GCC=/test/gnu/gcc/objdir/gcc/xgcc
-B/test/gnu/gcc/objdir/gcc/
RUN c45532n

,.,. C45532N ACATS 2.5 12-08-17 21:15:20
---- C45532N FIXED POINT OPERATOR "/".
   * C45532N RESULT OF "/" OUTSIDE RESULT MODEL INTERVAL WHEN A, B, AND 
                A / B ARE ALL MODEL NUMBERS.
   * C45532N RESULT OF "/" OUTSIDE RESULT MODEL INTERVAL WHEN USING NO
                MODEL NUMBERS.
**** C45532N FAILED ****************************.
FAIL:   c45532n

BUILD c45532o.adb
gnatmake --GCC="/test/gnu/gcc/objdir/gcc/xgcc -B/test/gnu/gcc/objdir/gcc/"
-gnatws -O2 -I/test/gnu/gcc/objdir/gcc/testsuite/ada/acats/support c45532o.adb
-largs --GCC="/test/gnu/gcc/objdir/gcc/xgcc -B/test/gnu/gcc/objdir/gcc/"
/test/gnu/gcc/objdir/gcc/xgcc -c -B/test/gnu/gcc/objdir/gcc/ -gnatws -O2
-I/test/gnu/gcc/objdir/gcc/testsuite/ada/acats/support c45532o.adb
gnatbind -I/test/gnu/gcc/objdir/gcc/testsuite/ada/acats/support -x c45532o.ali
gnatlink c45532o.ali -O2 --GCC=/test/gnu/gcc/objdir/gcc/xgcc
-B/test/gnu/gcc/objdir/gcc/
RUN c45532o

,.,. C45532O ACATS 2.5 12-08-17 21:15:24
---- C45532O FIXED POINT OPERATOR "*".
   * C45532O RESULT OF "*" OUTSIDE RESULT MODEL INTERVAL WHEN A, B, AND 
                A * B ARE ALL MODEL NUMBERS.
   * C45532O RESULT OF "*" OUTSIDE RESULT MODEL INTERVAL WHEN A, B MODEL
                NUMBERS A * B NOT.
   * C45532O RESULT OF "*" OUTSIDE RESULT MODEL INTERVAL WHEN USING NO
                MODEL NUMBERS.
**** C45532O FAILED ****************************.
FAIL:   c45532o

BUILD c45532p.adbgnatmake --GCC="/test/gnu/gcc/objdir/gcc/xgcc
-B/test/gnu/gcc/objdir/gcc/" -gnat
ws -O2 -I/test/gnu/gcc/objdir/gcc/testsuite/ada/acats/support c45532p.adb
-largs --GCC="/test/gnu/gcc/objdir/gcc/xgcc -B/test/gnu/gcc/objdir/gcc/"
/test/gnu/gcc/objdir/gcc/xgcc -c -B/test/gnu/gcc/objdir/gcc/ -gnatws -O2
-I/test
/gnu/gcc/objdir/gcc/testsuite/ada/acats/support c45532p.adbgnatbind
-I/test/gnu/gcc/objdir/gcc/testsuite/ada/acats/support -x c45532p.ali
gnatlink c45532p.ali -O2 --GCC=/test/gnu/gcc/objdir/gcc/xgcc
-B/test/gnu/gcc/obj
dir/gcc/
RUN c45532p

,.,. C45532P ACATS 2.5 12-08-17 21:15:28
---- C45532P FIXED POINT OPERATOR "/".
   * C45532P RESULT OF "/" OUTSIDE RESULT MODEL INTERVAL WHEN A, B, AND 
                A / B ARE ALL MODEL NUMBERS.
   * C45532P RESULT OF "/" OUTSIDE RESULT MODEL INTERVAL WHEN USING NO
                MODEL NUMBERS.
**** C45532P FAILED ****************************.FAIL:   c45532p

Introduced in revision 189861:

2012-07-25 Marc Glisse <marc.glisse@inria.fr>

    PR tree-optimization/30318
    * tree-vrp.c (extract_range_from_binary_expr_1) [PLUS_EXPR]:
    Handle __int128.
    [MINUS_EXPR]: Merge with PLUS_EXPR.

[Bug tree-optimization/54317] [4.8 Regression] FAIL: c45532m c45532n c45532o c45532p

[rguenth at gcc dot gnu.org]

http://gcc.gnu.org/bugzilla/show_bug.cgi?id=54317

Richard Guenther <rguenth at gcc dot gnu.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |glisse at gcc dot gnu.org
   Target Milestone|---                         |4.8.0

[Bug tree-optimization/54317] [4.8 Regression] FAIL: c45532m c45532n c45532o c45532p

[glisse at gcc dot gnu.org]

http://gcc.gnu.org/bugzilla/show_bug.cgi?id=54317

--- Comment #1 from Marc Glisse <glisse at gcc dot gnu.org> 2012-08-20 15:46:58 UTC ---
Wow, I didn't expect that patch to break a multiplication test...
It sounds like you have before and after compilers. Do you have tree-vrp dumps
from both? (I would ask if a stage1 compiler fails too, to rule out
miscompilation of the compiler, but I have no idea how ada works...)

Is hwint 32 bits on this platform? I am looking for acats testresults from
other such platforms in gcc-testresults but can't find them...

[Bug tree-optimization/54317] [4.8 Regression] FAIL: c45532m c45532n c45532o c45532p

[dave.anglin at bell dot net]

http://gcc.gnu.org/bugzilla/show_bug.cgi?id=54317

--- Comment #2 from dave.anglin at bell dot net 2012-08-20 16:23:57 UTC ---
On 8/20/2012 11:46 AM, glisse at gcc dot gnu.org wrote:
> http://gcc.gnu.org/bugzilla/show_bug.cgi?id=54317
>
> --- Comment #1 from Marc Glisse <glisse at gcc dot gnu.org> 2012-08-20 15:46:58 UTC ---
> Wow, I didn't expect that patch to break a multiplication test...
> It sounds like you have before and after compilers. Do you have tree-vrp dumps
> from both? (I would ask if a stage1 compiler fails too, to rule out
> miscompilation of the compiler, but I have no idea how ada works...)
At the moment, I have no idea as to which module is broken but I believe 
the problem
is in the Ada runtime library.  I compared the .o files for the first 
test of the four failing tests
using before and after compilers and they were identical.

The ada tests are not compiled with debugging enabled, so they are a bit 
difficult
to debug.  The tests invoke a lot of arithmetic operations...
> Is hwint 32 bits on this platform? I am looking for acats testresults from
> other such platforms in gcc-testresults but can't find them...
>
Yes, hwint is 32 bits.  I just fixed a couple of issues with expand_mult 
(PR middle-end/53823).
The synth_mult code can't handle multiplication by negative coefficients 
when the mode is
larger than a hwint.  One possibility might be that this code is being 
invoked by another path.

[Bug tree-optimization/54317] [4.8 Regression] FAIL: c45532m c45532n c45532o c45532p

[glisse at gcc dot gnu.org]

http://gcc.gnu.org/bugzilla/show_bug.cgi?id=54317

--- Comment #3 from Marc Glisse <glisse at gcc dot gnu.org> 2012-08-22 06:19:17 UTC ---
Actually, I reviewed my patch and I just found a bug, which can be seen on
x86_64 with:
extern void g();
void f(unsigned __int128 x){
  unsigned __int128 n2 = 1; n2 <<= 127;
  if(x>n2)return;
  unsigned __int128 y = x + x;
  if (y == 42) g();
}

(using gmp in tree-vrp would have been so much less trouble...)

I'll try to fix that soon and we'll see if the failures disappear.

[Bug tree-optimization/54317] [4.8 Regression] FAIL: c45532m c45532n c45532o c45532p

[glisse at gcc dot gnu.org]

http://gcc.gnu.org/bugzilla/show_bug.cgi?id=54317

--- Comment #4 from Marc Glisse <glisse at gcc dot gnu.org> 2012-08-22 12:29:34 UTC ---
Author: glisse
Date: Wed Aug 22 12:29:23 2012
New Revision: 190591

URL: http://gcc.gnu.org/viewcvs?root=gcc&view=rev&rev=190591
Log:
2012-08-22  Marc Glisse  <marc.glisse@inria.fr>

    PR tree-optimization/54317

gcc/
    * tree-vrp.c (extract_range_from_binary_expr_1): Test for
    double_int overflow.
    Remove dead tests.

gcc/testsuite/
    * gcc.dg/tree-ssa/vrp79.c: New testcase.


Added:
    trunk/gcc/testsuite/gcc.dg/tree-ssa/vrp79.c   (with props)
Modified:
    trunk/gcc/ChangeLog
    trunk/gcc/testsuite/ChangeLog
    trunk/gcc/tree-vrp.c

Propchange: trunk/gcc/testsuite/gcc.dg/tree-ssa/vrp79.c
            ('svn:eol-style' added)

Propchange: trunk/gcc/testsuite/gcc.dg/tree-ssa/vrp79.c
            ('svn:keywords' added)

[Bug tree-optimization/54317] [4.8 Regression] FAIL: c45532m c45532n c45532o c45532p

[glisse at gcc dot gnu.org]

http://gcc.gnu.org/bugzilla/show_bug.cgi?id=54317

--- Comment #5 from Marc Glisse <glisse at gcc dot gnu.org> 2012-08-22 12:38:36 UTC ---
Hello,

I have no idea if the last commit helped, feel free to reconfirm the bug.

[Bug tree-optimization/54317] [4.8 Regression] FAIL: c45532m c45532n c45532o c45532p

[danglin at gcc dot gnu.org]

http://gcc.gnu.org/bugzilla/show_bug.cgi?id=54317

John David Anglin <danglin at gcc dot gnu.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|UNCONFIRMED                 |RESOLVED
         Resolution|                            |FIXED

--- Comment #6 from John David Anglin <danglin at gcc dot gnu.org> 2012-08-23 22:07:47 UTC ---
Fixed by change!