public inbox for gcc-bugs@sourceware.org
help / color / mirror / Atom feed
From: "dnovillo at google dot com" <gcc-bugzilla@gcc.gnu.org>
To: gcc-bugs@gcc.gnu.org
Subject: [Bug fortran/54332] [4.8 Regression] 481.wrf in SPEC CPU 2006 takes > 10GB memory to compile
Date: Tue, 21 Aug 2012 20:49:00 -0000	[thread overview]
Message-ID: <bug-54332-4-Y3MvsTauTp@http.gcc.gnu.org/bugzilla/> (raw)
In-Reply-To: <bug-54332-4@http.gcc.gnu.org/bugzilla/>

http://gcc.gnu.org/bugzilla/show_bug.cgi?id=54332

--- Comment #25 from dnovillo at google dot com <dnovillo at google dot com> 2012-08-21 20:49:16 UTC ---
On 2012-08-21 15:53 , hjl.tools at gmail dot com wrote:
> http://gcc.gnu.org/bugzilla/show_bug.cgi?id=54332
>
> --- Comment #24 from H.J. Lu <hjl.tools at gmail dot com> 2012-08-21 19:53:14 UTC ---
> (In reply to comment #23)
>>
>> The problem with this is that you are switching a stack vec into a heap
>> vec.  This may not always be what the caller wanted.
>
> My patch just restores the old behavior.

You are right.  This was always the case.  I added the extra check to 
guard against inadvertent *initial* heap allocations for stack vectors.

But now that I see the old code, this was always the case.  The 
subsequent stack operations after the first round around the loop will 
move the stacks into the heap.

The patch is OK with a ChangeLog and bootstrap testing.


Thanks!  Diego.


  parent reply	other threads:[~2012-08-21 20:49 UTC|newest]

Thread overview: 30+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-08-20 18:06 [Bug fortran/54332] New: " hjl.tools at gmail dot com
2012-08-20 20:53 ` [Bug fortran/54332] " hjl.tools at gmail dot com
2012-08-20 21:18 ` hjl.tools at gmail dot com
2012-08-20 21:21 ` steven at gcc dot gnu.org
2012-08-20 21:42 ` hjl.tools at gmail dot com
2012-08-21  2:59 ` hjl.tools at gmail dot com
2012-08-21  8:26 ` rguenth at gcc dot gnu.org
2012-08-21 13:39 ` dnovillo at google dot com
2012-08-21 13:58 ` hjl.tools at gmail dot com
2012-08-21 14:07 ` dnovillo at google dot com
2012-08-21 16:21 ` hjl.tools at gmail dot com
2012-08-21 16:44 ` dnovillo at google dot com
2012-08-21 16:52 ` hjl.tools at gmail dot com
2012-08-21 16:56 ` dnovillo at gcc dot gnu.org
2012-08-21 17:10 ` hjl.tools at gmail dot com
2012-08-21 17:41 ` hjl.tools at gmail dot com
2012-08-21 17:58 ` hjl.tools at gmail dot com
2012-08-21 18:09 ` hjl.tools at gmail dot com
2012-08-21 18:19 ` dnovillo at google dot com
2012-08-21 18:32 ` dnovillo at google dot com
2012-08-21 18:55 ` hjl.tools at gmail dot com
2012-08-21 19:08 ` dnovillo at google dot com
2012-08-21 19:20 ` steven at gcc dot gnu.org
2012-08-21 19:28 ` hjl.tools at gmail dot com
2012-08-21 19:50 ` dnovillo at google dot com
2012-08-21 19:53 ` hjl.tools at gmail dot com
2012-08-21 20:49 ` dnovillo at google dot com [this message]
2012-08-21 21:07 ` hjl at gcc dot gnu.org
2012-08-21 21:11 ` hjl.tools at gmail dot com
2012-08-22  9:02 ` [Bug middle-end/54332] " steven at gcc dot gnu.org

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=bug-54332-4-Y3MvsTauTp@http.gcc.gnu.org/bugzilla/ \
    --to=gcc-bugzilla@gcc.gnu.org \
    --cc=gcc-bugs@gcc.gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).