public inbox for gcc-bugs@sourceware.org
help / color / mirror / Atom feed
From: "cvs-commit at gcc dot gnu.org" <gcc-bugzilla@gcc.gnu.org>
To: gcc-bugs@gcc.gnu.org
Subject: [Bug tree-optimization/54346] combine permutations
Date: Fri, 21 Oct 2022 07:17:54 +0000	[thread overview]
Message-ID: <bug-54346-4-DCbDmRG0Mc@http.gcc.gnu.org/bugzilla/> (raw)
In-Reply-To: <bug-54346-4@http.gcc.gnu.org/bugzilla/>

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=54346

--- Comment #8 from CVS Commits <cvs-commit at gcc dot gnu.org> ---
The master branch has been updated by Jakub Jelinek <jakub@gcc.gnu.org>:

https://gcc.gnu.org/g:fa553ff26d96f6fecaa8f1b00649cfdc6cda5f5a

commit r13-3430-gfa553ff26d96f6fecaa8f1b00649cfdc6cda5f5a
Author: Jakub Jelinek <jakub@redhat.com>
Date:   Fri Oct 21 09:16:44 2022 +0200

    match.pd: Fix up gcc.dg/pr54346.c on i686-linux [PR54346]

    The pr54346.c testcase FAILs on i686-linux (without -msse*) for multiple
    reasons.  One is the trivial missing -Wno-psabi which the following patch
    adds, but that isn't enough.  The thing is that without native vector
    support, we have VEC_PERM_EXPRs in the IL and are actually considering
    the nested VEC_PERM_EXPRs into one VEC_PERM_EXPR optimization, but punt
    because can_vec_perm_const_p (result_mode, op_mode, sel2, false) is false.

    Such a test makes sense to prevent "optimizing" two VEC_PERM_EXPRs
    that can be handled by the backend natively into one VEC_PERM_EXPR
    that can't be handled.  But if both of the original VEC_PERM_EXPRs
    can't be handled natively either, having just one VEC_PERM_EXPR that will
be
    lowered by generic vec lowering is IMHO still better than 2.
    Or even if we trade just one VEC_PERM_EXPR that can't be handled plus
    one that can to one that can't be handled.

    Also, removing the testcase's executable permissions...

    2022-10-21  <jakub@redhat.com>

            PR tree-optimization/54346
            * match.pd ((vec_perm (vec_perm@0 @1 @2 VECTOR_CST) @0
VECTOR_CST)):
            Optimize nested VEC_PERM_EXPRs even if target can't handle the
            new one provided we don't increase number of VEC_PERM_EXPRs the
            target can't handle.

            * gcc.dg/pr54346.c: Add -Wno-psabi to dg-options.

  parent reply	other threads:[~2022-10-21  7:17 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-08-21 14:02 [Bug tree-optimization/54346] New: " glisse at gcc dot gnu.org
2021-08-25  7:26 ` [Bug tree-optimization/54346] " pinskia at gcc dot gnu.org
2021-08-25  9:02 ` pinskia at gcc dot gnu.org
2022-06-07  9:10 ` crazylht at gmail dot com
2022-10-11  6:12 ` cvs-commit at gcc dot gnu.org
2022-10-11  6:21 ` glisse at gcc dot gnu.org
2022-10-11  6:36 ` crazylht at gmail dot com
2022-10-21  7:17 ` cvs-commit at gcc dot gnu.org [this message]
2022-10-25  5:53 ` crazylht at gmail dot com

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=bug-54346-4-DCbDmRG0Mc@http.gcc.gnu.org/bugzilla/ \
    --to=gcc-bugzilla@gcc.gnu.org \
    --cc=gcc-bugs@gcc.gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).