[Bug target/54347] New: REAL_VALUE_TO_TARGET_LONG_DOUBLE shouldn't be used in i386

[Bug target/54347] New: REAL_VALUE_TO_TARGET_LONG_DOUBLE shouldn't be used in i386

[hjl.tools at gmail dot com]

http://gcc.gnu.org/bugzilla/show_bug.cgi?id=54347

             Bug #: 54347
           Summary: REAL_VALUE_TO_TARGET_LONG_DOUBLE shouldn't be used in
                    i386
    Classification: Unclassified
           Product: gcc
           Version: 4.8.0
            Status: UNCONFIRMED
          Severity: normal
          Priority: P3
         Component: target
        AssignedTo: unassigned@gcc.gnu.org
        ReportedBy: hjl.tools@gmail.com
                CC: ubizjak@gmail.com


i386.c has

  /* The __float80 type.  */
  float80_type_node = long_double_type_node;
  if (TYPE_MODE (float80_type_node) != XFmode)
    {
      /* The __float80 type.  */
      float80_type_node = make_node (REAL_TYPE);

      TYPE_PRECISION (float80_type_node) = 80;
      layout_type (float80_type_node);
    }
  lang_hooks.types.register_builtin_type (float80_type_node, "__float80");

and

i386-interix.h:#undef LONG_DOUBLE_TYPE_SIZE
i386-interix.h:#define LONG_DOUBLE_TYPE_SIZE 64

long double may not be 80-bit.  But i386.c has

               case XFmode:
                  REAL_VALUE_TO_TARGET_LONG_DOUBLE (r, l);
                  parts[2] = gen_int_mode (l[2], SImode);
                  break;

It assumes long double is in XFmode.  It should simply use

real_to_target (l, &r, mode);

instead of

REAL_VALUE_TO_TARGET_LONG_DOUBLE (r, l);

[Bug target/54347] REAL_VALUE_TO_TARGET_LONG_DOUBLE shouldn't be used with XFmode

[hjl.tools at gmail dot com]

http://gcc.gnu.org/bugzilla/show_bug.cgi?id=54347

H.J. Lu <hjl.tools at gmail dot com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
   Target Milestone|---                         |4.8.0

--- Comment #1 from H.J. Lu <hjl.tools at gmail dot com> 2012-08-22 13:56:00 UTC ---
This is similar to PR 15290.

[Bug target/54347] REAL_VALUE_TO_TARGET_LONG_DOUBLE shouldn't be used with XFmode

[hjl at gcc dot gnu.org]

http://gcc.gnu.org/bugzilla/show_bug.cgi?id=54347

--- Comment #2 from hjl at gcc dot gnu.org <hjl at gcc dot gnu.org> 2012-08-22 19:44:04 UTC ---
Author: hjl
Date: Wed Aug 22 19:43:58 2012
New Revision: 190598

URL: http://gcc.gnu.org/viewcvs?root=gcc&view=rev&rev=190598
Log:
Replace REAL_VALUE_TO_TARGET_LONG_DOUBLE with real_to_target

    PR target/54347
    * config/i386/i386.c (ix86_split_to_parts): Replace
    REAL_VALUE_TO_TARGET_LONG_DOUBLE with real_to_target.

Modified:
    trunk/gcc/ChangeLog
    trunk/gcc/config/i386/i386.c

[Bug target/54347] REAL_VALUE_TO_TARGET_LONG_DOUBLE shouldn't be used with XFmode

[hjl.tools at gmail dot com]

http://gcc.gnu.org/bugzilla/show_bug.cgi?id=54347

H.J. Lu <hjl.tools at gmail dot com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|UNCONFIRMED                 |RESOLVED
         Resolution|                            |FIXED

--- Comment #3 from H.J. Lu <hjl.tools at gmail dot com> 2012-10-24 09:35:46 UTC ---
Fixed.