public inbox for gcc-bugs@sourceware.org
help / color / mirror / Atom feed
From: "jakub at gcc dot gnu.org" <gcc-bugzilla@gcc.gnu.org>
To: gcc-bugs@gcc.gnu.org
Subject: [Bug debug/54402] [4.8 Regression] var-tracking does not scale
Date: Mon, 29 Oct 2012 17:14:00 -0000 [thread overview]
Message-ID: <bug-54402-4-tyxc7UgIBx@http.gcc.gnu.org/bugzilla/> (raw)
In-Reply-To: <bug-54402-4@http.gcc.gnu.org/bugzilla/>
http://gcc.gnu.org/bugzilla/show_bug.cgi?id=54402
Jakub Jelinek <jakub at gcc dot gnu.org> changed:
What |Removed |Added
----------------------------------------------------------------------------
Status|NEW |ASSIGNED
AssignedTo|unassigned at gcc dot |jakub at gcc dot gnu.org
|gnu.org |
--- Comment #8 from Jakub Jelinek <jakub at gcc dot gnu.org> 2012-10-29 17:13:45 UTC ---
Created attachment 28562
--> http://gcc.gnu.org/bugzilla/attachment.cgi?id=28562
gcc48-pr54402.patch
For the go1 testcases, the issue really is that with reload the large function
is not using frame pointer, while with LRA it is.
And with frame pointer, the issue is that because there is the stack check bb
before prologue (but, generally, any shrink wrapped function with the hfp
setting prologue not in succ of entry bb) and vt_initialize was trying to be
extra conservative, we wouldn't do the hfp to argp replacements, and ended up
with a VALUE (for hard frame pointer in one of the blocks) with 1173 locs,
mostly reverse_op of other values.
This patch fixes the particular issue by not requiring the fp setter to be in
the entry bb successor (and I've just in case added there a check that it
doesn't trigger on fp restore).
If we hit this kind of issue on some other testcase with a non-sp/hfp value,
I'd say what we could do is mark somehow what locs values are reverse ops, and
let functions like find_base_term or get_addr always ignore all reverse op
locations (perhaps if reverse ops were guaranteed to be always at the end of
the locs chain, find_base_term or get_addr could just stop on the first reverse
op location). The question is how to do that, the structure contains just 3
pointers and thus there is no place to stick something on, perhaps there could
be some extra location chain entry with some magic value that would be ignored
or similar.
next prev parent reply other threads:[~2012-10-29 17:14 UTC|newest]
Thread overview: 39+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-08-29 9:48 [Bug debug/54402] New: " steven at gcc dot gnu.org
2012-08-29 9:50 ` [Bug debug/54402] " steven at gcc dot gnu.org
2012-09-03 10:13 ` rguenth at gcc dot gnu.org
2012-10-05 17:57 ` markus at trippelsdorf dot de
2012-10-16 14:42 ` markus at trippelsdorf dot de
2012-10-16 18:38 ` markus at trippelsdorf dot de
2012-10-26 10:53 ` rsandifo at gcc dot gnu.org
2012-10-26 23:07 ` vmakarov at redhat dot com
2012-10-27 7:24 ` ubizjak at gmail dot com
2012-10-29 9:49 ` jakub at gcc dot gnu.org
2012-10-29 17:14 ` jakub at gcc dot gnu.org [this message]
2012-10-29 17:24 ` jakub at gcc dot gnu.org
2012-10-30 10:59 ` markus at trippelsdorf dot de
2012-10-30 11:25 ` markus at trippelsdorf dot de
2012-10-30 12:26 ` markus at trippelsdorf dot de
2012-10-30 18:24 ` jakub at gcc dot gnu.org
2012-11-05 7:59 ` jakub at gcc dot gnu.org
2012-12-06 16:42 ` rguenth at gcc dot gnu.org
2012-12-06 16:57 ` ro at CeBiTec dot Uni-Bielefeld.DE
2012-12-06 17:01 ` jakub at gcc dot gnu.org
2012-12-10 10:57 ` jakub at gcc dot gnu.org
2012-12-12 11:07 ` ro at CeBiTec dot Uni-Bielefeld.DE
2012-12-12 11:10 ` ro at gcc dot gnu.org
2012-12-12 22:10 ` jakub at gcc dot gnu.org
2012-12-12 22:22 ` jakub at gcc dot gnu.org
2012-12-12 22:30 ` jakub at gcc dot gnu.org
2012-12-13 13:12 ` ro at CeBiTec dot Uni-Bielefeld.DE
2012-12-24 0:37 ` jan.smets@alcatel-lucent.com
2013-01-03 8:52 ` jakub at gcc dot gnu.org
2013-01-18 11:01 ` aoliva at gcc dot gnu.org
2013-01-18 11:08 ` aoliva at gcc dot gnu.org
2013-01-21 10:07 ` ro at CeBiTec dot Uni-Bielefeld.DE
2013-01-23 16:49 ` rguenth at gcc dot gnu.org
2013-01-24 12:46 ` ro at CeBiTec dot Uni-Bielefeld.DE
2013-03-22 14:43 ` [Bug debug/54402] [4.8/4.9 " jakub at gcc dot gnu.org
2013-05-31 10:57 ` jakub at gcc dot gnu.org
2013-10-16 9:50 ` jakub at gcc dot gnu.org
2013-10-25 11:20 ` rguenth at gcc dot gnu.org
2013-10-25 11:48 ` rguenth at gcc dot gnu.org
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=bug-54402-4-tyxc7UgIBx@http.gcc.gnu.org/bugzilla/ \
--to=gcc-bugzilla@gcc.gnu.org \
--cc=gcc-bugs@gcc.gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).