From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <gcc-bugs-return-400296-listarch-gcc-bugs=gcc.gnu.org@gcc.gnu.org>
Received: (qmail 8440 invoked by alias); 6 Sep 2012 14:19:06 -0000
Received: (qmail 8425 invoked by uid 22791); 6 Sep 2012 14:19:05 -0000
X-SWARE-Spam-Status: No, hits=-4.3 required=5.0	tests=ALL_TRUSTED,AWL,BAYES_00,KHOP_THREADED
X-Spam-Check-By: sourceware.org
Received: from localhost (HELO gcc.gnu.org) (127.0.0.1)    by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Thu, 06 Sep 2012 14:18:52 +0000
From: "jakub at gcc dot gnu.org" <gcc-bugzilla@gcc.gnu.org>
To: gcc-bugs@gcc.gnu.org
Subject: [Bug bootstrap/54419] [4.8 Regression] Compiling libstdc++-v3/src/c++11/random.cc fails on platforms not knowing rdrand
Date: Thu, 06 Sep 2012 14:19:00 -0000
X-Bugzilla-Reason: CC
X-Bugzilla-Type: changed
X-Bugzilla-Watch-Reason: None
X-Bugzilla-Product: gcc
X-Bugzilla-Component: bootstrap
X-Bugzilla-Keywords:
X-Bugzilla-Severity: blocker
X-Bugzilla-Who: jakub at gcc dot gnu.org
X-Bugzilla-Status: NEW
X-Bugzilla-Priority: P3
X-Bugzilla-Assigned-To: unassigned at gcc dot gnu.org
X-Bugzilla-Target-Milestone: 4.8.0
X-Bugzilla-Changed-Fields:
Message-ID: <bug-54419-4-j2OScLIZOF@http.gcc.gnu.org/bugzilla/>
In-Reply-To: <bug-54419-4@http.gcc.gnu.org/bugzilla/>
References: <bug-54419-4@http.gcc.gnu.org/bugzilla/>
X-Bugzilla-URL: http://gcc.gnu.org/bugzilla/
Auto-Submitted: auto-generated
Content-Type: text/plain; charset="UTF-8"
MIME-Version: 1.0
Mailing-List: contact gcc-bugs-help@gcc.gnu.org; run by ezmlm
Precedence: bulk
List-Id: <gcc-bugs.gcc.gnu.org>
List-Archive: <http://gcc.gnu.org/ml/gcc-bugs/>
List-Post: <mailto:gcc-bugs@gcc.gnu.org>
List-Help: <mailto:gcc-bugs-help@gcc.gnu.org>
Sender: gcc-bugs-owner@gcc.gnu.org
X-SW-Source: 2012-09/txt/msg00462.txt.bz2

http://gcc.gnu.org/bugzilla/show_bug.cgi?id=54419

--- Comment #40 from Jakub Jelinek <jakub at gcc dot gnu.org> 2012-09-06 14:15:29 UTC ---
(In reply to comment #39)
> The attached revised patch is Ulrich's original with the change of the test in
> configure.ac from...
> 
>   AC_TRY_COMPILE(, [void f(void){asm("rdrand %eax");}],
>          [ac_cv_x86_rdrand=yes], [ac_cv_x86_rdrand=no])
> 
> to
> 
>   AC_TRY_COMPILE(,[asm("rdrand %eax");],
>          [ac_cv_x86_rdrand=yes], [ac_cv_x86_rdrand=no])
> 
> and the additional missing conditional on the definition of _GLIBCXX_X86_RDRAND
> ...
> 
> @@ -118,7 +118,7 @@ namespace std _GLIBCXX_VISIBILITY(defaul
>    random_device::result_type
>    random_device::_M_getval()
>    {
> -#if (defined __i386__ || defined __x86_64__)
> +#if (defined __i386__ || defined __x86_64__) && defined _GLIBCXX_X86_RDRAND
>      if (! _M_file)
>        return __x86_rdrand();
>  #endif
> 
> in libstdc++-v3/src/c++11/random.cc.

Looks ok to me, but patches should be mailed with ChangeLog entry to
gcc-patches and libstdc++ mailing lists.

--- Comment #41 from Jakub Jelinek <jakub at gcc dot gnu.org> 2012-09-06 14:17:18 UTC ---
Ah, actually not completely, the
#if defined __i386__ || defined __x86_64__ && defined _GLIBCXX_X86_RDRAND
line in your patch is wrong, there should be () like in the other two
preprocessor conditionals.