public inbox for gcc-bugs@sourceware.org
help / color / mirror / Atom feed
From: "sgk at troutmask dot apl.washington.edu" <gcc-bugzilla@gcc.gnu.org>
To: gcc-bugs@gcc.gnu.org
Subject: [Bug fortran/54463] -fdefault-real-8 does not promote the BLAS call when using -fexternal-blas
Date: Mon, 03 Sep 2012 13:39:00 -0000	[thread overview]
Message-ID: <bug-54463-4-gkDWYa4gqp@http.gcc.gnu.org/bugzilla/> (raw)
In-Reply-To: <bug-54463-4@http.gcc.gnu.org/bugzilla/>

http://gcc.gnu.org/bugzilla/show_bug.cgi?id=54463

--- Comment #3 from Steve Kargl <sgk at troutmask dot apl.washington.edu> 2012-09-03 13:38:36 UTC ---
On Mon, Sep 03, 2012 at 06:14:22AM +0000, burnus at gcc dot gnu.org wrote:
> http://gcc.gnu.org/bugzilla/show_bug.cgi?id=54463
> 
> Tobias Burnus <burnus at gcc dot gnu.org> changed:
> 
>            What    |Removed                     |Added
> ----------------------------------------------------------------------------
>                  CC|                            |burnus at gcc dot gnu.org
>            Severity|enhancement                 |normal
> 
> --- Comment #2 from Tobias Burnus <burnus at gcc dot gnu.org> 2012-09-03 06:14:22 UTC ---
> The following should work. I am not too kind to have magic numbers, maybe that
> part could be improved.
> 
> --- a/gcc/fortran/trans-intrinsic.c
> +++ b/gcc/fortran/trans-intrinsic.c
> @@ -2364,4 +2364,3 @@ gfc_conv_intrinsic_funcall (gfc_se * se, gfc_expr * expr)
>           && (sym->ts.type == BT_REAL || sym->ts.type == BT_COMPLEX)
> -         && (sym->ts.kind == gfc_default_real_kind
> -             || sym->ts.kind == gfc_default_double_kind))
> +         && (sym->ts.kind == 4 || sym->ts.kind == 8))

What about -freal-4-real-10 -freal-4-real-16 -freal-4-real-8
-freal-8-real-10 -freal-8-real-16 and -freal-8-real-4?  See
my initial response.  The correct solution it write proper
Fortran.


  parent reply	other threads:[~2012-09-03 13:39 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-09-02 20:00 [Bug fortran/54463] New: " dominiq at lps dot ens.fr
2012-09-02 23:46 ` [Bug fortran/54463] " kargl at gcc dot gnu.org
2012-09-03  6:14 ` burnus at gcc dot gnu.org
2012-09-03 13:39 ` sgk at troutmask dot apl.washington.edu [this message]
2012-09-03 15:01 ` dominiq at lps dot ens.fr
2012-09-05 10:22 ` burnus at gcc dot gnu.org
2012-09-05 14:57 ` sgk at troutmask dot apl.washington.edu
2012-09-06  7:04 ` burnus at gcc dot gnu.org
2012-09-06  7:12 ` burnus at gcc dot gnu.org

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=bug-54463-4-gkDWYa4gqp@http.gcc.gnu.org/bugzilla/ \
    --to=gcc-bugzilla@gcc.gnu.org \
    --cc=gcc-bugs@gcc.gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).