public inbox for gcc-bugs@sourceware.org
help / color / mirror / Atom feed
* [Bug c/54486] New: Spurious printf format warning mentions nonexistent type 'sizetype'
@ 2012-09-05 0:28 Keith.S.Thompson at gmail dot com
2012-09-05 6:05 ` [Bug c/54486] " polacek at redhat dot com
` (7 more replies)
0 siblings, 8 replies; 9+ messages in thread
From: Keith.S.Thompson at gmail dot com @ 2012-09-05 0:28 UTC (permalink / raw)
To: gcc-bugs
http://gcc.gnu.org/bugzilla/show_bug.cgi?id=54486
Bug #: 54486
Summary: Spurious printf format warning mentions nonexistent
type 'sizetype'
Classification: Unclassified
Product: gcc
Version: 4.7.0
Status: UNCONFIRMED
Severity: normal
Priority: P3
Component: c
AssignedTo: unassigned@gcc.gnu.org
ReportedBy: Keith.S.Thompson@gmail.com
printf's "%zu" format expects an argument of type size_t. In the sample
program, the corresponding argument is of type size_t in all the printf calls
(the first because strspn() is defined to return a size_t result, and the
second because of the explicit cast, and similarly for the others).
For a call to strlen() or to a user-defined function func(), gcc rightly does
not complain.
For a call to strspn(), even with an explicit cast, gcc incorrectly complains
that the arguments is of type ‘sizetype’ -- which, as far as I can tell,
doesn't exist. (If I try to add a variable definition of type ‘sizetype’, I
get "error: unknown type name ‘sizetype’", and I can find no reference to
‘sizetype’ in any of my system's headers.)
I see nothing unusual in the declaration of strspn() in /usr/include/string.h.
$ uname -a
Linux kvetch 3.2.0-29-generic-pae #46-Ubuntu SMP Fri Jul 27 17:25:43 UTC 2012
i686 i686 i386 GNU/Linux
$ cat /etc/lsb-release
DISTRIB_ID=Ubuntu
DISTRIB_RELEASE=12.10
DISTRIB_CODENAME=quantal
DISTRIB_DESCRIPTION="Ubuntu quantal (development branch)"
$ gcc --version
gcc (Ubuntu/Linaro 4.7.0-7ubuntu3) 4.7.0
Copyright (C) 2012 Free Software Foundation, Inc.
This is free software; see the source for copying conditions. There is NO
warranty; not even for MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.
$ cat c.c
#include <string.h>
#include <stdio.h>
extern size_t func(void);
int main(void) {
printf("%zu\n", strspn("abc", "abcdefg")); /* line 7 */
printf("%zu\n", (size_t)strspn("abc", "abcdefg")); /* line 8 */
printf("%zu\n", strlen("foo"));
printf("%zu\n", (size_t)strlen("foo"));
printf("%zu\n", func());
printf("%zu\n", (size_t)func());
return 0;
}
$ gcc -c -std=c99 -pedantic c.c
c.c: In function ‘main’:
c.c:7:5: warning: format ‘%zu’ expects argument of type ‘size_t’, but argument
2 has type ‘sizetype’ [-Wformat]
c.c:8:5: warning: format ‘%zu’ expects argument of type ‘size_t’, but argument
2 has type ‘sizetype’ [-Wformat]
$
^ permalink raw reply [flat|nested] 9+ messages in thread
* [Bug c/54486] Spurious printf format warning mentions nonexistent type 'sizetype'
2012-09-05 0:28 [Bug c/54486] New: Spurious printf format warning mentions nonexistent type 'sizetype' Keith.S.Thompson at gmail dot com
@ 2012-09-05 6:05 ` polacek at redhat dot com
2012-09-05 6:13 ` pinskia at gcc dot gnu.org
` (6 subsequent siblings)
7 siblings, 0 replies; 9+ messages in thread
From: polacek at redhat dot com @ 2012-09-05 6:05 UTC (permalink / raw)
To: gcc-bugs
http://gcc.gnu.org/bugzilla/show_bug.cgi?id=54486
Marek Polacek <polacek at redhat dot com> changed:
What |Removed |Added
----------------------------------------------------------------------------
CC| |polacek at redhat dot com
--- Comment #1 from Marek Polacek <polacek at redhat dot com> 2012-09-05 06:04:58 UTC ---
It is also needed to use -Wall. Both arguments to strspn () are constants, so
in this case the __builtin_strspn () is used. You shouldn't see this warning
with -fno-builtin-strspn. Thus <string.h> is correct in this regard.
GCC 4.[1-5] are without warnings, with 4.6 I get:
/home/marek/rh/tests/pr54486.c: In function ‘main’:
/home/marek/rh/tests/pr54486.c:7:5: warning: format ‘%zu’ expects argument of
type ‘size_t’, but argument 2 has type ‘long unsigned int’ [-Wformat]
/home/marek/rh/tests/pr54486.c:8:5: warning: format ‘%zu’ expects argument of
type ‘size_t’, but argument 2 has type ‘long unsigned int’ [-Wformat]
with 4.7/trunk:
/home/marek/rh/tests/pr54486.c: In function ‘main’:
/home/marek/rh/tests/pr54486.c:7:5: warning: format ‘%zu’ expects argument of
type ‘size_t’, but argument 2 has type ‘sizetype’ [-Wformat]
/home/marek/rh/tests/pr54486.c:8:5: warning: format ‘%zu’ expects argument of
type ‘size_t’, but argument 2 has type ‘sizetype’ [-Wformat
^ permalink raw reply [flat|nested] 9+ messages in thread
* [Bug c/54486] Spurious printf format warning mentions nonexistent type 'sizetype'
2012-09-05 0:28 [Bug c/54486] New: Spurious printf format warning mentions nonexistent type 'sizetype' Keith.S.Thompson at gmail dot com
2012-09-05 6:05 ` [Bug c/54486] " polacek at redhat dot com
@ 2012-09-05 6:13 ` pinskia at gcc dot gnu.org
2012-09-05 6:18 ` jakub at gcc dot gnu.org
` (5 subsequent siblings)
7 siblings, 0 replies; 9+ messages in thread
From: pinskia at gcc dot gnu.org @ 2012-09-05 6:13 UTC (permalink / raw)
To: gcc-bugs
http://gcc.gnu.org/bugzilla/show_bug.cgi?id=54486
Andrew Pinski <pinskia at gcc dot gnu.org> changed:
What |Removed |Added
----------------------------------------------------------------------------
Keywords| |diagnostic
Status|UNCONFIRMED |NEW
Last reconfirmed| |2012-09-05
Ever Confirmed|0 |1
--- Comment #2 from Andrew Pinski <pinskia at gcc dot gnu.org> 2012-09-05 06:13:29 UTC ---
Confirmed.
Here is a shorter testcase that explicitly uses the builtins:
#include <stdio.h>
int main(void) {
__builtin_printf("%zu\n", __builtin_strspn("abc", "abcdefg")); /*
line 7 */
__builtin_printf("%zu\n", (size_t)__builtin_strspn("abc", "abcdefg")); /*
line 8 */
__builtin_printf("%zu\n", __builtin_strlen("abc")); /* line 9 */
return 0;
}
^ permalink raw reply [flat|nested] 9+ messages in thread
* [Bug c/54486] Spurious printf format warning mentions nonexistent type 'sizetype'
2012-09-05 0:28 [Bug c/54486] New: Spurious printf format warning mentions nonexistent type 'sizetype' Keith.S.Thompson at gmail dot com
2012-09-05 6:05 ` [Bug c/54486] " polacek at redhat dot com
2012-09-05 6:13 ` pinskia at gcc dot gnu.org
@ 2012-09-05 6:18 ` jakub at gcc dot gnu.org
2012-09-05 7:13 ` [Bug middle-end/54486] [4.6/4.7/4.8 Regression] " jakub at gcc dot gnu.org
` (4 subsequent siblings)
7 siblings, 0 replies; 9+ messages in thread
From: jakub at gcc dot gnu.org @ 2012-09-05 6:18 UTC (permalink / raw)
To: gcc-bugs
http://gcc.gnu.org/bugzilla/show_bug.cgi?id=54486
Jakub Jelinek <jakub at gcc dot gnu.org> changed:
What |Removed |Added
----------------------------------------------------------------------------
Status|NEW |ASSIGNED
CC| |jakub at gcc dot gnu.org
AssignedTo|unassigned at gcc dot |jakub at gcc dot gnu.org
|gnu.org |
Target Milestone|--- |4.8.0
^ permalink raw reply [flat|nested] 9+ messages in thread
* [Bug middle-end/54486] [4.6/4.7/4.8 Regression] Spurious printf format warning mentions nonexistent type 'sizetype'
2012-09-05 0:28 [Bug c/54486] New: Spurious printf format warning mentions nonexistent type 'sizetype' Keith.S.Thompson at gmail dot com
` (2 preceding siblings ...)
2012-09-05 6:18 ` jakub at gcc dot gnu.org
@ 2012-09-05 7:13 ` jakub at gcc dot gnu.org
2012-09-05 16:28 ` jakub at gcc dot gnu.org
` (3 subsequent siblings)
7 siblings, 0 replies; 9+ messages in thread
From: jakub at gcc dot gnu.org @ 2012-09-05 7:13 UTC (permalink / raw)
To: gcc-bugs
http://gcc.gnu.org/bugzilla/show_bug.cgi?id=54486
Jakub Jelinek <jakub at gcc dot gnu.org> changed:
What |Removed |Added
----------------------------------------------------------------------------
Component|c |middle-end
Target Milestone|4.8.0 |4.6.4
Summary|Spurious printf format |[4.6/4.7/4.8 Regression]
|warning mentions |Spurious printf format
|nonexistent type 'sizetype' |warning mentions
| |nonexistent type 'sizetype'
--- Comment #3 from Jakub Jelinek <jakub at gcc dot gnu.org> 2012-09-05 07:12:53 UTC ---
Likely caused by http://gcc.gnu.org/viewcvs?view=revision&revision=163994
(too lazy to narrow it down from r163926 - r164000 range).
^ permalink raw reply [flat|nested] 9+ messages in thread
* [Bug middle-end/54486] [4.6/4.7/4.8 Regression] Spurious printf format warning mentions nonexistent type 'sizetype'
2012-09-05 0:28 [Bug c/54486] New: Spurious printf format warning mentions nonexistent type 'sizetype' Keith.S.Thompson at gmail dot com
` (3 preceding siblings ...)
2012-09-05 7:13 ` [Bug middle-end/54486] [4.6/4.7/4.8 Regression] " jakub at gcc dot gnu.org
@ 2012-09-05 16:28 ` jakub at gcc dot gnu.org
2012-09-05 16:30 ` jakub at gcc dot gnu.org
` (2 subsequent siblings)
7 siblings, 0 replies; 9+ messages in thread
From: jakub at gcc dot gnu.org @ 2012-09-05 16:28 UTC (permalink / raw)
To: gcc-bugs
http://gcc.gnu.org/bugzilla/show_bug.cgi?id=54486
--- Comment #4 from Jakub Jelinek <jakub at gcc dot gnu.org> 2012-09-05 16:28:27 UTC ---
Author: jakub
Date: Wed Sep 5 16:27:55 2012
New Revision: 190986
URL: http://gcc.gnu.org/viewcvs?root=gcc&view=rev&rev=190986
Log:
PR middle-end/54486
* builtins.c (fold_builtin_strspn, fold_builtin_strcspn): Use
build_int_cst with size_type_node instead of size_int.
* c-c++-common/pr54486.c: New test.
Added:
trunk/gcc/testsuite/c-c++-common/pr54486.c
Modified:
trunk/gcc/ChangeLog
trunk/gcc/builtins.c
trunk/gcc/testsuite/ChangeLog
^ permalink raw reply [flat|nested] 9+ messages in thread
* [Bug middle-end/54486] [4.6/4.7/4.8 Regression] Spurious printf format warning mentions nonexistent type 'sizetype'
2012-09-05 0:28 [Bug c/54486] New: Spurious printf format warning mentions nonexistent type 'sizetype' Keith.S.Thompson at gmail dot com
` (4 preceding siblings ...)
2012-09-05 16:28 ` jakub at gcc dot gnu.org
@ 2012-09-05 16:30 ` jakub at gcc dot gnu.org
2012-09-07 10:50 ` [Bug middle-end/54486] [4.6 " rguenth at gcc dot gnu.org
2013-04-03 18:19 ` jakub at gcc dot gnu.org
7 siblings, 0 replies; 9+ messages in thread
From: jakub at gcc dot gnu.org @ 2012-09-05 16:30 UTC (permalink / raw)
To: gcc-bugs
http://gcc.gnu.org/bugzilla/show_bug.cgi?id=54486
--- Comment #5 from Jakub Jelinek <jakub at gcc dot gnu.org> 2012-09-05 16:29:49 UTC ---
Author: jakub
Date: Wed Sep 5 16:29:42 2012
New Revision: 190987
URL: http://gcc.gnu.org/viewcvs?root=gcc&view=rev&rev=190987
Log:
PR middle-end/54486
* builtins.c (fold_builtin_strspn, fold_builtin_strcspn): Use
build_int_cst with size_type_node instead of size_int.
* c-c++-common/pr54486.c: New test.
Added:
branches/gcc-4_7-branch/gcc/testsuite/c-c++-common/pr54486.c
Modified:
branches/gcc-4_7-branch/gcc/ChangeLog
branches/gcc-4_7-branch/gcc/builtins.c
branches/gcc-4_7-branch/gcc/testsuite/ChangeLog
^ permalink raw reply [flat|nested] 9+ messages in thread
* [Bug middle-end/54486] [4.6 Regression] Spurious printf format warning mentions nonexistent type 'sizetype'
2012-09-05 0:28 [Bug c/54486] New: Spurious printf format warning mentions nonexistent type 'sizetype' Keith.S.Thompson at gmail dot com
` (5 preceding siblings ...)
2012-09-05 16:30 ` jakub at gcc dot gnu.org
@ 2012-09-07 10:50 ` rguenth at gcc dot gnu.org
2013-04-03 18:19 ` jakub at gcc dot gnu.org
7 siblings, 0 replies; 9+ messages in thread
From: rguenth at gcc dot gnu.org @ 2012-09-07 10:50 UTC (permalink / raw)
To: gcc-bugs
http://gcc.gnu.org/bugzilla/show_bug.cgi?id=54486
Richard Guenther <rguenth at gcc dot gnu.org> changed:
What |Removed |Added
----------------------------------------------------------------------------
Priority|P3 |P2
Summary|[4.6/4.7/4.8 Regression] |[4.6 Regression] Spurious
|Spurious printf format |printf format warning
|warning mentions |mentions nonexistent type
|nonexistent type 'sizetype' |'sizetype'
^ permalink raw reply [flat|nested] 9+ messages in thread
* [Bug middle-end/54486] [4.6 Regression] Spurious printf format warning mentions nonexistent type 'sizetype'
2012-09-05 0:28 [Bug c/54486] New: Spurious printf format warning mentions nonexistent type 'sizetype' Keith.S.Thompson at gmail dot com
` (6 preceding siblings ...)
2012-09-07 10:50 ` [Bug middle-end/54486] [4.6 " rguenth at gcc dot gnu.org
@ 2013-04-03 18:19 ` jakub at gcc dot gnu.org
7 siblings, 0 replies; 9+ messages in thread
From: jakub at gcc dot gnu.org @ 2013-04-03 18:19 UTC (permalink / raw)
To: gcc-bugs
http://gcc.gnu.org/bugzilla/show_bug.cgi?id=54486
Jakub Jelinek <jakub at gcc dot gnu.org> changed:
What |Removed |Added
----------------------------------------------------------------------------
Status|ASSIGNED |RESOLVED
Resolution| |FIXED
--- Comment #6 from Jakub Jelinek <jakub at gcc dot gnu.org> 2013-04-03 18:18:54 UTC ---
Author: jakub
Date: Wed Apr 3 17:57:32 2013
New Revision: 197444
URL: http://gcc.gnu.org/viewcvs?rev=197444&root=gcc&view=rev
Log:
Backported from mainline
2012-09-05 Jakub Jelinek <jakub@redhat.com>
PR middle-end/54486
* builtins.c (fold_builtin_strspn, fold_builtin_strcspn): Use
build_int_cst with size_type_node instead of size_int.
* c-c++-common/pr54486.c: New test.
Added:
branches/gcc-4_6-branch/gcc/testsuite/c-c++-common/pr54486.c
Modified:
branches/gcc-4_6-branch/gcc/ChangeLog
branches/gcc-4_6-branch/gcc/builtins.c
branches/gcc-4_6-branch/gcc/testsuite/ChangeLog
^ permalink raw reply [flat|nested] 9+ messages in thread
end of thread, other threads:[~2013-04-03 18:19 UTC | newest]
Thread overview: 9+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2012-09-05 0:28 [Bug c/54486] New: Spurious printf format warning mentions nonexistent type 'sizetype' Keith.S.Thompson at gmail dot com
2012-09-05 6:05 ` [Bug c/54486] " polacek at redhat dot com
2012-09-05 6:13 ` pinskia at gcc dot gnu.org
2012-09-05 6:18 ` jakub at gcc dot gnu.org
2012-09-05 7:13 ` [Bug middle-end/54486] [4.6/4.7/4.8 Regression] " jakub at gcc dot gnu.org
2012-09-05 16:28 ` jakub at gcc dot gnu.org
2012-09-05 16:30 ` jakub at gcc dot gnu.org
2012-09-07 10:50 ` [Bug middle-end/54486] [4.6 " rguenth at gcc dot gnu.org
2013-04-03 18:19 ` jakub at gcc dot gnu.org
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).