public inbox for gcc-bugs@sourceware.org help / color / mirror / Atom feed
From: "rguenth at gcc dot gnu.org" <gcc-bugzilla@gcc.gnu.org> To: gcc-bugs@gcc.gnu.org Subject: [Bug middle-end/54493] -fguess-branch-probability takes ages Date: Wed, 12 Sep 2012 14:38:00 -0000 [thread overview] Message-ID: <bug-54493-4-v8Z0Wedb7A@http.gcc.gnu.org/bugzilla/> (raw) In-Reply-To: <bug-54493-4@http.gcc.gnu.org/bugzilla/> http://gcc.gnu.org/bugzilla/show_bug.cgi?id=54493 --- Comment #2 from Richard Guenther <rguenth at gcc dot gnu.org> 2012-09-12 14:37:51 UTC --- Something like Index: gcc/predict.c =================================================================== --- gcc/predict.c (revision 191222) +++ gcc/predict.c (working copy) @@ -525,8 +525,9 @@ void gimple_predict_edge (edge e, enum br_predictor predictor, int probability) { gcc_assert (profile_status != PROFILE_GUESSED); - if ((e->src != ENTRY_BLOCK_PTR && EDGE_COUNT (e->src->succs) > 1) - && flag_guess_branch_prob && optimize) + if (flag_guess_branch_prob && optimize + && (e->src != ENTRY_BLOCK_PTR && EDGE_COUNT (e->src->succs) > 1) + && !gimple_predicted_by_p (e->src, predictor)) { struct edge_prediction *i = XNEW (struct edge_prediction); void **preds = pointer_map_insert (bb_predictions, e->src); of course that doesn't try to merge the predictors probability nor the edge it is for. Why are the predictors stored per block and not per edge? Another approach would be to fix this special case: && gimple_code (last) == GIMPLE_RETURN) { edge e1; edge_iterator ei1; if (single_succ_p (bb)) { FOR_EACH_EDGE (e1, ei1, bb->preds) if (!predicted_by_p (e1->src, PRED_NULL_RETURN) && !predicted_by_p (e1->src, PRED_CONST_RETURN) && !predicted_by_p (e1->src, PRED_NEGATIVE_RETURN)) predict_edge_def (e1, PRED_TREE_EARLY_RETURN, NOT_TAKEN); which ends up adding all those (bogus?!) predications to the entry block. Simplified we have foo (int a, int b, int c) { int d; <bb 2>: switch (a_2(D)) <default: <L10>, case 10: <L0>, ... <L0>: d_5 = a_2(D) + b_4(D); goto <bb 13> (<L10>); ... <L9>: d_14 = a_2(D) + b_4(D); # d_1 = PHI <d_3(D)(2), d_5(3), d_6(4), d_7(5), d_8(6), d_9(7), d_10(8), d_11(9), d_12(10), d_13(11), d_14(12)> <L10>: return d_1; and we are adding the loads of !PRED_TREE_EARLY_RETURN to bb 2. Thus as we are only adding PRED_TREE_EARLY_RETURN at this point we can also do @@ -2113,13 +2113,15 @@ tree_estimate_probability_bb (basic_bloc FOR_EACH_EDGE (e1, ei1, bb->preds) if (!predicted_by_p (e1->src, PRED_NULL_RETURN) && !predicted_by_p (e1->src, PRED_CONST_RETURN) - && !predicted_by_p (e1->src, PRED_NEGATIVE_RETURN)) + && !predicted_by_p (e1->src, PRED_NEGATIVE_RETURN) + && !predicted_by_p (e1->src, PRED_TREE_EARLY_RETURN)) predict_edge_def (e1, PRED_TREE_EARLY_RETURN, NOT_TAKEN); } else if (!predicted_by_p (e->src, PRED_NULL_RETURN) && !predicted_by_p (e->src, PRED_CONST_RETURN) - && !predicted_by_p (e->src, PRED_NEGATIVE_RETURN)) + && !predicted_by_p (e->src, PRED_NEGATIVE_RETURN) + && !predicted_by_p (e->src, PRED_TREE_EARLY_RETURN)) predict_edge_def (e, PRED_TREE_EARLY_RETURN, NOT_TAKEN); } (those predicted_by_p sequences are also inefficient as they repeat the linear walk ...) Honza?
prev parent reply other threads:[~2012-09-12 14:38 UTC|newest] Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top 2012-09-05 13:31 [Bug middle-end/54493] New: " rguenth at gcc dot gnu.org 2012-09-12 14:19 ` [Bug middle-end/54493] " rguenth at gcc dot gnu.org 2012-09-12 14:38 ` rguenth at gcc dot gnu.org [this message]
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=bug-54493-4-v8Z0Wedb7A@http.gcc.gnu.org/bugzilla/ \ --to=gcc-bugzilla@gcc.gnu.org \ --cc=gcc-bugs@gcc.gnu.org \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).