[Bug c++/54575] New: ICE with std::vector::insert and -std=c++11

[Bug c++/54575] New: ICE with std::vector::insert and -std=c++11

[bangerth at gmail dot com]

http://gcc.gnu.org/bugzilla/show_bug.cgi?id=54575

             Bug #: 54575
           Summary: ICE with std::vector::insert and -std=c++11
    Classification: Unclassified
           Product: gcc
           Version: 4.8.0
            Status: UNCONFIRMED
          Severity: normal
          Priority: P3
         Component: c++
        AssignedTo: unassigned@gcc.gnu.org
        ReportedBy: bangerth@gmail.com


The following currently produces an ICE when using -std=c++11:
......................
#include <vector>

template <class DH>
void
foo()
{
  std::vector<unsigned int> local_dof_indices;
  std::vector<unsigned int> subdomain_indices;

  subdomain_indices.insert(subdomain_indices.end(),
               local_dof_indices.begin(),
               local_dof_indices.end());
}
......................


>>>> /home/bangerth/bin/gcc-mainline/bin/gcc -v                             
Using built-in specs.
COLLECT_GCC=/home/bangerth/bin/gcc-mainline/bin/gcc
COLLECT_LTO_WRAPPER=/home/bangerth/bin/gcc-mainline/lib/gcc/x86_64-unknown-linux-gnu/4.8.0/lto-wrapper
Target: x86_64-unknown-linux-gnu
Configured with: ../mainline/configure --prefix=/home/bangerth/bin/gcc-mainline
--enable-languages=c,c++ --disable-multilib
Thread model: posix
gcc version 4.8.0 20120913 (experimental) [trunk revision 183295] (GCC) 


>>>> /home/bangerth/bin/gcc-mainline/bin/gcc -c -std=c++11 x.cc
In file included from
/home/bangerth/bin/gcc-mainline/include/c++/4.8.0/vector:65:0,
                 from dofs/dof_tools.cc:1:
/home/bangerth/bin/gcc-mainline/include/c++/4.8.0/bits/stl_vector.h: In
function 'void foo()':
/home/bangerth/bin/gcc-mainline/include/c++/4.8.0/bits/stl_vector.h:1042:9:
internal compiler error: tree check: expected class 'type', have 'exceptional'
(error_mark) in strip_typedefs, at cp/tree.c:1215
         typename = std::_RequireInputIter<_InputIterator>>
         ^
Please submit a full bug report,
with preprocessed source if appropriate.
See <http://gcc.gnu.org/bugs.html> for instructions.

[Bug c++/54575] ICE with std::vector::insert and -std=c++11

[rguenth at gcc dot gnu.org]

http://gcc.gnu.org/bugzilla/show_bug.cgi?id=54575

--- Comment #1 from Richard Guenther <rguenth at gcc dot gnu.org> 2012-09-14 08:34:52 UTC ---
I can't reproduce this.

[Bug c++/54575] [4.8 Regression] ICE with std::vector::insert and -std=c++11

[paolo.carlini at oracle dot com]

http://gcc.gnu.org/bugzilla/show_bug.cgi?id=54575

Paolo Carlini <paolo.carlini at oracle dot com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|UNCONFIRMED                 |NEW
   Last reconfirmed|                            |2012-09-14
   Target Milestone|---                         |4.8.0
            Summary|ICE with                    |[4.8 Regression] ICE with
                   |std::vector::insert and     |std::vector::insert and
                   |-std=c++11                  |-std=c++11
     Ever Confirmed|0                           |1

--- Comment #2 from Paolo Carlini <paolo.carlini at oracle dot com> 2012-09-14 10:11:43 UTC ---
I can. It seems a serious regression. Hopefully, it's just that in a SFINAE
context we aren't smoothly handling an error_mark_node.

[Bug c++/54575] [4.8 Regression] ICE with std::vector::insert and -std=c++11

[paolo.carlini at oracle dot com]

http://gcc.gnu.org/bugzilla/show_bug.cgi?id=54575

Paolo Carlini <paolo.carlini at oracle dot com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |ASSIGNED
         AssignedTo|unassigned at gcc dot       |paolo.carlini at oracle dot
                   |gnu.org                     |com

--- Comment #3 from Paolo Carlini <paolo.carlini at oracle dot com> 2012-09-14 10:42:58 UTC ---
I have a patch, the issue seems indeed simple as I suspected.

Wolfgang, can you figure out a simpler testcase? (Generally I don't like
including the whole <vector> in the C++ testsuite, it increases the coupling
between testsuite and library)

[Bug c++/54575] [4.8 Regression] ICE with std::vector::insert and -std=c++11

[bangerth at gmail dot com]

http://gcc.gnu.org/bugzilla/show_bug.cgi?id=54575

--- Comment #4 from Wolfgang Bangerth <bangerth at gmail dot com> 2012-09-14 11:48:56 UTC ---
Would this do? ;-)
......................................
template<typename _From, typename _To>
struct is_convertible { static const bool value = true; };

template<bool> struct enable_if       { };
template<>     struct enable_if<true> { typedef int type; };

template<typename _InIter>
using _RequireInputIter
= typename enable_if<is_convertible<_InIter,bool>::value>::type;

template<typename _Tp> struct X {
    template<typename _InputIterator,
         typename = _RequireInputIter<_InputIterator>>
      void insert(_InputIterator) {}
};

template<typename> void foo() {
  X<int> subdomain_indices;
  subdomain_indices.insert(0);
}
.........................................


gcc -std=c++11 -c x.ii
x.ii: In function 'void foo()':
x.ii:13:7: internal compiler error: tree check: expected class 'type', have
'exceptional' (error_mark) in strip_typedefs, at cp/tree.c:1215
       typename = _RequireInputIter<_InputIterator>>
       ^
Please submit a full bug report,
with preprocessed source if appropriate.
See <http://gcc.gnu.org/bugs.html> for instructions.

[Bug c++/54575] [4.8 Regression] ICE with std::vector::insert and -std=c++11

[paolo.carlini at oracle dot com]

http://gcc.gnu.org/bugzilla/show_bug.cgi?id=54575

--- Comment #5 from Paolo Carlini <paolo.carlini at oracle dot com> 2012-09-14 12:00:21 UTC ---
Fantastic, thanks!

[Bug c++/54575] [4.8 Regression] ICE with std::vector::insert and -std=c++11

[paolo.carlini at oracle dot com]

http://gcc.gnu.org/bugzilla/show_bug.cgi?id=54575

Paolo Carlini <paolo.carlini at oracle dot com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |hjl at gcc dot gnu.org

--- Comment #6 from Paolo Carlini <paolo.carlini at oracle dot com> 2012-09-14 16:26:32 UTC ---
H.J. can you find when we started ICEing for the testcase in Comment 4?

[Bug c++/54575] [4.8 Regression] ICE with std::vector::insert and -std=c++11

[hjl.tools at gmail dot com]

http://gcc.gnu.org/bugzilla/show_bug.cgi?id=54575

--- Comment #7 from H.J. Lu <hjl.tools at gmail dot com> 2012-09-14 17:38:07 UTC ---
(In reply to comment #4)
> Would this do? ;-)
> ......................................
> template<typename _From, typename _To>
> struct is_convertible { static const bool value = true; };
> 
> template<bool> struct enable_if       { };
> template<>     struct enable_if<true> { typedef int type; };
> 
> template<typename _InIter>
> using _RequireInputIter
> = typename enable_if<is_convertible<_InIter,bool>::value>::type;
> 
> template<typename _Tp> struct X {
>     template<typename _InputIterator,
>          typename = _RequireInputIter<_InputIterator>>
>       void insert(_InputIterator) {}
> };
> 
> template<typename> void foo() {
>   X<int> subdomain_indices;
>   subdomain_indices.insert(0);
> }
> .........................................
> 
> 
> gcc -std=c++11 -c x.ii
> x.ii: In function 'void foo()':
> x.ii:13:7: internal compiler error: tree check: expected class 'type', have
> 'exceptional' (error_mark) in strip_typedefs, at cp/tree.c:1215
>        typename = _RequireInputIter<_InputIterator>>
>        ^
> Please submit a full bug report,
> with preprocessed source if appropriate.
> See <http://gcc.gnu.org/bugs.html> for instructions.

This is caused by revision 190830:

http://gcc.gnu.org/ml/gcc-cvs/2012-08/msg00808.html

[Bug c++/54575] [4.8 Regression] ICE with std::vector::insert and -std=c++11

[paolo.carlini at oracle dot com]

http://gcc.gnu.org/bugzilla/show_bug.cgi?id=54575

--- Comment #8 from Paolo Carlini <paolo.carlini at oracle dot com> 2012-09-14 18:22:17 UTC ---
Ah, thanks!

[Bug c++/54575] [4.8 Regression] ICE with std::vector::insert and -std=c++11

[paolo.carlini at oracle dot com]

http://gcc.gnu.org/bugzilla/show_bug.cgi?id=54575

Paolo Carlini <paolo.carlini at oracle dot com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|ASSIGNED                    |NEW

[Bug c++/54575] [4.8 Regression] ICE with std::vector::insert and -std=c++11

[paolo.carlini at oracle dot com]

http://gcc.gnu.org/bugzilla/show_bug.cgi?id=54575

Paolo Carlini <paolo.carlini at oracle dot com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Priority|P3                          |P2

--- Comment #9 from Paolo Carlini <paolo.carlini at oracle dot com> 2012-09-17 15:28:38 UTC ---
Jason, I'm bumping this to P2, it affects pretty badly the library too.

[Bug c++/54575] [4.8 Regression] ICE with std::vector::insert and -std=c++11

[jason at gcc dot gnu.org]

http://gcc.gnu.org/bugzilla/show_bug.cgi?id=54575

--- Comment #10 from Jason Merrill <jason at gcc dot gnu.org> 2012-09-18 03:47:39 UTC ---
Author: jason
Date: Tue Sep 18 03:47:35 2012
New Revision: 191412

URL: http://gcc.gnu.org/viewcvs?root=gcc&view=rev&rev=191412
Log:
    PR c++/54575
    * pt.c (instantiate_alias_template): New.
    (tsubst): Use it.
    (push_access_scope): Allow TYPE_DECL.

Added:
    trunk/gcc/testsuite/g++.dg/cpp0x/alias-decl-21.C
    trunk/gcc/testsuite/g++.dg/cpp0x/alias-decl-22.C
Modified:
    trunk/gcc/cp/ChangeLog
    trunk/gcc/cp/pt.c
    trunk/gcc/testsuite/ChangeLog

[Bug c++/54575] [4.8 Regression] ICE with std::vector::insert and -std=c++11

[paolo.carlini at oracle dot com]

http://gcc.gnu.org/bugzilla/show_bug.cgi?id=54575

--- Comment #11 from Paolo Carlini <paolo.carlini at oracle dot com> 2012-09-18 09:41:29 UTC ---
Thanks a lot Jason!

[Bug c++/54575] [4.8 Regression] ICE with std::vector::insert and -std=c++11

[paolo.carlini at oracle dot com]

http://gcc.gnu.org/bugzilla/show_bug.cgi?id=54575

Paolo Carlini <paolo.carlini at oracle dot com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |RESOLVED
         Resolution|                            |FIXED

--- Comment #12 from Paolo Carlini <paolo.carlini at oracle dot com> 2012-09-18 13:54:51 UTC ---
I guess we can close this, I double checked that the original testcase is also
fine now.

[Bug c++/54575] [4.8 Regression] ICE with std::vector::insert and -std=c++11

[bangerth at gmail dot com]

http://gcc.gnu.org/bugzilla/show_bug.cgi?id=54575

--- Comment #13 from Wolfgang Bangerth <bangerth at gmail dot com> 2012-09-18 15:32:17 UTC ---
Thanks, all, for the quick turnaround. This works again, not just on the
testcase but on the entire code base.

Best
 W.