public inbox for gcc-bugs@sourceware.org
help / color / mirror / Atom feed
* [Bug target/54746] New: config/s390/s390.c:1583: possible missing break in switch ?
@ 2012-09-29 10:35 dcb314 at hotmail dot com
2012-09-29 10:43 ` [Bug target/54746] " paolo.carlini at oracle dot com
` (3 more replies)
0 siblings, 4 replies; 5+ messages in thread
From: dcb314 at hotmail dot com @ 2012-09-29 10:35 UTC (permalink / raw)
To: gcc-bugs
http://gcc.gnu.org/bugzilla/show_bug.cgi?id=54746
Bug #: 54746
Summary: config/s390/s390.c:1583: possible missing break in
switch ?
Classification: Unclassified
Product: gcc
Version: 4.8.0
Status: UNCONFIRMED
Severity: normal
Priority: P3
Component: target
AssignedTo: unassigned@gcc.gnu.org
ReportedBy: dcb314@hotmail.com
Target: s390
break;
case PROCESSOR_2097_Z10:
s390_cost = &z10_cost;
case PROCESSOR_2817_Z196:
s390_cost = &z196_cost;
Looks like a missing break to me. The wrong cost gets picked up.
^ permalink raw reply [flat|nested] 5+ messages in thread
* [Bug target/54746] config/s390/s390.c:1583: possible missing break in switch ?
2012-09-29 10:35 [Bug target/54746] New: config/s390/s390.c:1583: possible missing break in switch ? dcb314 at hotmail dot com
@ 2012-09-29 10:43 ` paolo.carlini at oracle dot com
2012-10-01 7:23 ` krebbel at gcc dot gnu.org
` (2 subsequent siblings)
3 siblings, 0 replies; 5+ messages in thread
From: paolo.carlini at oracle dot com @ 2012-09-29 10:43 UTC (permalink / raw)
To: gcc-bugs
http://gcc.gnu.org/bugzilla/show_bug.cgi?id=54746
Paolo Carlini <paolo.carlini at oracle dot com> changed:
What |Removed |Added
----------------------------------------------------------------------------
CC| |krebbel at gcc dot gnu.org
--- Comment #1 from Paolo Carlini <paolo.carlini at oracle dot com> 2012-09-29 10:43:35 UTC ---
Andreas, can you have a look?
^ permalink raw reply [flat|nested] 5+ messages in thread
* [Bug target/54746] config/s390/s390.c:1583: possible missing break in switch ?
2012-09-29 10:35 [Bug target/54746] New: config/s390/s390.c:1583: possible missing break in switch ? dcb314 at hotmail dot com
2012-09-29 10:43 ` [Bug target/54746] " paolo.carlini at oracle dot com
@ 2012-10-01 7:23 ` krebbel at gcc dot gnu.org
2012-10-01 7:33 ` krebbel at gcc dot gnu.org
2012-10-01 7:51 ` krebbel at gcc dot gnu.org
3 siblings, 0 replies; 5+ messages in thread
From: krebbel at gcc dot gnu.org @ 2012-10-01 7:23 UTC (permalink / raw)
To: gcc-bugs
http://gcc.gnu.org/bugzilla/show_bug.cgi?id=54746
--- Comment #2 from Andreas Krebbel <krebbel at gcc dot gnu.org> 2012-10-01 07:23:21 UTC ---
Author: krebbel
Date: Mon Oct 1 07:23:12 2012
New Revision: 191885
URL: http://gcc.gnu.org/viewcvs?root=gcc&view=rev&rev=191885
Log:
2012-10-01 Andreas Krebbel <Andreas.Krebbel@de.ibm.com>
PR target/54746
* config/s390/s390.c (s390_option_override): Add missing break.
Modified:
trunk/gcc/ChangeLog
trunk/gcc/config/s390/s390.c
^ permalink raw reply [flat|nested] 5+ messages in thread
* [Bug target/54746] config/s390/s390.c:1583: possible missing break in switch ?
2012-09-29 10:35 [Bug target/54746] New: config/s390/s390.c:1583: possible missing break in switch ? dcb314 at hotmail dot com
2012-09-29 10:43 ` [Bug target/54746] " paolo.carlini at oracle dot com
2012-10-01 7:23 ` krebbel at gcc dot gnu.org
@ 2012-10-01 7:33 ` krebbel at gcc dot gnu.org
2012-10-01 7:51 ` krebbel at gcc dot gnu.org
3 siblings, 0 replies; 5+ messages in thread
From: krebbel at gcc dot gnu.org @ 2012-10-01 7:33 UTC (permalink / raw)
To: gcc-bugs
http://gcc.gnu.org/bugzilla/show_bug.cgi?id=54746
--- Comment #3 from Andreas Krebbel <krebbel at gcc dot gnu.org> 2012-10-01 07:33:17 UTC ---
(In reply to comment #0)
> break;
> case PROCESSOR_2097_Z10:
> s390_cost = &z10_cost;
> case PROCESSOR_2817_Z196:
> s390_cost = &z196_cost;
>
> Looks like a missing break to me. The wrong cost gets picked up.
You are right. I'll commit a patch to mainline and 4.7 branch. Thanks!
^ permalink raw reply [flat|nested] 5+ messages in thread
* [Bug target/54746] config/s390/s390.c:1583: possible missing break in switch ?
2012-09-29 10:35 [Bug target/54746] New: config/s390/s390.c:1583: possible missing break in switch ? dcb314 at hotmail dot com
` (2 preceding siblings ...)
2012-10-01 7:33 ` krebbel at gcc dot gnu.org
@ 2012-10-01 7:51 ` krebbel at gcc dot gnu.org
3 siblings, 0 replies; 5+ messages in thread
From: krebbel at gcc dot gnu.org @ 2012-10-01 7:51 UTC (permalink / raw)
To: gcc-bugs
http://gcc.gnu.org/bugzilla/show_bug.cgi?id=54746
--- Comment #4 from Andreas Krebbel <krebbel at gcc dot gnu.org> 2012-10-01 07:51:26 UTC ---
Author: krebbel
Date: Mon Oct 1 07:51:20 2012
New Revision: 191888
URL: http://gcc.gnu.org/viewcvs?root=gcc&view=rev&rev=191888
Log:
2012-10-01 Andreas Krebbel <Andreas.Krebbel@de.ibm.com>
PR target/54746
* config/s390/s390.c (s390_option_override): Add missing break.
Modified:
branches/gcc-4_7-branch/gcc/ChangeLog
branches/gcc-4_7-branch/gcc/config/s390/s390.c
^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2012-10-01 7:51 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2012-09-29 10:35 [Bug target/54746] New: config/s390/s390.c:1583: possible missing break in switch ? dcb314 at hotmail dot com
2012-09-29 10:43 ` [Bug target/54746] " paolo.carlini at oracle dot com
2012-10-01 7:23 ` krebbel at gcc dot gnu.org
2012-10-01 7:33 ` krebbel at gcc dot gnu.org
2012-10-01 7:51 ` krebbel at gcc dot gnu.org
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).