public inbox for gcc-bugs@sourceware.org help / color / mirror / Atom feed
* [Bug target/54747] New: config/bfin/bfin.c:2721: possible missing break ?
@ 2012-09-29 11:12 dcb314 at hotmail dot com
2012-11-04 3:56 ` [Bug target/54747] " joel at gcc dot gnu.org
` (2 more replies)
0 siblings, 3 replies; 4+ messages in thread
From: dcb314 at hotmail dot com @ 2012-09-29 11:12 UTC (permalink / raw)
To: gcc-bugs
http://gcc.gnu.org/bugzilla/show_bug.cgi?id=54747
Bug #: 54747
Summary: config/bfin/bfin.c:2721: possible missing break ?
Classification: Unclassified
Product: gcc
Version: 4.8.0
Status: UNCONFIRMED
Severity: normal
Priority: P3
Component: target
AssignedTo: unassigned@gcc.gnu.org
ReportedBy: dcb314@hotmail.com
Target: bfin
case POST_DEC:
if (LEGITIMATE_MODE_FOR_AUTOINC_P (mode)
&& REG_P (XEXP (x, 0))
&& bfin_valid_reg_p (REGNO (XEXP (x, 0)), strict, mode, POST_INC))
return true;
case PRE_DEC:
Looking at the rest of the switch statement, it might be true
that there is a missing break.
If not, suggest document the fallthrough with a comment.
^ permalink raw reply [flat|nested] 4+ messages in thread* [Bug target/54747] config/bfin/bfin.c:2721: possible missing break ? 2012-09-29 11:12 [Bug target/54747] New: config/bfin/bfin.c:2721: possible missing break ? dcb314 at hotmail dot com @ 2012-11-04 3:56 ` joel at gcc dot gnu.org 2012-11-05 11:29 ` bernds at gcc dot gnu.org 2015-01-02 22:52 ` joel at gcc dot gnu.org 2 siblings, 0 replies; 4+ messages in thread From: joel at gcc dot gnu.org @ 2012-11-04 3:56 UTC (permalink / raw) To: gcc-bugs http://gcc.gnu.org/bugzilla/show_bug.cgi?id=54747 Joel Sherrill <joel at gcc dot gnu.org> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |joel at gcc dot gnu.org --- Comment #1 from Joel Sherrill <joel at gcc dot gnu.org> 2012-11-04 03:56:33 UTC --- Bernd... does the git bisect help you narrow down a fix? ^ permalink raw reply [flat|nested] 4+ messages in thread
* [Bug target/54747] config/bfin/bfin.c:2721: possible missing break ? 2012-09-29 11:12 [Bug target/54747] New: config/bfin/bfin.c:2721: possible missing break ? dcb314 at hotmail dot com 2012-11-04 3:56 ` [Bug target/54747] " joel at gcc dot gnu.org @ 2012-11-05 11:29 ` bernds at gcc dot gnu.org 2015-01-02 22:52 ` joel at gcc dot gnu.org 2 siblings, 0 replies; 4+ messages in thread From: bernds at gcc dot gnu.org @ 2012-11-05 11:29 UTC (permalink / raw) To: gcc-bugs http://gcc.gnu.org/bugzilla/show_bug.cgi?id=54747 Bernd Schmidt <bernds at gcc dot gnu.org> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |bernds at gcc dot gnu.org --- Comment #2 from Bernd Schmidt <bernds at gcc dot gnu.org> 2012-11-05 11:29:37 UTC --- Looks like the code works correctly either way. You could add a break if you feel like it. ^ permalink raw reply [flat|nested] 4+ messages in thread
* [Bug target/54747] config/bfin/bfin.c:2721: possible missing break ? 2012-09-29 11:12 [Bug target/54747] New: config/bfin/bfin.c:2721: possible missing break ? dcb314 at hotmail dot com 2012-11-04 3:56 ` [Bug target/54747] " joel at gcc dot gnu.org 2012-11-05 11:29 ` bernds at gcc dot gnu.org @ 2015-01-02 22:52 ` joel at gcc dot gnu.org 2 siblings, 0 replies; 4+ messages in thread From: joel at gcc dot gnu.org @ 2015-01-02 22:52 UTC (permalink / raw) To: gcc-bugs https://gcc.gnu.org/bugzilla/show_bug.cgi?id=54747 Joel Sherrill <joel at gcc dot gnu.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|UNCONFIRMED |RESOLVED Resolution|--- |INVALID --- Comment #3 from Joel Sherrill <joel at gcc dot gnu.org> --- Closing. Bernd was OK with the code and I don't see anyway to check this again. ^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2015-01-02 22:52 UTC | newest] Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed) -- links below jump to the message on this page -- 2012-09-29 11:12 [Bug target/54747] New: config/bfin/bfin.c:2721: possible missing break ? dcb314 at hotmail dot com 2012-11-04 3:56 ` [Bug target/54747] " joel at gcc dot gnu.org 2012-11-05 11:29 ` bernds at gcc dot gnu.org 2015-01-02 22:52 ` joel at gcc dot gnu.org
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).