[Bug fortran/54870] New: gfortran.dg/array_constructor_4.f90 FAILs

[Bug fortran/54870] New: gfortran.dg/array_constructor_4.f90 FAILs

[ro at gcc dot gnu.org]

http://gcc.gnu.org/bugzilla/show_bug.cgi?id=54870

             Bug #: 54870
           Summary: gfortran.dg/array_constructor_4.f90 FAILs
    Classification: Unclassified
           Product: gcc
           Version: 4.8.0
            Status: UNCONFIRMED
          Severity: normal
          Priority: P3
         Component: fortran
        AssignedTo: unassigned@gcc.gnu.org
        ReportedBy: ro@gcc.gnu.org
                CC: ebotcazou@gcc.gnu.org
              Host: sparc*-*-solaris2*
            Target: sparc*-*-solaris2*
             Build: sparc*-*-solaris2*


Since about 20120608, the gfortran.dg/array_constructor_4.f90 FAILS on
Solaris/SPARC with -m64:

FAIL: gfortran.dg/array_constructor_4.f90  -O3 -fomit-frame-pointer  execution
test
FAIL: gfortran.dg/array_constructor_4.f90  -O3 -fomit-frame-pointer
-funroll-loops  execution test
FAIL: gfortran.dg/array_constructor_4.f90  -O3 -fomit-frame-pointer
-funroll-all-loops -finline-functions  execution test
FAIL: gfortran.dg/array_constructor_4.f90  -O3 -g  execution test

The -O3 -g test aborts like this:


Backtrace for this error:
#0  fffffffb5c822bcb
[New Thread 1 (LWP 1)]

Program received signal SIGABRT, Aborted.
[Switching to Thread 1 (LWP 1)]
0xffffffff7eee7620 in _lwp_kill () from /lib/64/libc.so.1
(gdb) where
#0  0xffffffff7eee7620 in _lwp_kill () from /lib/64/libc.so.1
#1  0xffffffff7ee94624 in raise () from /lib/64/libc.so.1
#2  0xffffffff7ee6a10c in abort () from /lib/64/libc.so.1
#3  0xfffffffb5c824ed8 in _gfortrani_sys_abort ()
    at /vol/gcc/src/hg/trunk/local/libgfortran/runtime/error.c:173
#4  0xfffffffb5c8e3178 in _gfortran_abort ()
    at /vol/gcc/src/hg/trunk/local/libgfortran/intrinsics/abort.c:33
#5  0x000000010000107c in MAIN__ ()
    at
/vol/gcc/src/hg/trunk/local/gcc/testsuite/gfortran.dg/array_constructor_4.f90:9
#6  main (argc=<optimized out>, argv=0xffffffff7ffff538)
    at
/vol/gcc/src/hg/trunk/local/gcc/testsuite/gfortran.dg/array_constructor_4.f90:23
#7  0x0000000100000d04 in _start ()

[Bug fortran/54870] gfortran.dg/array_constructor_4.f90 FAILs

[ro at gcc dot gnu.org]

http://gcc.gnu.org/bugzilla/show_bug.cgi?id=54870

Rainer Orth <ro at gcc dot gnu.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
   Target Milestone|---                         |4.8.0

[Bug fortran/54870] gfortran.dg/array_constructor_4.f90 FAILs

[ro at gcc dot gnu.org]

http://gcc.gnu.org/bugzilla/show_bug.cgi?id=54870

Rainer Orth <ro at gcc dot gnu.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |richard.guenther at gmail
                   |                            |dot com

--- Comment #1 from Rainer Orth <ro at gcc dot gnu.org> 2012-10-12 08:39:33 UTC ---
A reghunt revealed that this was caused by this patch:

2012-06-06  Richard Guenther  <rguenther@suse.de>

        PR tree-optimization/53081
        * tree-data-ref.h (adjacent_store_dr_p): Rename to ...
        (adjacent_dr_p): ... this and make it work for reads, too.
        * tree-loop-distribution.c (enum partition_kind): Add PKIND_MEMCPY.
        (struct partition_s): Change main_stmt to main_dr, add
        secondary_dr member.
[...]

It already occurs with a non-bootstrap gfortran and is independent of the
libgfortran.so (built with our without the patch) used.

I'm attaching the assembler outputs.

  Rainer

[Bug fortran/54870] [4.8 regression] gfortran.dg/array_constructor_4.f90 FAILs

[ebotcazou at gcc dot gnu.org]

http://gcc.gnu.org/bugzilla/show_bug.cgi?id=54870

Eric Botcazou <ebotcazou at gcc dot gnu.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|UNCONFIRMED                 |NEW
   Last reconfirmed|                            |2012-10-13
            Summary|gfortran.dg/array_construct |[4.8 regression]
                   |or_4.f90 FAILs              |gfortran.dg/array_construct
                   |                            |or_4.f90 FAILs
     Ever Confirmed|0                           |1

--- Comment #2 from Eric Botcazou <ebotcazou at gcc dot gnu.org> 2012-10-13 21:33:44 UTC ---
Confirmed.

[Bug fortran/54870] [4.8 regression] gfortran.dg/array_constructor_4.f90 FAILs

[ebotcazou at gcc dot gnu.org]

http://gcc.gnu.org/bugzilla/show_bug.cgi?id=54870

Eric Botcazou <ebotcazou at gcc dot gnu.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |ASSIGNED
         AssignedTo|unassigned at gcc dot       |ebotcazou at gcc dot
                   |gnu.org                     |gnu.org

--- Comment #3 from Eric Botcazou <ebotcazou at gcc dot gnu.org> 2012-10-13 22:06:12 UTC ---
Created attachment 28443
  --> http://gcc.gnu.org/bugzilla/attachment.cgi?id=28443
Reduced testcase

The dse2 dump reads:

dse: local deletions = 0, global deletions = 1, spill deletions = 0
starting the processing of deferred insns
deleting insn with uid = 25.
ending the processing of deferred insns

but the memory location stored to

(insn 25 27 154 2 (set (mem/c:SI (plus:DI (reg/f:DI 30 %fp)
                (const_int 2039 [0x7f7])) [6 A.1+16 S4 A64])
        (reg:SI 1 %g1 [136])) array_constructor_4.f90:4 61 {*movsi_insn}
     (nil))

is read by a subsequent call to memcpy.

[Bug rtl-optimization/54870] [4.8 regression] gfortran.dg/array_constructor_4.f90 FAILs

[ebotcazou at gcc dot gnu.org]

http://gcc.gnu.org/bugzilla/show_bug.cgi?id=54870

--- Comment #4 from Eric Botcazou <ebotcazou at gcc dot gnu.org> 2012-10-16 22:49:13 UTC ---
Author: ebotcazou
Date: Tue Oct 16 22:49:07 2012
New Revision: 192517

URL: http://gcc.gnu.org/viewcvs?root=gcc&view=rev&rev=192517
Log:
    PR rtl-optimization/54870
    * tree.h (TREE_ADDRESSABLE): Document special usage on SSA_NAME.
    * cfgexpand.c (update_alias_info_with_stack_vars ): Set it on the
    SSA_NAME pointer that points to a partition if there is at least
    one variable with it set in the partition.
    * dse.c (local_variable_can_escape): New predicate.
    (can_escape): Call it.
    * gimplify.c (mark_addressable): If this is a partitioned decl, also
    mark the SSA_NAME pointer that points to a partition.

Modified:
    trunk/gcc/cfgexpand.c
    trunk/gcc/dse.c
    trunk/gcc/gimplify.c
    trunk/gcc/tree.h

[Bug rtl-optimization/54870] [4.8 regression] gfortran.dg/array_constructor_4.f90 FAILs

[ebotcazou at gcc dot gnu.org]

http://gcc.gnu.org/bugzilla/show_bug.cgi?id=54870

--- Comment #5 from Eric Botcazou <ebotcazou at gcc dot gnu.org> 2012-10-16 23:18:11 UTC ---
Author: ebotcazou
Date: Tue Oct 16 23:18:08 2012
New Revision: 192518

URL: http://gcc.gnu.org/viewcvs?root=gcc&view=rev&rev=192518
Log:
    PR rtl-optimization/54870
    * tree.h (TREE_ADDRESSABLE): Document special usage on SSA_NAME.
    * cfgexpand.c (update_alias_info_with_stack_vars ): Set it on the
    SSA_NAME pointer that points to a partition if there is at least
    one variable with it set in the partition.
    * dse.c (local_variable_can_escape): New predicate.
    (can_escape): Call it.
    * gimplify.c (mark_addressable): If this is a partitioned decl, also
    mark the SSA_NAME pointer that points to a partition.

Modified:
    branches/gcc-4_7-branch/gcc/ChangeLog
    branches/gcc-4_7-branch/gcc/cfgexpand.c
    branches/gcc-4_7-branch/gcc/dse.c
    branches/gcc-4_7-branch/gcc/gimplify.c
    branches/gcc-4_7-branch/gcc/tree.h

[Bug rtl-optimization/54870] [4.8 regression] gfortran.dg/array_constructor_4.f90 FAILs

[ebotcazou at gcc dot gnu.org]

http://gcc.gnu.org/bugzilla/show_bug.cgi?id=54870

Eric Botcazou <ebotcazou at gcc dot gnu.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|ASSIGNED                    |RESOLVED
         Resolution|                            |FIXED

--- Comment #6 from Eric Botcazou <ebotcazou at gcc dot gnu.org> 2012-10-16 23:19:31 UTC ---
This should pass now.