public inbox for gcc-bugs@sourceware.org help / color / mirror / Atom feed
From: "jakub at gcc dot gnu.org" <gcc-bugzilla@gcc.gnu.org> To: gcc-bugs@gcc.gnu.org Subject: [Bug tree-optimization/54900] write introduction incorrect wrt the C11 memory model (2) Date: Thu, 11 Oct 2012 11:59:00 -0000 [thread overview] Message-ID: <bug-54900-4-t9xbP1uvtR@http.gcc.gnu.org/bugzilla/> (raw) In-Reply-To: <bug-54900-4@http.gcc.gnu.org/bugzilla/> http://gcc.gnu.org/bugzilla/show_bug.cgi?id=54900 Jakub Jelinek <jakub at gcc dot gnu.org> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |aldyh at gcc dot gnu.org, | |jakub at gcc dot gnu.org --- Comment #1 from Jakub Jelinek <jakub at gcc dot gnu.org> 2012-10-11 11:59:14 UTC --- This is ifcvt.c in action. This is the if (!set_b && MEM_P (orig_x)) case where we already do some checks: if (noce_mem_write_may_trap_or_fault_p (orig_x)) return FALSE; and if (!noce_can_store_speculate_p (test_bb, orig_x)) return FALSE; I'd say noce_can_store_speculate_p is buggy, it uses if (memory_modified_in_insn_p (mem, insn)) return true; but memory_modified_in_insn_p is pessimistic, it doesn't tell whether mem is surely set, but whether it might be set. I guess it would need to use note_stores that would just do rtx_equal_p on the addresses or similarly prove it is surely (and unconditionally) written. So even note_stores might not be the right thing, perhaps just looking at single_set SET_DEST. And avoiding inline asm, that doesn't have to store unconditionally.
next prev parent reply other threads:[~2012-10-11 11:59 UTC|newest] Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top 2012-10-11 11:07 [Bug tree-optimization/54900] New: " francesco.zappa.nardelli at gmail dot com 2012-10-11 11:59 ` jakub at gcc dot gnu.org [this message] 2012-10-14 12:51 ` [Bug tree-optimization/54900] " aldyh at gcc dot gnu.org 2012-10-14 12:51 ` aldyh at gcc dot gnu.org 2012-10-17 20:59 ` [Bug rtl-optimization/54900] " aldyh at gcc dot gnu.org 2012-10-18 13:39 ` francesco.zappa.nardelli at gmail dot com 2012-10-18 23:46 ` aldyh at gcc dot gnu.org 2013-05-29 20:24 ` steven at gcc dot gnu.org
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=bug-54900-4-t9xbP1uvtR@http.gcc.gnu.org/bugzilla/ \ --to=gcc-bugzilla@gcc.gnu.org \ --cc=gcc-bugs@gcc.gnu.org \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).