public inbox for gcc-bugs@sourceware.org
help / color / mirror / Atom feed
From: "hubicka at ucw dot cz" <gcc-bugzilla@gcc.gnu.org>
To: gcc-bugs@gcc.gnu.org
Subject: [Bug tree-optimization/54965] [4.6 Regression] sorry, unimplemented: inlining failed in call to 'foo': function not considered for inlining
Date: Tue, 23 Oct 2012 14:03:00 -0000 [thread overview]
Message-ID: <bug-54965-4-X9iiZXeEsW@http.gcc.gnu.org/bugzilla/> (raw)
In-Reply-To: <bug-54965-4@http.gcc.gnu.org/bugzilla/>
http://gcc.gnu.org/bugzilla/show_bug.cgi?id=54965
--- Comment #7 from Jan Hubicka <hubicka at ucw dot cz> 2012-10-23 14:03:06 UTC ---
> you are using indirect function calls here, GCC in 4.6 is not smart enough
> to transform them to direct calls before inlining. Inlining of
> always-inline indirect function calls is not going to work reliably.
>
> Don't use always-inline or don't use indirect function calls to always-inline
> functions. It makes always-inline function calls survive until IPA inlining
> where we seem to honor limits even though we say we should disregard them.
Yes, we do. It was actually your change to move always_inline function handling
out of the small functions inlining into inline_always_inline_functions. The
motivation was that when done as part of small function inlining other inlining
may close cycles in the callgraph making always_inline inlining impossible.
In the presence of indirect calls, I do not think it is possible to honnor
always_inline completely because of the ordering issue.
Honza
next prev parent reply other threads:[~2012-10-23 14:03 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-10-18 1:50 [Bug tree-optimization/54965] New: [4.6] " siarhei.siamashka at gmail dot com
2012-10-18 1:56 ` [Bug tree-optimization/54965] " siarhei.siamashka at gmail dot com
2012-10-18 9:52 ` [Bug tree-optimization/54965] [4.6 Regression] " rguenth at gcc dot gnu.org
2012-10-18 10:48 ` siarhei.siamashka at gmail dot com
2012-10-18 10:59 ` rguenther at suse dot de
2012-10-19 0:17 ` siarhei.siamashka at gmail dot com
2012-10-19 8:36 ` rguenth at gcc dot gnu.org
2012-10-23 14:03 ` hubicka at ucw dot cz [this message]
2013-04-12 16:18 ` jakub at gcc dot gnu.org
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=bug-54965-4-X9iiZXeEsW@http.gcc.gnu.org/bugzilla/ \
--to=gcc-bugzilla@gcc.gnu.org \
--cc=gcc-bugs@gcc.gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).