public inbox for gcc-bugs@sourceware.org
help / color / mirror / Atom feed
From: "hubicka at ucw dot cz" <gcc-bugzilla@gcc.gnu.org>
To: gcc-bugs@gcc.gnu.org
Subject: [Bug lto/54966] Does LTO requires a larger inline-unit-growth?
Date: Tue, 23 Oct 2012 13:59:00 -0000	[thread overview]
Message-ID: <bug-54966-4-ixhuBlnsDV@http.gcc.gnu.org/bugzilla/> (raw)
In-Reply-To: <bug-54966-4@http.gcc.gnu.org/bugzilla/>


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=54966

--- Comment #4 from Jan Hubicka <hubicka at ucw dot cz> 2012-10-23 13:59:38 UTC ---
> I'm not sure how we count the initial unit size, given that when not using
> LTO not merged comdats are probably counted here, so overall they add up
> while the initial LTO unit size may be considerably smaller than the sum
> of the non-LTO unit sizes.

I do not realy see problem here.   We simply count size of the unit by summing
all the functions in the callgraph prior inlining (after merging). So in the
case of LTO we count COMDATs once and if they are unused by non-LTO we promote
them to static and get better inlining due removing offline copies (that we are
acccounting as inline decisions are made).  In the case of non-LTO we count
COMDAT in every unit that has the COMDAT used + we have heuristic predicting
that most likely the COMDAT will be eliminated in the other units, too, if it
is eliminated in the current unit.  So we inline them almost as aggressively as
statics, but not quite.

What kind of problem are you looking into?
Honza


  parent reply	other threads:[~2012-10-23 13:59 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-10-18  6:29 [Bug lto/54966] New: " vincenzo.innocente at cern dot ch
2012-10-18  7:47 ` [Bug lto/54966] " dominiq at lps dot ens.fr
2012-10-18  9:44 ` rguenth at gcc dot gnu.org
2012-10-19  8:37 ` vincenzo.innocente at cern dot ch
2012-10-23 13:59 ` hubicka at ucw dot cz [this message]
2012-10-23 14:02 ` rguenther at suse dot de
2012-10-23 14:13 ` hubicka at ucw dot cz
2012-11-08 16:44 ` hubicka at gcc dot gnu.org
2012-11-09  6:39 ` vincenzo.innocente at cern dot ch
2012-11-09  6:52 ` vincenzo.innocente at cern dot ch
2012-11-09 11:33 ` vincenzo.innocente at cern dot ch
2012-11-12 13:20 ` vincenzo.innocente at cern dot ch

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=bug-54966-4-ixhuBlnsDV@http.gcc.gnu.org/bugzilla/ \
    --to=gcc-bugzilla@gcc.gnu.org \
    --cc=gcc-bugs@gcc.gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).