public inbox for gcc-bugs@sourceware.org
help / color / mirror / Atom feed
* [Bug target/55019] New: Incorrectly use live argument register to save high register in thumb1 prologue
@ 2012-10-22  9:43 terry.guo at arm dot com
  2012-10-22  9:53 ` [Bug target/55019] " rearnsha at gcc dot gnu.org
                   ` (8 more replies)
  0 siblings, 9 replies; 10+ messages in thread
From: terry.guo at arm dot com @ 2012-10-22  9:43 UTC (permalink / raw)
  To: gcc-bugs


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=55019

             Bug #: 55019
           Summary: Incorrectly use live argument register to save high
                    register in thumb1 prologue
    Classification: Unclassified
           Product: gcc
           Version: 4.7.3
            Status: UNCONFIRMED
          Severity: normal
          Priority: P3
         Component: target
        AssignedTo: unassigned@gcc.gnu.org
        ReportedBy: terry.guo@arm.com


When run 4.7 regression test on cortex-m0 with options "-mthumb -mcpu=cortex-m0
-O1 -funroll-loops", case gcc.dg/torture/builtin-complex-1.c will fail due to
the corruption of argument register as shown in below:

compare:
    push    {r3, r4, r6, lr}
    mov    r6, fp
    mov    r4, sl
    mov    r3, r9    <<-- r3 is clobbered
    push    {r3, r4, r6}
    mov    r6, r8
    push    {r6}
    mov    fp, r0
    mov    sl, r1
    mov    r9, r2
    mov    r8, r3  <<-- wrong value is used


^ permalink raw reply	[flat|nested] 10+ messages in thread
* [Bug target/55019] Incorrectly use live argument register to save high register in thumb1 prologue
  2012-10-22  9:43 [Bug target/55019] New: Incorrectly use live argument register to save high register in thumb1 prologue terry.guo at arm dot com
@ 2012-10-22  9:53 ` rearnsha at gcc dot gnu.org
  2012-10-22 11:23 ` terry.guo at arm dot com
                   ` (7 subsequent siblings)
  8 siblings, 0 replies; 10+ messages in thread
From: rearnsha at gcc dot gnu.org @ 2012-10-22  9:53 UTC (permalink / raw)
  To: gcc-bugs


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=55019

Richard Earnshaw <rearnsha at gcc dot gnu.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Target|                            |arm-eabi
             Status|UNCONFIRMED                 |WAITING
   Last reconfirmed|                            |2012-10-22
     Ever Confirmed|0                           |1

--- Comment #1 from Richard Earnshaw <rearnsha at gcc dot gnu.org> 2012-10-22 09:53:40 UTC ---
Testcase?


^ permalink raw reply	[flat|nested] 10+ messages in thread
* [Bug target/55019] Incorrectly use live argument register to save high register in thumb1 prologue
  2012-10-22  9:43 [Bug target/55019] New: Incorrectly use live argument register to save high register in thumb1 prologue terry.guo at arm dot com
  2012-10-22  9:53 ` [Bug target/55019] " rearnsha at gcc dot gnu.org
@ 2012-10-22 11:23 ` terry.guo at arm dot com
  2012-10-22 13:52 ` rearnsha at gcc dot gnu.org
                   ` (6 subsequent siblings)
  8 siblings, 0 replies; 10+ messages in thread
From: terry.guo at arm dot com @ 2012-10-22 11:23 UTC (permalink / raw)
  To: gcc-bugs


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=55019

--- Comment #2 from Terry Guo <terry.guo at arm dot com> 2012-10-22 11:23:16 UTC ---
Created attachment 28505
  --> http://gcc.gnu.org/bugzilla/attachment.cgi?id=28505
case to reproduce this bug


^ permalink raw reply	[flat|nested] 10+ messages in thread
* [Bug target/55019] Incorrectly use live argument register to save high register in thumb1 prologue
  2012-10-22  9:43 [Bug target/55019] New: Incorrectly use live argument register to save high register in thumb1 prologue terry.guo at arm dot com
  2012-10-22  9:53 ` [Bug target/55019] " rearnsha at gcc dot gnu.org
  2012-10-22 11:23 ` terry.guo at arm dot com
@ 2012-10-22 13:52 ` rearnsha at gcc dot gnu.org
  2012-10-23  3:49 ` xguo at gcc dot gnu.org
                   ` (5 subsequent siblings)
  8 siblings, 0 replies; 10+ messages in thread
From: rearnsha at gcc dot gnu.org @ 2012-10-22 13:52 UTC (permalink / raw)
  To: gcc-bugs


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=55019

Richard Earnshaw <rearnsha at gcc dot gnu.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|WAITING                     |NEW


^ permalink raw reply	[flat|nested] 10+ messages in thread
* [Bug target/55019] Incorrectly use live argument register to save high register in thumb1 prologue
  2012-10-22  9:43 [Bug target/55019] New: Incorrectly use live argument register to save high register in thumb1 prologue terry.guo at arm dot com
                   ` (2 preceding siblings ...)
  2012-10-22 13:52 ` rearnsha at gcc dot gnu.org
@ 2012-10-23  3:49 ` xguo at gcc dot gnu.org
  2012-10-23  3:55 ` terry.guo at arm dot com
                   ` (4 subsequent siblings)
  8 siblings, 0 replies; 10+ messages in thread
From: xguo at gcc dot gnu.org @ 2012-10-23  3:49 UTC (permalink / raw)
  To: gcc-bugs


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=55019

--- Comment #3 from xuepeng guo <xguo at gcc dot gnu.org> 2012-10-23 03:49:21 UTC ---
Author: xguo
Date: Tue Oct 23 03:49:17 2012
New Revision: 192703

URL: http://gcc.gnu.org/viewcvs?root=gcc&view=rev&rev=192703
Log:
    gcc/
    PR target/55019
    * config/arm/arm.c (thumb1_expand_prologue): Don't push high regs with
    live argument regs.

    gcc/testsuite/
    PR target/55019
    * gcc.dg/pr55019.c: New.

Added:
    trunk/gcc/testsuite/gcc.dg/pr55019.c
Modified:
    trunk/gcc/ChangeLog
    trunk/gcc/config/arm/arm.c
    trunk/gcc/testsuite/ChangeLog


^ permalink raw reply	[flat|nested] 10+ messages in thread
* [Bug target/55019] Incorrectly use live argument register to save high register in thumb1 prologue
  2012-10-22  9:43 [Bug target/55019] New: Incorrectly use live argument register to save high register in thumb1 prologue terry.guo at arm dot com
                   ` (3 preceding siblings ...)
  2012-10-23  3:49 ` xguo at gcc dot gnu.org
@ 2012-10-23  3:55 ` terry.guo at arm dot com
  2012-10-23 10:08 ` mikpe at it dot uu.se
                   ` (3 subsequent siblings)
  8 siblings, 0 replies; 10+ messages in thread
From: terry.guo at arm dot com @ 2012-10-23  3:55 UTC (permalink / raw)
  To: gcc-bugs


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=55019

Terry Guo <terry.guo at arm dot com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |RESOLVED
         Resolution|                            |FIXED

--- Comment #4 from Terry Guo <terry.guo at arm dot com> 2012-10-23 03:55:25 UTC ---
This issue is fixed.


^ permalink raw reply	[flat|nested] 10+ messages in thread
* [Bug target/55019] Incorrectly use live argument register to save high register in thumb1 prologue
  2012-10-22  9:43 [Bug target/55019] New: Incorrectly use live argument register to save high register in thumb1 prologue terry.guo at arm dot com
                   ` (4 preceding siblings ...)
  2012-10-23  3:55 ` terry.guo at arm dot com
@ 2012-10-23 10:08 ` mikpe at it dot uu.se
  2012-10-23 10:13 ` terry.guo at arm dot com
                   ` (2 subsequent siblings)
  8 siblings, 0 replies; 10+ messages in thread
From: mikpe at it dot uu.se @ 2012-10-23 10:08 UTC (permalink / raw)
  To: gcc-bugs


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=55019

Mikael Pettersson <mikpe at it dot uu.se> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |mikpe at it dot uu.se

--- Comment #5 from Mikael Pettersson <mikpe at it dot uu.se> 2012-10-23 10:08:04 UTC ---
(In reply to comment #4)
> This issue is fixed.

The problem was reported for 4.7 branch, the fix was OK:d for 4.7 and trunk,
but so far only applied to trunk.


^ permalink raw reply	[flat|nested] 10+ messages in thread
* [Bug target/55019] Incorrectly use live argument register to save high register in thumb1 prologue
  2012-10-22  9:43 [Bug target/55019] New: Incorrectly use live argument register to save high register in thumb1 prologue terry.guo at arm dot com
                   ` (5 preceding siblings ...)
  2012-10-23 10:08 ` mikpe at it dot uu.se
@ 2012-10-23 10:13 ` terry.guo at arm dot com
  2012-10-23 11:53 ` mikpe at it dot uu.se
  2012-10-26  2:12 ` xguo at gcc dot gnu.org
  8 siblings, 0 replies; 10+ messages in thread
From: terry.guo at arm dot com @ 2012-10-23 10:13 UTC (permalink / raw)
  To: gcc-bugs


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=55019

--- Comment #6 from Terry Guo <terry.guo at arm dot com> 2012-10-23 10:13:08 UTC ---
(In reply to comment #5)
> (In reply to comment #4)
> > This issue is fixed.
> 
> The problem was reported for 4.7 branch, the fix was OK:d for 4.7 and trunk,
> but so far only applied to trunk.

I plan to wait for some time to see if there is any unforeseen issue in trunk.
And then will do back port.


^ permalink raw reply	[flat|nested] 10+ messages in thread
* [Bug target/55019] Incorrectly use live argument register to save high register in thumb1 prologue
  2012-10-22  9:43 [Bug target/55019] New: Incorrectly use live argument register to save high register in thumb1 prologue terry.guo at arm dot com
                   ` (6 preceding siblings ...)
  2012-10-23 10:13 ` terry.guo at arm dot com
@ 2012-10-23 11:53 ` mikpe at it dot uu.se
  2012-10-26  2:12 ` xguo at gcc dot gnu.org
  8 siblings, 0 replies; 10+ messages in thread
From: mikpe at it dot uu.se @ 2012-10-23 11:53 UTC (permalink / raw)
  To: gcc-bugs


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=55019

--- Comment #7 from Mikael Pettersson <mikpe at it dot uu.se> 2012-10-23 11:53:07 UTC ---
(In reply to comment #6)
> (In reply to comment #5)
> > (In reply to comment #4)
> > > This issue is fixed.
> > 
> > The problem was reported for 4.7 branch, the fix was OK:d for 4.7 and trunk,
> > but so far only applied to trunk.
> 
> I plan to wait for some time to see if there is any unforeseen issue in trunk.
> And then will do back port.

Ok, thanks.  It wasn't obvious that you were going to do that since you had
closed the bug as fixed.


^ permalink raw reply	[flat|nested] 10+ messages in thread
* [Bug target/55019] Incorrectly use live argument register to save high register in thumb1 prologue
  2012-10-22  9:43 [Bug target/55019] New: Incorrectly use live argument register to save high register in thumb1 prologue terry.guo at arm dot com
                   ` (7 preceding siblings ...)
  2012-10-23 11:53 ` mikpe at it dot uu.se
@ 2012-10-26  2:12 ` xguo at gcc dot gnu.org
  8 siblings, 0 replies; 10+ messages in thread
From: xguo at gcc dot gnu.org @ 2012-10-26  2:12 UTC (permalink / raw)
  To: gcc-bugs


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=55019

--- Comment #8 from xuepeng guo <xguo at gcc dot gnu.org> 2012-10-26 02:12:17 UTC ---
Author: xguo
Date: Fri Oct 26 02:12:06 2012
New Revision: 192831

URL: http://gcc.gnu.org/viewcvs?root=gcc&view=rev&rev=192831
Log:
    gcc/ChangeLog
    Backport from mainline
    2012-10-23  Terry Guo  <terry.guo@arm.com>

    PR target/55019
    * config/arm/arm.c (thumb1_expand_prologue): Don't push high regs with
    live argument regs.

    gcc/testsuite/ChangeLog
    Backport from mainline
    2012-10-23  Terry Guo  <terry.guo@arm.com>

    PR target/55019
    * gcc.dg/pr55019.c: New.

Added:
    branches/gcc-4_7-branch/gcc/testsuite/gcc.dg/pr55019.c
Modified:
    branches/gcc-4_7-branch/gcc/ChangeLog
    branches/gcc-4_7-branch/gcc/config/arm/arm.c
    branches/gcc-4_7-branch/gcc/testsuite/ChangeLog


^ permalink raw reply	[flat|nested] 10+ messages in thread
end of thread, other threads:[~2012-10-26  2:12 UTC | newest]

Thread overview: 10+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2012-10-22  9:43 [Bug target/55019] New: Incorrectly use live argument register to save high register in thumb1 prologue terry.guo at arm dot com
2012-10-22  9:53 ` [Bug target/55019] " rearnsha at gcc dot gnu.org
2012-10-22 11:23 ` terry.guo at arm dot com
2012-10-22 13:52 ` rearnsha at gcc dot gnu.org
2012-10-23  3:49 ` xguo at gcc dot gnu.org
2012-10-23  3:55 ` terry.guo at arm dot com
2012-10-23 10:08 ` mikpe at it dot uu.se
2012-10-23 10:13 ` terry.guo at arm dot com
2012-10-23 11:53 ` mikpe at it dot uu.se
2012-10-26  2:12 ` xguo at gcc dot gnu.org

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).