public inbox for gcc-bugs@sourceware.org
help / color / mirror / Atom feed
From: "mans at mansr dot com" <gcc-bugzilla@gcc.gnu.org>
To: gcc-bugs@gcc.gnu.org
Subject: [Bug target/55026] New: [Multiple targets] Inefficient code with structs passed by value
Date: Mon, 22 Oct 2012 16:39:00 -0000	[thread overview]
Message-ID: <bug-55026-4@http.gcc.gnu.org/bugzilla/> (raw)


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=55026

             Bug #: 55026
           Summary: [Multiple targets] Inefficient code with structs
                    passed by value
    Classification: Unclassified
           Product: gcc
           Version: 4.8.0
            Status: UNCONFIRMED
          Severity: normal
          Priority: P3
         Component: target
        AssignedTo: unassigned@gcc.gnu.org
        ReportedBy: mans@mansr.com


Multiple targets (including ARM, HPPA, and MIPS) generate inefficient code in
functions taking struct arguments by value.  Consider this code:

struct foo {
    int a;
    int b;
};

int f(struct foo x)
{
    return x.a + x.b;
}

On ARM, this compiles to the following at -O3 optimisation:

f:
        @ args = 0, pretend = 0, frame = 8
        @ frame_needed = 0, uses_anonymous_args = 0
        @ link register save eliminated.
        sub     sp, sp, #8
        add     r3, sp, #8
        stmdb   r3, {r0, r1}
        ldmia   sp, {r0, r3}
        add     r0, r0, r3
        add     sp, sp, #8
        @ sp needed
        bx      lr

Note the entirely unnecessary (and inefficiently done to boot) storing and
loading of the argument registers to/from the stack.

The x86_64 and SH4 targets do not show this behaviour.


             reply	other threads:[~2012-10-22 16:39 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-10-22 16:39 mans at mansr dot com [this message]
2012-10-22 16:41 ` [Bug target/55026] " pinskia at gcc dot gnu.org
2012-10-22 19:08 ` [Bug target/55026] Useless stores generated for structures " ebotcazou at gcc dot gnu.org
2012-10-22 19:34 ` mans at mansr dot com
2012-10-22 19:38 ` mans at mansr dot com

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=bug-55026-4@http.gcc.gnu.org/bugzilla/ \
    --to=gcc-bugzilla@gcc.gnu.org \
    --cc=gcc-bugs@gcc.gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).