public inbox for gcc-bugs@sourceware.org
help / color / mirror / Atom feed
From: "hp at gcc dot gnu.org" <gcc-bugzilla@gcc.gnu.org>
To: gcc-bugs@gcc.gnu.org
Subject: [Bug middle-end/55030] [4.8 Regression]: gcc.c-torture/execute/builtins/memcpy-chk.c execution,  -Os (et al)
Date: Sun, 17 Feb 2013 00:33:00 -0000	[thread overview]
Message-ID: <bug-55030-4-9zhIGowFJH@http.gcc.gnu.org/bugzilla/> (raw)
In-Reply-To: <bug-55030-4@http.gcc.gnu.org/bugzilla/>


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=55030

--- Comment #12 from Hans-Peter Nilsson <hp at gcc dot gnu.org> 2013-02-17 00:33:17 UTC ---
(In reply to comment #10)
> I'm getting back to this because I think that we should reinstate the original
> patch, now that the blockage patch has been installed.

*wake-up reactions*

> I have run into the same issue as your original issue with a private port on
> the 4.7 branch: the clobber causes the restoring of the frame pointer to be
> deleted
>   http://gcc.gnu.org/ml/gcc-patches/2012-10/msg01172.html
> Later reload allocates a stack slot to a pseudo that is set before the setjmp
> and used after, but the frame pointer doesn't have a consistent value...

Yup, this far I remember.

> Clearly the frame pointer needs to be restored so the clobber is wrong.  It was
> there because the final blockage wasn't blocking enough, but the blockage patch
> is supposed to have fixed that.

I've lost track. What was "the original patch", what do you mean by "the
blockage patch" (that has been installed) and I'm pretty sure there were
several follow-up patches, so I can't say I'm confident about reverting
something from just this subset.  (To wit: if it's something that causes
volatile asms to again be treated different from (other) blockages, then that's
wrong, as a volatile asm is the default blockage.)

Can you please a candidate (reverting?) patch gcc-patches@ *and CC me* (I'm far
behind on reading gcc lists).


  parent reply	other threads:[~2013-02-17  0:33 UTC|newest]

Thread overview: 22+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-10-23  0:58 [Bug middle-end/55030] New: " hp at gcc dot gnu.org
2012-10-23  1:05 ` [Bug middle-end/55030] " hp at gcc dot gnu.org
2012-10-23  1:08 ` hp at gcc dot gnu.org
2012-10-23  1:09 ` hp at gcc dot gnu.org
2012-10-23  9:39 ` rguenth at gcc dot gnu.org
2012-11-12  4:37 ` hp at gcc dot gnu.org
2012-11-12  4:54 ` hp at gcc dot gnu.org
2012-11-26  3:22 ` hp at gcc dot gnu.org
2012-11-26  3:26 ` hp at gcc dot gnu.org
2012-11-27  7:41 ` krebbel at gcc dot gnu.org
2012-11-27 11:55 ` hp at gcc dot gnu.org
2012-11-27 23:16 ` hp at gcc dot gnu.org
2013-02-16  9:37 ` ebotcazou at gcc dot gnu.org
2013-02-16  9:44 ` ebotcazou at gcc dot gnu.org
2013-02-17  0:33 ` hp at gcc dot gnu.org [this message]
2013-02-18 10:48 ` ebotcazou at gcc dot gnu.org
2013-02-18 22:21 ` hp at gcc dot gnu.org
2013-02-19 11:32 ` ebotcazou at gcc dot gnu.org
2013-06-03  8:37 ` mikpe at it dot uu.se
2013-06-03 22:32 ` hp at gcc dot gnu.org
2013-06-08  7:50 ` ebotcazou at gcc dot gnu.org
2013-07-03 14:44 ` hp at gcc dot gnu.org

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=bug-55030-4-9zhIGowFJH@http.gcc.gnu.org/bugzilla/ \
    --to=gcc-bugzilla@gcc.gnu.org \
    --cc=gcc-bugs@gcc.gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).