public inbox for gcc-bugs@sourceware.org
help / color / mirror / Atom feed
From: "tejohnson at google dot com" <gcc-bugzilla@gcc.gnu.org>
To: gcc-bugs@gcc.gnu.org
Subject: [Bug bootstrap/55051] [4.8 Regression] profiledbootstrap failed
Date: Thu, 15 Nov 2012 06:44:00 -0000	[thread overview]
Message-ID: <bug-55051-4-WJdD4SQezc@http.gcc.gnu.org/bugzilla/> (raw)
In-Reply-To: <bug-55051-4@http.gcc.gnu.org/bugzilla/>


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=55051

--- Comment #23 from Teresa Johnson <tejohnson at google dot com> 2012-11-15 06:44:00 UTC ---
On Wed, Nov 14, 2012 at 5:17 PM, hubicka at gcc dot gnu.org
<gcc-bugzilla@gcc.gnu.org> wrote:
>
> http://gcc.gnu.org/bugzilla/show_bug.cgi?id=55051
>
> --- Comment #16 from Jan Hubicka <hubicka at gcc dot gnu.org> 2012-11-15 01:17:43 UTC ---
> Theresa: I am using gcc10 from compilation farm, but I think it is fairly
> universal problem.
> Also I think that gcc_assert should not be assert, but an user readable error
> about gcov file corruption.

I took a look at this some more this evening, printing out the values
being compared. Note that the modification I made to this code was to
ignore the histogram when comparing the gcov_ctr_summary, since the
order of update can affect the merged histogram values as they are
prorated. So essentially we are doing the same comparison here that we
did before the histogram was added.

I found that the gcov_ctr_summary fields being compared are identical
except for the sum_all, which is different, leading to the error
message. The number of counters, run_max and sum_max are the same. I'm
not sure how that can happen given that locking is on and the sum_all
should be the same regardless of the merging order.

Note though that this is not an assert. It just emits a message to
stderr. Do you think a better error message is appropriate? I'm not
sure the "some data files may have been removed" is an accurate
description of the issue. Perhaps something like "Profile data file
mismatch may indicate corrupt profile data"?

Teresa

>
> --
> Configure bugmail: http://gcc.gnu.org/bugzilla/userprefs.cgi?tab=email
> ------- You are receiving this mail because: -------
> You are on the CC list for the bug.



--
Teresa Johnson | Software Engineer | tejohnson@google.com | 408-460-2413


  parent reply	other threads:[~2012-11-15  6:44 UTC|newest]

Thread overview: 35+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-10-24 10:22 [Bug bootstrap/55051] New: " hjl.tools at gmail dot com
2012-10-24 10:22 ` [Bug bootstrap/55051] " hjl.tools at gmail dot com
2012-10-24 23:50 ` hjl.tools at gmail dot com
2012-10-25  0:49 ` hjl.tools at gmail dot com
2012-10-25  6:52 ` ubizjak at gmail dot com
2012-11-14 15:07 ` hjl.tools at gmail dot com
2012-11-14 15:09 ` hjl.tools at gmail dot com
2012-11-14 15:13 ` markus at trippelsdorf dot de
2012-11-14 15:35 ` hubicka at ucw dot cz
2012-11-14 20:48 ` markus at trippelsdorf dot de
2012-11-14 23:03 ` hubicka at gcc dot gnu.org
2012-11-15  0:07 ` hubicka at gcc dot gnu.org
2012-11-15  0:22 ` tejohnson at google dot com
2012-11-15  0:31 ` hjl.tools at gmail dot com
2012-11-15  1:03 ` hubicka at gcc dot gnu.org
2012-11-15  1:07 ` hubicka at gcc dot gnu.org
2012-11-15  1:10 ` hubicka at gcc dot gnu.org
2012-11-15  1:18 ` hubicka at gcc dot gnu.org
2012-11-15  1:29 ` tejohnson at google dot com
2012-11-15  1:34 ` tejohnson at google dot com
2012-11-15  1:42   ` Jan Hubicka
2012-11-15  1:43 ` hubicka at ucw dot cz
2012-11-15  1:53 ` tejohnson at google dot com
2012-11-15  2:02 ` hubicka at ucw dot cz
2012-11-15  2:46 ` tejohnson at google dot com
2012-11-15  6:44 ` tejohnson at google dot com [this message]
2012-11-15 10:56   ` Jan Hubicka
2012-11-15 10:57 ` hubicka at ucw dot cz
2012-11-15 14:34 ` tejohnson at google dot com
2012-11-15 22:42 ` tejohnson at google dot com
2012-11-16 17:42 ` hubicka at gcc dot gnu.org
2012-11-16 18:03 ` tejohnson at google dot com
2012-11-16 18:57 ` hubicka at ucw dot cz
2012-11-19  5:21 ` tejohnson at gcc dot gnu.org
2012-12-07 12:04 ` rguenth at gcc dot gnu.org

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=bug-55051-4-WJdD4SQezc@http.gcc.gnu.org/bugzilla/ \
    --to=gcc-bugzilla@gcc.gnu.org \
    --cc=gcc-bugs@gcc.gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).