public inbox for gcc-bugs@sourceware.org help / color / mirror / Atom feed
From: "tejohnson at google dot com" <gcc-bugzilla@gcc.gnu.org> To: gcc-bugs@gcc.gnu.org Subject: [Bug bootstrap/55051] [4.8 Regression] profiledbootstrap failed Date: Fri, 16 Nov 2012 18:03:00 -0000 [thread overview] Message-ID: <bug-55051-4-xT7v7Lc3fe@http.gcc.gnu.org/bugzilla/> (raw) In-Reply-To: <bug-55051-4@http.gcc.gnu.org/bugzilla/> http://gcc.gnu.org/bugzilla/show_bug.cgi?id=55051 --- Comment #28 from Teresa Johnson <tejohnson at google dot com> 2012-11-16 18:03:08 UTC --- On Fri, Nov 16, 2012 at 9:42 AM, hubicka at gcc dot gnu.org <gcc-bugzilla@gcc.gnu.org> wrote: > > http://gcc.gnu.org/bugzilla/show_bug.cgi?id=55051 > > --- Comment #27 from Jan Hubicka <hubicka at gcc dot gnu.org> 2012-11-16 17:42:26 UTC --- > /* Now merge each file. */ > for (gi_ptr = gcov_list; gi_ptr; gi_ptr = gi_ptr->next) > { > // Open existing gcda file for gi_ptr > // Find program summary corresponding to this executable -> save in prg > // Merge execution counts for each function > // Merge program summary > // - If this is the first merged file for this execution, > save merged summary in all_prg > // - Otherwise if #runs the same in prg and all_prg, > print error message if prg != all_prg. > // Write merged gcda > } > > Hmm, yes, it seems wrong. We can not expect all gcda files to have same number > of runs. We really need to process sum_all & friends locally for each file. > Only I suppose we can check if number of runs of the prg happens to match the > last merged file then sum_all should match. I'm confused - that is essentially what it is doing today (although comparing against the first merged file instead of the last merged file). It isn't expecting all the gcda files to have the same number of runs, but when they do it expects them to have the same sum_all. See the trace of updates I show below this pseudo code in the same email that shows why that is not working. > That would be nice consistency > check. If the bootstrap works with this change, consider the patch preapproved. I had sent a patch last night to simply rip out this check based on the analysis I had done, but I assume you are not talking about that. Thanks, Teresa > > -- > Configure bugmail: http://gcc.gnu.org/bugzilla/userprefs.cgi?tab=email > ------- You are receiving this mail because: ------- > You are on the CC list for the bug. -- Teresa Johnson | Software Engineer | tejohnson@google.com | 408-460-2413
next prev parent reply other threads:[~2012-11-16 18:03 UTC|newest] Thread overview: 35+ messages / expand[flat|nested] mbox.gz Atom feed top 2012-10-24 10:22 [Bug bootstrap/55051] New: " hjl.tools at gmail dot com 2012-10-24 10:22 ` [Bug bootstrap/55051] " hjl.tools at gmail dot com 2012-10-24 23:50 ` hjl.tools at gmail dot com 2012-10-25 0:49 ` hjl.tools at gmail dot com 2012-10-25 6:52 ` ubizjak at gmail dot com 2012-11-14 15:07 ` hjl.tools at gmail dot com 2012-11-14 15:09 ` hjl.tools at gmail dot com 2012-11-14 15:13 ` markus at trippelsdorf dot de 2012-11-14 15:35 ` hubicka at ucw dot cz 2012-11-14 20:48 ` markus at trippelsdorf dot de 2012-11-14 23:03 ` hubicka at gcc dot gnu.org 2012-11-15 0:07 ` hubicka at gcc dot gnu.org 2012-11-15 0:22 ` tejohnson at google dot com 2012-11-15 0:31 ` hjl.tools at gmail dot com 2012-11-15 1:03 ` hubicka at gcc dot gnu.org 2012-11-15 1:07 ` hubicka at gcc dot gnu.org 2012-11-15 1:10 ` hubicka at gcc dot gnu.org 2012-11-15 1:18 ` hubicka at gcc dot gnu.org 2012-11-15 1:29 ` tejohnson at google dot com 2012-11-15 1:34 ` tejohnson at google dot com 2012-11-15 1:42 ` Jan Hubicka 2012-11-15 1:43 ` hubicka at ucw dot cz 2012-11-15 1:53 ` tejohnson at google dot com 2012-11-15 2:02 ` hubicka at ucw dot cz 2012-11-15 2:46 ` tejohnson at google dot com 2012-11-15 6:44 ` tejohnson at google dot com 2012-11-15 10:56 ` Jan Hubicka 2012-11-15 10:57 ` hubicka at ucw dot cz 2012-11-15 14:34 ` tejohnson at google dot com 2012-11-15 22:42 ` tejohnson at google dot com 2012-11-16 17:42 ` hubicka at gcc dot gnu.org 2012-11-16 18:03 ` tejohnson at google dot com [this message] 2012-11-16 18:57 ` hubicka at ucw dot cz 2012-11-19 5:21 ` tejohnson at gcc dot gnu.org 2012-12-07 12:04 ` rguenth at gcc dot gnu.org
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=bug-55051-4-xT7v7Lc3fe@http.gcc.gnu.org/bugzilla/ \ --to=gcc-bugzilla@gcc.gnu.org \ --cc=gcc-bugs@gcc.gnu.org \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).