From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 29547 invoked by alias); 16 Nov 2012 18:03:27 -0000 Received: (qmail 29478 invoked by uid 55); 16 Nov 2012 18:03:10 -0000 From: "tejohnson at google dot com" To: gcc-bugs@gcc.gnu.org Subject: [Bug bootstrap/55051] [4.8 Regression] profiledbootstrap failed Date: Fri, 16 Nov 2012 18:03:00 -0000 X-Bugzilla-Reason: CC X-Bugzilla-Type: changed X-Bugzilla-Watch-Reason: None X-Bugzilla-Product: gcc X-Bugzilla-Component: bootstrap X-Bugzilla-Keywords: X-Bugzilla-Severity: normal X-Bugzilla-Who: tejohnson at google dot com X-Bugzilla-Status: UNCONFIRMED X-Bugzilla-Priority: P3 X-Bugzilla-Assigned-To: unassigned at gcc dot gnu.org X-Bugzilla-Target-Milestone: 4.8.0 X-Bugzilla-Changed-Fields: Message-ID: In-Reply-To: References: X-Bugzilla-URL: http://gcc.gnu.org/bugzilla/ Auto-Submitted: auto-generated Content-Type: text/plain; charset="UTF-8" MIME-Version: 1.0 Mailing-List: contact gcc-bugs-help@gcc.gnu.org; run by ezmlm Precedence: bulk List-Id: List-Archive: List-Post: List-Help: Sender: gcc-bugs-owner@gcc.gnu.org X-SW-Source: 2012-11/txt/msg01540.txt.bz2 http://gcc.gnu.org/bugzilla/show_bug.cgi?id=55051 --- Comment #28 from Teresa Johnson 2012-11-16 18:03:08 UTC --- On Fri, Nov 16, 2012 at 9:42 AM, hubicka at gcc dot gnu.org wrote: > > http://gcc.gnu.org/bugzilla/show_bug.cgi?id=55051 > > --- Comment #27 from Jan Hubicka 2012-11-16 17:42:26 UTC --- > /* Now merge each file. */ > for (gi_ptr = gcov_list; gi_ptr; gi_ptr = gi_ptr->next) > { > // Open existing gcda file for gi_ptr > // Find program summary corresponding to this executable -> save in prg > // Merge execution counts for each function > // Merge program summary > // - If this is the first merged file for this execution, > save merged summary in all_prg > // - Otherwise if #runs the same in prg and all_prg, > print error message if prg != all_prg. > // Write merged gcda > } > > Hmm, yes, it seems wrong. We can not expect all gcda files to have same number > of runs. We really need to process sum_all & friends locally for each file. > Only I suppose we can check if number of runs of the prg happens to match the > last merged file then sum_all should match. I'm confused - that is essentially what it is doing today (although comparing against the first merged file instead of the last merged file). It isn't expecting all the gcda files to have the same number of runs, but when they do it expects them to have the same sum_all. See the trace of updates I show below this pseudo code in the same email that shows why that is not working. > That would be nice consistency > check. If the bootstrap works with this change, consider the patch preapproved. I had sent a patch last night to simply rip out this check based on the analysis I had done, but I assume you are not talking about that. Thanks, Teresa > > -- > Configure bugmail: http://gcc.gnu.org/bugzilla/userprefs.cgi?tab=email > ------- You are receiving this mail because: ------- > You are on the CC list for the bug. -- Teresa Johnson | Software Engineer | tejohnson@google.com | 408-460-2413