public inbox for gcc-bugs@sourceware.org
help / color / mirror / Atom feed
* [Bug tree-optimization/55052] New: [4.8 regression] vect-widening tests are failing and giving wrong results
@ 2012-10-24 10:37 ramana at gcc dot gnu.org
  2012-10-24 10:38 ` [Bug tree-optimization/55052] " ramana at gcc dot gnu.org
                   ` (8 more replies)
  0 siblings, 9 replies; 10+ messages in thread
From: ramana at gcc dot gnu.org @ 2012-10-24 10:37 UTC (permalink / raw)
  To: gcc-bugs


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=55052

             Bug #: 55052
           Summary: [4.8 regression] vect-widening tests are failing and
                    giving wrong results
    Classification: Unclassified
           Product: gcc
           Version: 4.8.0
            Status: UNCONFIRMED
          Severity: normal
          Priority: P3
         Component: tree-optimization
        AssignedTo: unassigned@gcc.gnu.org
        ReportedBy: ramana@gcc.gnu.org


PASS->FAIL: gcc.dg/vect/vect-over-widen-2-big-array.c execution test (occurs 2
times) 
PASS->FAIL: gcc.dg/vect/vect-over-widen-2-big-array.c -flto execution test
(occurs 2 times)
PASS->FAIL: gcc.dg/vect/vect-over-widen-2.c execution test (occurs 2 times) 
PASS->FAIL: gcc.dg/vect/vect-over-widen-2.c -flto execution test (occurs 2
times)
PASS->FAIL: gcc.dg/vect/vect-widen-shift-s8.c execution test (occurs 2 times)
PASS->FAIL: gcc.dg/vect/vect-widen-shift-s8.c -flto execution test (occurs 2
times) 
PASS->FAIL: gcc.dg/vect/vect-widen-shift-u8.c execution test (occurs 2 times)
PASS->FAIL: gcc.dg/vect/vect-widen-shift-u8.c -flto execution test (occurs 2
times)


^ permalink raw reply	[flat|nested] 10+ messages in thread

* [Bug tree-optimization/55052] [4.8 regression] vect-widening tests are failing and giving wrong results
  2012-10-24 10:37 [Bug tree-optimization/55052] New: [4.8 regression] vect-widening tests are failing and giving wrong results ramana at gcc dot gnu.org
@ 2012-10-24 10:38 ` ramana at gcc dot gnu.org
  2012-10-24 10:57 ` rguenth at gcc dot gnu.org
                   ` (7 subsequent siblings)
  8 siblings, 0 replies; 10+ messages in thread
From: ramana at gcc dot gnu.org @ 2012-10-24 10:38 UTC (permalink / raw)
  To: gcc-bugs


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=55052

Ramana Radhakrishnan <ramana at gcc dot gnu.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Target|                            |arm-linux-gnueabi
             Status|UNCONFIRMED                 |NEW
   Last reconfirmed|                            |2012-10-24
     Ever Confirmed|0                           |1

--- Comment #1 from Ramana Radhakrishnan <ramana at gcc dot gnu.org> 2012-10-24 10:37:48 UTC ---
--target=arm-linux-gnueabi --with-cpu=cortex-a15 --with-fpu=neon
--with-float=softfp


^ permalink raw reply	[flat|nested] 10+ messages in thread

* [Bug tree-optimization/55052] [4.8 regression] vect-widening tests are failing and giving wrong results
  2012-10-24 10:37 [Bug tree-optimization/55052] New: [4.8 regression] vect-widening tests are failing and giving wrong results ramana at gcc dot gnu.org
  2012-10-24 10:38 ` [Bug tree-optimization/55052] " ramana at gcc dot gnu.org
@ 2012-10-24 10:57 ` rguenth at gcc dot gnu.org
  2012-11-28  2:23 ` ramana at gcc dot gnu.org
                   ` (6 subsequent siblings)
  8 siblings, 0 replies; 10+ messages in thread
From: rguenth at gcc dot gnu.org @ 2012-10-24 10:57 UTC (permalink / raw)
  To: gcc-bugs


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=55052

Richard Biener <rguenth at gcc dot gnu.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
   Target Milestone|---                         |4.8.0


^ permalink raw reply	[flat|nested] 10+ messages in thread

* [Bug tree-optimization/55052] [4.8 regression] vect-widening tests are failing and giving wrong results
  2012-10-24 10:37 [Bug tree-optimization/55052] New: [4.8 regression] vect-widening tests are failing and giving wrong results ramana at gcc dot gnu.org
  2012-10-24 10:38 ` [Bug tree-optimization/55052] " ramana at gcc dot gnu.org
  2012-10-24 10:57 ` rguenth at gcc dot gnu.org
@ 2012-11-28  2:23 ` ramana at gcc dot gnu.org
  2012-11-28  2:26 ` ramana at gcc dot gnu.org
                   ` (5 subsequent siblings)
  8 siblings, 0 replies; 10+ messages in thread
From: ramana at gcc dot gnu.org @ 2012-11-28  2:23 UTC (permalink / raw)
  To: gcc-bugs


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=55052

--- Comment #3 from Ramana Radhakrishnan <ramana at gcc dot gnu.org> 2012-11-28 02:23:33 UTC ---
fwprop in the failure case ends up replacing . 

In insn 50, replacing
 (sign_extend:V4SI (ashift:V4HI (subreg:V4HI (reg:V8HI 269 [ vect_var_.41 ]) 8)
            (const_int 3 [0x3])))

 with (const_vector:V4SI [
            (const_int 0 [0])
            (const_int 0 [0])
            (const_int 0 [0])
            (const_int 0 [0])
        ])


but that can't be right ..... especially if the value in reg 269 is essentially
out of a vld4. 

33 r269:V8HI=zero_extend(vec_select(r268:V16QI,parallel))
   34 r270:V8HI=zero_extend(vec_select(r268:V16QI,parallel))
   35 r1211:V16QI=const_vector
   36 r275:V16QI=r1211:V16QI&r1196:XI#32
   37 r276:V8HI=zero_extend(vec_select(r275:V16QI,parallel))
   38 r277:V8HI=zero_extend(vec_select(r275:V16QI,parallel))
   39 r1212:V4SI=sign_extend(r269:V8HI#0<<0x3)
   40 r1213:V4SI=zero_extend(vec_select(r252:V8HI,parallel))
   41 r1214:V4SI=r1213:V4SI>>const_vector
   42 r1215:V4SI=r1212:V4SI|r1214:V4SI
   43 r1216:V4SI=sign_extend(r276:V8HI#0<<0x8)
   44 r1217:V4SI=r1215:V4SI|r1216:V4SI
   45 r1218:V4SI=zero_extend(vec_select(r258:V8HI,parallel))
   46 r1219:V4SI=r1218:V4SI>>const_vector
   47 r1220:V4SI=r1217:V4SI|r1219:V4SI
   48 [r1198:SI]=unspec[r1220:V4SI] 164
   50 r1221:V4SI=sign_extend(r269:V8HI#8<<0x3)


Attached is a .i file and associated dumps. 

Ramana


^ permalink raw reply	[flat|nested] 10+ messages in thread

* [Bug tree-optimization/55052] [4.8 regression] vect-widening tests are failing and giving wrong results
  2012-10-24 10:37 [Bug tree-optimization/55052] New: [4.8 regression] vect-widening tests are failing and giving wrong results ramana at gcc dot gnu.org
                   ` (2 preceding siblings ...)
  2012-11-28  2:23 ` ramana at gcc dot gnu.org
@ 2012-11-28  2:26 ` ramana at gcc dot gnu.org
  2012-11-28  2:30 ` pinskia at gcc dot gnu.org
                   ` (4 subsequent siblings)
  8 siblings, 0 replies; 10+ messages in thread
From: ramana at gcc dot gnu.org @ 2012-11-28  2:26 UTC (permalink / raw)
  To: gcc-bugs


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=55052

--- Comment #4 from Ramana Radhakrishnan <ramana at gcc dot gnu.org> 2012-11-28 02:25:38 UTC ---
Created attachment 28812
  --> http://gcc.gnu.org/bugzilla/attachment.cgi?id=28812
testcase and dumps.

regenerate with command line options

-mcpu=cortex-a15 -mfpu=neon -mfloat-abi=hard -O3 

on a cross-compiler configured for arm-linux-gnueabi


^ permalink raw reply	[flat|nested] 10+ messages in thread

* [Bug tree-optimization/55052] [4.8 regression] vect-widening tests are failing and giving wrong results
  2012-10-24 10:37 [Bug tree-optimization/55052] New: [4.8 regression] vect-widening tests are failing and giving wrong results ramana at gcc dot gnu.org
                   ` (3 preceding siblings ...)
  2012-11-28  2:26 ` ramana at gcc dot gnu.org
@ 2012-11-28  2:30 ` pinskia at gcc dot gnu.org
  2012-11-28 20:28 ` rsandifo at gcc dot gnu.org
                   ` (3 subsequent siblings)
  8 siblings, 0 replies; 10+ messages in thread
From: pinskia at gcc dot gnu.org @ 2012-11-28  2:30 UTC (permalink / raw)
  To: gcc-bugs


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=55052

--- Comment #5 from Andrew Pinski <pinskia at gcc dot gnu.org> 2012-11-28 02:29:53 UTC ---
Sounds like a case of a missing check for VECTOR modes when it is doing the
subreg as a truncation optimization.


^ permalink raw reply	[flat|nested] 10+ messages in thread

* [Bug tree-optimization/55052] [4.8 regression] vect-widening tests are failing and giving wrong results
  2012-10-24 10:37 [Bug tree-optimization/55052] New: [4.8 regression] vect-widening tests are failing and giving wrong results ramana at gcc dot gnu.org
                   ` (4 preceding siblings ...)
  2012-11-28  2:30 ` pinskia at gcc dot gnu.org
@ 2012-11-28 20:28 ` rsandifo at gcc dot gnu.org
  2012-11-28 21:45 ` rsandifo at gcc dot gnu.org
                   ` (2 subsequent siblings)
  8 siblings, 0 replies; 10+ messages in thread
From: rsandifo at gcc dot gnu.org @ 2012-11-28 20:28 UTC (permalink / raw)
  To: gcc-bugs


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=55052

rsandifo@gcc.gnu.org <rsandifo at gcc dot gnu.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |ASSIGNED
         AssignedTo|unassigned at gcc dot       |rsandifo at gcc dot gnu.org
                   |gnu.org                     |

--- Comment #6 from rsandifo at gcc dot gnu.org <rsandifo at gcc dot gnu.org> 2012-11-28 20:28:06 UTC ---
(In reply to comment #5)
> Sounds like a case of a missing check for VECTOR modes when it is doing the
> subreg as a truncation optimization.

Yeah, looks like a SCALAR_INT_MODE_P got cut in the process.
Testing a patch.


^ permalink raw reply	[flat|nested] 10+ messages in thread

* [Bug tree-optimization/55052] [4.8 regression] vect-widening tests are failing and giving wrong results
  2012-10-24 10:37 [Bug tree-optimization/55052] New: [4.8 regression] vect-widening tests are failing and giving wrong results ramana at gcc dot gnu.org
                   ` (5 preceding siblings ...)
  2012-11-28 20:28 ` rsandifo at gcc dot gnu.org
@ 2012-11-28 21:45 ` rsandifo at gcc dot gnu.org
  2012-11-28 21:46 ` rsandifo at gcc dot gnu.org
  2012-11-29 13:30 ` ramana at gcc dot gnu.org
  8 siblings, 0 replies; 10+ messages in thread
From: rsandifo at gcc dot gnu.org @ 2012-11-28 21:45 UTC (permalink / raw)
  To: gcc-bugs


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=55052

--- Comment #7 from rsandifo at gcc dot gnu.org <rsandifo at gcc dot gnu.org> 2012-11-28 21:45:08 UTC ---
Author: rsandifo
Date: Wed Nov 28 21:45:03 2012
New Revision: 193909

URL: http://gcc.gnu.org/viewcvs?root=gcc&view=rev&rev=193909
Log:
gcc/
    PR rtl-optimization/55052
    * simplify-rtx.c (simplify_subreg): Restore SCALAR_INT_MODE_P check.

Modified:
    trunk/gcc/ChangeLog
    trunk/gcc/simplify-rtx.c


^ permalink raw reply	[flat|nested] 10+ messages in thread

* [Bug tree-optimization/55052] [4.8 regression] vect-widening tests are failing and giving wrong results
  2012-10-24 10:37 [Bug tree-optimization/55052] New: [4.8 regression] vect-widening tests are failing and giving wrong results ramana at gcc dot gnu.org
                   ` (6 preceding siblings ...)
  2012-11-28 21:45 ` rsandifo at gcc dot gnu.org
@ 2012-11-28 21:46 ` rsandifo at gcc dot gnu.org
  2012-11-29 13:30 ` ramana at gcc dot gnu.org
  8 siblings, 0 replies; 10+ messages in thread
From: rsandifo at gcc dot gnu.org @ 2012-11-28 21:46 UTC (permalink / raw)
  To: gcc-bugs


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=55052

rsandifo@gcc.gnu.org <rsandifo at gcc dot gnu.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|ASSIGNED                    |RESOLVED
         Resolution|                            |FIXED

--- Comment #8 from rsandifo at gcc dot gnu.org <rsandifo at gcc dot gnu.org> 2012-11-28 21:46:12 UTC ---
Patch applied.


^ permalink raw reply	[flat|nested] 10+ messages in thread

* [Bug tree-optimization/55052] [4.8 regression] vect-widening tests are failing and giving wrong results
  2012-10-24 10:37 [Bug tree-optimization/55052] New: [4.8 regression] vect-widening tests are failing and giving wrong results ramana at gcc dot gnu.org
                   ` (7 preceding siblings ...)
  2012-11-28 21:46 ` rsandifo at gcc dot gnu.org
@ 2012-11-29 13:30 ` ramana at gcc dot gnu.org
  8 siblings, 0 replies; 10+ messages in thread
From: ramana at gcc dot gnu.org @ 2012-11-29 13:30 UTC (permalink / raw)
  To: gcc-bugs


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=55052

--- Comment #9 from Ramana Radhakrishnan <ramana at gcc dot gnu.org> 2012-11-29 13:29:46 UTC ---
(In reply to comment #8)
> Patch applied.

fixes the issue and the another issue in perlbmk which had the exactly the same
symptoms 

Thanks. 
ramana


^ permalink raw reply	[flat|nested] 10+ messages in thread

end of thread, other threads:[~2012-11-29 13:30 UTC | newest]

Thread overview: 10+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2012-10-24 10:37 [Bug tree-optimization/55052] New: [4.8 regression] vect-widening tests are failing and giving wrong results ramana at gcc dot gnu.org
2012-10-24 10:38 ` [Bug tree-optimization/55052] " ramana at gcc dot gnu.org
2012-10-24 10:57 ` rguenth at gcc dot gnu.org
2012-11-28  2:23 ` ramana at gcc dot gnu.org
2012-11-28  2:26 ` ramana at gcc dot gnu.org
2012-11-28  2:30 ` pinskia at gcc dot gnu.org
2012-11-28 20:28 ` rsandifo at gcc dot gnu.org
2012-11-28 21:45 ` rsandifo at gcc dot gnu.org
2012-11-28 21:46 ` rsandifo at gcc dot gnu.org
2012-11-29 13:30 ` ramana at gcc dot gnu.org

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).