[Bug c/55083] New: failure while configuring libatomic is not cleaned up

public inbox for gcc-bugs@sourceware.org
help / color / mirror / Atom feed

* [Bug c/55083] New: failure while configuring libatomic is not cleaned up
@ 2012-10-26 14:53 pedzsan at gmail dot com
  2012-10-26 15:14 ` [Bug bootstrap/55083] " pinskia at gcc dot gnu.org
                   ` (5 more replies)
  0 siblings, 6 replies; 7+ messages in thread
From: pedzsan at gmail dot com @ 2012-10-26 14:53 UTC (permalink / raw)
  To: gcc-bugs

http://gcc.gnu.org/bugzilla/show_bug.cgi?id=55083

             Bug #: 55083
           Summary: failure while configuring libatomic is not cleaned up
    Classification: Unclassified
           Product: gcc
           Version: 4.8.0
            Status: UNCONFIRMED
          Severity: normal
          Priority: P3
         Component: c
        AssignedTo: unassigned@gcc.gnu.org
        ReportedBy: pedzsan@gmail.com

If something fails during the configuration phase of libatomic, a subsequent
"make" will take a different path and not complete the configure processing.

The error can be seen in the configure-target-libatomic: code of Makefile.in
(at the top directory).  Midway down, if the directory exists, exit 0 is
called.  If it does not exist, then it is created and configure for libatomic
is called.  But if configure fails, the directory is not removed.  Subsequent
"make" will assume that everything had been configured.

^ permalink raw reply	[flat|nested] 7+ messages in thread

* [Bug bootstrap/55083] failure while configuring libatomic is not cleaned up
  2012-10-26 14:53 [Bug c/55083] New: failure while configuring libatomic is not cleaned up pedzsan at gmail dot com
@ 2012-10-26 15:14 ` pinskia at gcc dot gnu.org
  2012-10-26 15:31 ` pedzsan at gmail dot com
                   ` (4 subsequent siblings)
  5 siblings, 0 replies; 7+ messages in thread
From: pinskia at gcc dot gnu.org @ 2012-10-26 15:14 UTC (permalink / raw)
  To: gcc-bugs


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=55083

Andrew Pinski <pinskia at gcc dot gnu.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Keywords|                            |build
          Component|c                           |bootstrap

--- Comment #1 from Andrew Pinski <pinskia at gcc dot gnu.org> 2012-10-26 15:14:17 UTC ---
Can you be more specific than about the failure you are seeing in configuring
for libatomic?

Also what target are you seeing an error for?


^ permalink raw reply	[flat|nested] 7+ messages in thread

* [Bug bootstrap/55083] failure while configuring libatomic is not cleaned up
  2012-10-26 14:53 [Bug c/55083] New: failure while configuring libatomic is not cleaned up pedzsan at gmail dot com
  2012-10-26 15:14 ` [Bug bootstrap/55083] " pinskia at gcc dot gnu.org
@ 2012-10-26 15:31 ` pedzsan at gmail dot com
  2012-12-09  2:24 ` pinskia at gcc dot gnu.org
                   ` (3 subsequent siblings)
  5 siblings, 0 replies; 7+ messages in thread
From: pedzsan at gmail dot com @ 2012-10-26 15:31 UTC (permalink / raw)
  To: gcc-bugs


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=55083

--- Comment #2 from Perry Smith <pedzsan at gmail dot com> 2012-10-26 15:31:27 UTC ---
To be clear, the error during configuration is not what the bug report is
about.  The discussion of the error can be seen here:
http://gcc.gnu.org/ml/gcc/2012-10/msg00380.html

cc1 is failing because LD_LIBRARY_PATH is set to the wrong value.

What this bug report is addressing is the fact that a failure does not clean
up.

The test I'm doing may be a little hard to recreate but I am doing

rm -r powerpc-ibm-aix6.1.0.0/libatomic
make configure-target-libatomic

but you will need to somehow cause your gcc/xgcc or gcc/cc1 to fail (or create
some other way to cause the configure to fail).


^ permalink raw reply	[flat|nested] 7+ messages in thread

* [Bug bootstrap/55083] failure while configuring libatomic is not cleaned up
  2012-10-26 14:53 [Bug c/55083] New: failure while configuring libatomic is not cleaned up pedzsan at gmail dot com
  2012-10-26 15:14 ` [Bug bootstrap/55083] " pinskia at gcc dot gnu.org
  2012-10-26 15:31 ` pedzsan at gmail dot com
@ 2012-12-09  2:24 ` pinskia at gcc dot gnu.org
  2012-12-09  4:46 ` pedzsan at gmail dot com
                   ` (2 subsequent siblings)
  5 siblings, 0 replies; 7+ messages in thread
From: pinskia at gcc dot gnu.org @ 2012-12-09  2:24 UTC (permalink / raw)
  To: gcc-bugs


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=55083

--- Comment #3 from Andrew Pinski <pinskia at gcc dot gnu.org> 2012-12-09 02:23:48 UTC ---
It does not test if the directory exists but rather if the Makefile in the
directory exists.
    test ! -f $(TARGET_SUBDIR)/libatomic/Makefile || exit 0; \

So I think this is invalid.


^ permalink raw reply	[flat|nested] 7+ messages in thread

* [Bug bootstrap/55083] failure while configuring libatomic is not cleaned up
  2012-10-26 14:53 [Bug c/55083] New: failure while configuring libatomic is not cleaned up pedzsan at gmail dot com
                   ` (2 preceding siblings ...)
  2012-12-09  2:24 ` pinskia at gcc dot gnu.org
@ 2012-12-09  4:46 ` pedzsan at gmail dot com
  2012-12-09  5:07 ` pinskia at gcc dot gnu.org
  2012-12-09  5:40 ` pedzsan at gmail dot com
  5 siblings, 0 replies; 7+ messages in thread
From: pedzsan at gmail dot com @ 2012-12-09  4:46 UTC (permalink / raw)
  To: gcc-bugs


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=55083

--- Comment #4 from Perry Smith <pedzsan at gmail dot com> 2012-12-09 04:45:47 UTC ---
I can't remember much about this.  Things may have changed since I reported it.

Is the Makefile created as the last step?

If not, then if something fails after the Makefile is created, then the next
build will assume everything in that section completed successfully (which will
be incorrect).


^ permalink raw reply	[flat|nested] 7+ messages in thread

* [Bug bootstrap/55083] failure while configuring libatomic is not cleaned up
  2012-10-26 14:53 [Bug c/55083] New: failure while configuring libatomic is not cleaned up pedzsan at gmail dot com
                   ` (3 preceding siblings ...)
  2012-12-09  4:46 ` pedzsan at gmail dot com
@ 2012-12-09  5:07 ` pinskia at gcc dot gnu.org
  2012-12-09  5:40 ` pedzsan at gmail dot com
  5 siblings, 0 replies; 7+ messages in thread
From: pinskia at gcc dot gnu.org @ 2012-12-09  5:07 UTC (permalink / raw)
  To: gcc-bugs


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=55083

Andrew Pinski <pinskia at gcc dot gnu.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|UNCONFIRMED                 |RESOLVED
         Resolution|                            |INVALID

--- Comment #5 from Andrew Pinski <pinskia at gcc dot gnu.org> 2012-12-09 05:06:54 UTC ---
(In reply to comment #4)
> I can't remember much about this.  Things may have changed since I reported it.

Not in the toplevel Makefile or libatomic's configure.

> 
> Is the Makefile created as the last step?


yes it is created after all of configure has finished.

> If not, then if something fails after the Makefile is created, then the next
> build will assume everything in that section completed successfully (which will
> be incorrect).


^ permalink raw reply	[flat|nested] 7+ messages in thread

* [Bug bootstrap/55083] failure while configuring libatomic is not cleaned up
  2012-10-26 14:53 [Bug c/55083] New: failure while configuring libatomic is not cleaned up pedzsan at gmail dot com
                   ` (4 preceding siblings ...)
  2012-12-09  5:07 ` pinskia at gcc dot gnu.org
@ 2012-12-09  5:40 ` pedzsan at gmail dot com
  5 siblings, 0 replies; 7+ messages in thread
From: pedzsan at gmail dot com @ 2012-12-09  5:40 UTC (permalink / raw)
  To: gcc-bugs


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=55083

--- Comment #6 from Perry Smith <pedzsan at gmail dot com> 2012-12-09 05:40:28 UTC ---
If it helps, here are the last messages from the make log:

checking for powerpc-ibm-aix6.1.0.0-gcc... /usr/work/build/gcc.git/./gcc/xgcc
-B/usr/work/build/gcc.git/./gcc/ -B
/gsa/ausgsa/projects/r/ruby/powerpc-ibm-aix6.1.0.0/bin/
-B/gsa/ausgsa/projects/r/ruby/powerpc-ibm-aix6.1.0.0/lib/
 -isystem /gsa/ausgsa/projects/r/ruby/powerpc-ibm-aix6.1.0.0/include -isystem
/gsa/ausgsa/projects/r/ruby/powerpc
-ibm-aix6.1.0.0/sys-include  -maix64
checking for C compiler default output file name...
configure: error: in
`/usr/work/build/gcc.git/powerpc-ibm-aix6.1.0.0/ppc64/libatomic':
configure: error: C compiler cannot create executables
See `config.log' for more details.
make[1]: *** [configure-target-libatomic] Error 1
make[1]: Leaving directory `/usr/work/build/gcc.git'
make: *** [all] Error 2


All's I know is after the error, a "make" would not finish the config
processing and go down a different path.


^ permalink raw reply	[flat|nested] 7+ messages in thread

end of thread, other threads:[~2012-12-09  5:40 UTC | newest]

Thread overview: 7+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2012-10-26 14:53 [Bug c/55083] New: failure while configuring libatomic is not cleaned up pedzsan at gmail dot com
2012-10-26 15:14 ` [Bug bootstrap/55083] " pinskia at gcc dot gnu.org
2012-10-26 15:31 ` pedzsan at gmail dot com
2012-12-09  2:24 ` pinskia at gcc dot gnu.org
2012-12-09  4:46 ` pedzsan at gmail dot com
2012-12-09  5:07 ` pinskia at gcc dot gnu.org
2012-12-09  5:40 ` pedzsan at gmail dot com

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).