public inbox for gcc-bugs@sourceware.org
help / color / mirror / Atom feed
From: "jakub at gcc dot gnu.org" <gcc-bugzilla@gcc.gnu.org>
To: gcc-bugs@gcc.gnu.org
Subject: [Bug target/55147] x86: wrong code for 64-bit load
Date: Wed, 31 Oct 2012 15:39:00 -0000 [thread overview]
Message-ID: <bug-55147-4-GXhJtIHHmp@http.gcc.gnu.org/bugzilla/> (raw)
In-Reply-To: <bug-55147-4@http.gcc.gnu.org/bugzilla/>
http://gcc.gnu.org/bugzilla/show_bug.cgi?id=55147
Jakub Jelinek <jakub at gcc dot gnu.org> changed:
What |Removed |Added
----------------------------------------------------------------------------
Status|UNCONFIRMED |NEW
Last reconfirmed| |2012-10-31
CC| |jakub at gcc dot gnu.org,
| |uros at gcc dot gnu.org
Ever Confirmed|0 |1
--- Comment #1 from Jakub Jelinek <jakub at gcc dot gnu.org> 2012-10-31 15:37:49 UTC ---
--- gcc/config/i386/i386.md.jj 2012-10-30 09:01:15.000000000 +0100
+++ gcc/config/i386/i386.md 2012-10-31 16:25:13.986916767 +0100
@@ -12688,7 +12688,14 @@ (define_insn_and_split "*bswapdi2_double
(set (match_dup 0)
(bswap:SI (match_dup 3)))]
{
- split_double_mode (DImode, &operands[0], 2, &operands[0], &operands[2]);
+ split_double_mode (DImode, &operands[0], 1, &operands[0], &operands[2]);
+ if (MEM_P (operands[1])
+ && reg_overlap_mentioned_p (operands[2], operands[1]))
+ {
+ emit_insn (gen_rtx_SET (VOIDmode, operands[0], XEXP (operands[1], 0)));
+ operands[1] = change_address (operands[1], VOIDmode, operands[0]);
+ }
+ split_double_mode (DImode, &operands[1], 1, &operands[1], &operands[3]);
if (REG_P (operands[0]) && REG_P (operands[1]))
{
can fix the reg overlap problem between address of operands[1] and high part of
operands[0]. That said, I wonder what is the advantage of having bswapdi2
patter on i?86 at all that the generic expand_doubleword_bswap can't handle.
next prev parent reply other threads:[~2012-10-31 15:39 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-10-31 11:23 [Bug target/55147] New: " mans at mansr dot com
2012-10-31 15:39 ` jakub at gcc dot gnu.org [this message]
2012-10-31 15:48 ` [Bug target/55147] " ubizjak at gmail dot com
2012-10-31 16:07 ` jakub at gcc dot gnu.org
2012-11-01 9:27 ` [Bug target/55147] [4.8 Regression] " ubizjak at gmail dot com
2012-11-01 9:44 ` jakub at gcc dot gnu.org
2012-11-01 9:49 ` ubizjak at gmail dot com
2012-11-02 8:03 ` jakub at gcc dot gnu.org
2012-11-07 10:15 ` jakub at gcc dot gnu.org
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=bug-55147-4-GXhJtIHHmp@http.gcc.gnu.org/bugzilla/ \
--to=gcc-bugzilla@gcc.gnu.org \
--cc=gcc-bugs@gcc.gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).