[Bug driver/55202] New: Building a combined tree is broken for LTO

[Bug driver/55202] New: Building a combined tree is broken for LTO

[pinskia at gcc dot gnu.org]

http://gcc.gnu.org/bugzilla/show_bug.cgi?id=55202

             Bug #: 55202
           Summary: Building a combined tree is broken for LTO
    Classification: Unclassified
           Product: gcc
           Version: 4.8.0
            Status: UNCONFIRMED
          Severity: normal
          Priority: P3
         Component: driver
        AssignedTo: unassigned@gcc.gnu.org
        ReportedBy: pinskia@gcc.gnu.org


When you build with a combined tree and use -flto, the driver thinks the ld
which is being used is ld-new which is not correct.  The correct ld to be used
here is really ld.

[Bug driver/55202] Building a combined tree is broken for LTO

[pinskia at gcc dot gnu.org]

http://gcc.gnu.org/bugzilla/show_bug.cgi?id=55202

--- Comment #1 from Andrew Pinski <pinskia at gcc dot gnu.org> 2012-11-04 08:29:02 UTC ---
Created attachment 28608
  --> http://gcc.gnu.org/bugzilla/attachment.cgi?id=28608
Patch which fixes the problem

[Bug driver/55202] Building a combined tree is broken for LTO

[pinskia at gcc dot gnu.org]

http://gcc.gnu.org/bugzilla/show_bug.cgi?id=55202

Andrew Pinski <pinskia at gcc dot gnu.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|UNCONFIRMED                 |ASSIGNED
   Last reconfirmed|                            |2012-11-04
         AssignedTo|unassigned at gcc dot       |pinskia at gcc dot gnu.org
                   |gnu.org                     |
     Ever Confirmed|0                           |1

--- Comment #2 from Andrew Pinski <pinskia at gcc dot gnu.org> 2012-11-04 08:30:17 UTC ---
Just recording this bug so I don't forget to submit this patch.  I have ran
into this twice now.  Once when I was working on MIPS64 and now with AARCH64.

[Bug driver/55202] Building a combined tree is broken for LTO

[pinskia at gcc dot gnu.org]

http://gcc.gnu.org/bugzilla/show_bug.cgi?id=55202

--- Comment #3 from Andrew Pinski <pinskia at gcc dot gnu.org> 2012-11-04 08:36:08 UTC ---
[cannot find ld] -plugin
/home/pinskia/src/toolchain-cavium/thunder-tools/bin/../libexec/gcc/aarch64-thunder-elf/4.8.0/liblto_plugin.so
-plugin-opt=/home/pinskia/src/toolchain-cavium/thunder-tools/bin/../libexec/gcc/aarch64-thunder-elf/4.8.0/lto-wrapper
-plugin-opt=-fresolution=/tmp/cc8Il24U.res -plugin-opt=-pass-through=-lgcc
-plugin-opt=-pass-through=-lc -plugin-opt=-pass-through=-lgcc -X
/home/pinskia/src/toolchain-cavium/thunder-tools/bin/../lib/gcc/aarch64-thunder-elf/4.8.0/crti.o
/home/pinskia/src/toolchain-cavium/thunder-tools/bin/../lib/gcc/aarch64-thunder-elf/4.8.0/crtbegin.o
/home/pinskia/src/toolchain-cavium/thunder-tools/bin/../lib/gcc/aarch64-thunder-elf/4.8.0/../../../../aarch64-thunder-elf/lib/crt0.o
-L/home/pinskia/src/toolchain-cavium/thunder-tools/bin/../lib/gcc/aarch64-thunder-elf/4.8.0
-L/home/pinskia/src/toolchain-cavium/thunder-tools/bin/../lib/gcc
-L/home/pinskia/src/toolchain-cavium/thunder-tools/bin/../lib/gcc/aarch64-thunder-elf/4.8.0/../../../../aarch64-thunder-elf/lib
/tmp/ccBZOKuH.o -v -lgcc -lc -lgcc
/home/pinskia/src/toolchain-cavium/thunder-tools/bin/../lib/gcc/aarch64-thunder-elf/4.8.0/crtend.o
/home/pinskia/src/toolchain-cavium/thunder-tools/bin/../lib/gcc/aarch64-thunder-elf/4.8.0/crtn.o

I have no patches installed either.  The patch above does not work.

[Bug driver/55202] Building a combined tree is broken for LTO

[pinskia at gcc dot gnu.org]

http://gcc.gnu.org/bugzilla/show_bug.cgi?id=55202

--- Comment #4 from Andrew Pinski <pinskia at gcc dot gnu.org> 2012-11-04 08:37:29 UTC ---
(In reply to comment #3)
> I have no patches installed either.  The patch above does not work.

That is because I was porting the patch from 4.7 to 4.8 and the variable
changed named so I had a typo in it.

[Bug driver/55202] Building a combined tree is broken for LTO

[pinskia at gcc dot gnu.org]

http://gcc.gnu.org/bugzilla/show_bug.cgi?id=55202

--- Comment #5 from Andrew Pinski <pinskia at gcc dot gnu.org> 2012-11-10 18:32:27 UTC ---
Author: pinskia
Date: Sat Nov 10 18:32:23 2012
New Revision: 193393

URL: http://gcc.gnu.org/viewcvs?root=gcc&view=rev&rev=193393
Log:
2012-11-10  Andrew Pinski  <apinski@cavium.com>

        PR bootstrap/55202
        * configure.ac: Set PLUGIN_LD_SUFFIX to just "ld" if it was "ld-new"
        or "collect-ld".
        * configure: Regenerate.


Modified:
    trunk/gcc/ChangeLog
    trunk/gcc/configure
    trunk/gcc/configure.ac

[Bug driver/55202] Building a combined tree is broken for LTO

[pinskia at gcc dot gnu.org]

http://gcc.gnu.org/bugzilla/show_bug.cgi?id=55202

Andrew Pinski <pinskia at gcc dot gnu.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|ASSIGNED                    |RESOLVED
         Resolution|                            |FIXED

--- Comment #6 from Andrew Pinski <pinskia at gcc dot gnu.org> 2012-11-10 18:32:51 UTC ---
Fixed.

[Bug driver/55202] Building a combined tree is broken for LTO

[tschwinge at gcc dot gnu.org]

http://gcc.gnu.org/bugzilla/show_bug.cgi?id=55202

--- Comment #7 from Thomas Schwinge <tschwinge at gcc dot gnu.org> 2012-12-20 15:57:21 UTC ---
Author: tschwinge
Date: Thu Dec 20 15:57:18 2012
New Revision: 194637

URL: http://gcc.gnu.org/viewcvs?root=gcc&view=rev&rev=194637
Log:
    PR bootstrap/55202
    * configure.ac <PLUGIN_LD_SUFFIX>: Use POSIX shell syntax.
    * configure: Regenerate.

Modified:
    trunk/gcc/ChangeLog
    trunk/gcc/configure
    trunk/gcc/configure.ac