[Bug target/55224] New: [4.8 Regression] FAIL: gcc.target/i386/tailcall-1.c scan-assembler jmp

[Bug target/55224] New: [4.8 Regression] FAIL: gcc.target/i386/tailcall-1.c scan-assembler jmp

[hjl.tools at gmail dot com]

http://gcc.gnu.org/bugzilla/show_bug.cgi?id=55224

             Bug #: 55224
           Summary: [4.8 Regression] FAIL: gcc.target/i386/tailcall-1.c
                    scan-assembler jmp
    Classification: Unclassified
           Product: gcc
           Version: 4.8.0
            Status: UNCONFIRMED
          Severity: normal
          Priority: P3
         Component: target
        AssignedTo: unassigned@gcc.gnu.org
        ReportedBy: hjl.tools@gmail.com
                CC: kirill.yukhin@intel.com, vbyakovl23@gmail.com


On Linux/ia32, revision 193229:

http://gcc.gnu.org/ml/gcc-cvs/2012-11/msg00176.html

caused:

FAIL: gcc.target/i386/tailcall-1.c scan-assembler jmp

[Bug target/55224] [4.8 Regression] FAIL: gcc.target/i386/tailcall-1.c scan-assembler jmp

[jakub at gcc dot gnu.org]

http://gcc.gnu.org/bugzilla/show_bug.cgi?id=55224

Jakub Jelinek <jakub at gcc dot gnu.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|UNCONFIRMED                 |NEW
   Last reconfirmed|                            |2012-11-07
                 CC|                            |jakub at gcc dot gnu.org
   Target Milestone|---                         |4.8.0
     Ever Confirmed|0                           |1

[Bug target/55224] [4.8 Regression] FAIL: gcc.target/i386/tailcall-1.c scan-assembler jmp

[ubizjak at gmail dot com]

http://gcc.gnu.org/bugzilla/show_bug.cgi?id=55224

Uros Bizjak <ubizjak at gmail dot com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Target|                            |i686
             Status|NEW                         |ASSIGNED
         AssignedTo|unassigned at gcc dot       |ubizjak at gmail dot com
                   |gnu.org                     |

--- Comment #1 from Uros Bizjak <ubizjak at gmail dot com> 2012-11-07 15:23:17 UTC ---
(In reply to comment #0)
> On Linux/ia32, revision 193229:
> 
> http://gcc.gnu.org/ml/gcc-cvs/2012-11/msg00176.html
> 
> caused:
> 
> FAIL: gcc.target/i386/tailcall-1.c scan-assembler jmp

The referred revision removed a bit too much. Following patch fixes the
problem:

Index: config/i386/i386.c
===================================================================
--- config/i386/i386.c  (revision 193296)
+++ config/i386/i386.c  (working copy)
@@ -4638,6 +4638,8 @@ ix86_function_ok_for_sibcall (tree decl, tree exp)
       if (!rtx_equal_p (a, b))
        return false;
     }
+  else if (VOID_TYPE_P (TREE_TYPE (DECL_RESULT (cfun->decl))))
+    ;
   else if (!rtx_equal_p (a, b))
     return false;

[Bug target/55224] [4.8 Regression] FAIL: gcc.target/i386/tailcall-1.c scan-assembler jmp

[uros at gcc dot gnu.org]

http://gcc.gnu.org/bugzilla/show_bug.cgi?id=55224

--- Comment #2 from uros at gcc dot gnu.org 2012-11-07 19:30:53 UTC ---
Author: uros
Date: Wed Nov  7 19:30:48 2012
New Revision: 193305

URL: http://gcc.gnu.org/viewcvs?root=gcc&view=rev&rev=193305
Log:
    PR target/55224
    * config/i386/i386.c (ix86_function_ok_for_sibcall): Put back exception
    to make a sibcall if one of the functions has void return type.


Modified:
    trunk/gcc/ChangeLog
    trunk/gcc/testsuite/ChangeLog

[Bug target/55224] [4.8 Regression] FAIL: gcc.target/i386/tailcall-1.c scan-assembler jmp

[ubizjak at gmail dot com]

http://gcc.gnu.org/bugzilla/show_bug.cgi?id=55224

Uros Bizjak <ubizjak at gmail dot com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|ASSIGNED                    |RESOLVED
                URL|                            |http://gcc.gnu.org/ml/gcc-p
                   |                            |atches/2012-11/msg00651.htm
                   |                            |l
         Resolution|                            |FIXED

--- Comment #3 from Uros Bizjak <ubizjak at gmail dot com> 2012-11-07 19:32:55 UTC ---
Fixed.

[Bug target/55224] [4.8 Regression] FAIL: gcc.target/i386/tailcall-1.c scan-assembler jmp

[uros at gcc dot gnu.org]

http://gcc.gnu.org/bugzilla/show_bug.cgi?id=55224

--- Comment #4 from uros at gcc dot gnu.org 2012-11-07 19:35:29 UTC ---
Author: uros
Date: Wed Nov  7 19:35:25 2012
New Revision: 193306

URL: http://gcc.gnu.org/viewcvs?root=gcc&view=rev&rev=193306
Log:
    PR target/55224
    * config/i386/i386.c (ix86_function_ok_for_sibcall): Put back exception
    to make a sibcall if one of the functions has void return type.


Modified:
    trunk/gcc/config/i386/i386.c