public inbox for gcc-bugs@sourceware.org
help / color / mirror / Atom feed
* [Bug target/55246] New: Define a macro for 16*1024*1024
@ 2012-11-09  1:44 hjl.tools at gmail dot com
  2012-11-09 10:07 ` [Bug target/55246] " ebotcazou at gcc dot gnu.org
                   ` (2 more replies)
  0 siblings, 3 replies; 4+ messages in thread
From: hjl.tools at gmail dot com @ 2012-11-09  1:44 UTC (permalink / raw)
  To: gcc-bugs


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=55246

             Bug #: 55246
           Summary: Define a macro for 16*1024*1024
    Classification: Unclassified
           Product: gcc
           Version: 4.8.0
            Status: UNCONFIRMED
          Severity: normal
          Priority: P3
         Component: target
        AssignedTo: unassigned@gcc.gnu.org
        ReportedBy: hjl.tools@gmail.com
                CC: ubizjak@gmail.com


i386 backend has

i386.c:          || INTVAL (op1) >= 16*1024*1024
i386.c:          || INTVAL (op1) < -16*1024*1024)
i386.c:          if (INTVAL (op1) < -16*1024*1024
i386.c:              || INTVAL (op1) >= 16*1024*1024)
predicates.md:          && offset < 16*1024*1024
predicates.md:          && offset < 16*1024*1024

It is a magic number for 64-bit displacement.  We should define
a macro to make it consistent.


^ permalink raw reply	[flat|nested] 4+ messages in thread

* [Bug target/55246] Define a macro for 16*1024*1024
  2012-11-09  1:44 [Bug target/55246] New: Define a macro for 16*1024*1024 hjl.tools at gmail dot com
@ 2012-11-09 10:07 ` ebotcazou at gcc dot gnu.org
  2012-12-09  1:10 ` [Bug target/55246] Define a macro for 16*1024*1024 in i386.c pinskia at gcc dot gnu.org
  2021-08-16 23:13 ` pinskia at gcc dot gnu.org
  2 siblings, 0 replies; 4+ messages in thread
From: ebotcazou at gcc dot gnu.org @ 2012-11-09 10:07 UTC (permalink / raw)
  To: gcc-bugs


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=55246

Eric Botcazou <ebotcazou at gcc dot gnu.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|UNCONFIRMED                 |NEW
   Last reconfirmed|                            |2012-11-09
                 CC|                            |ebotcazou at gcc dot
                   |                            |gnu.org
     Ever Confirmed|0                           |1

--- Comment #1 from Eric Botcazou <ebotcazou at gcc dot gnu.org> 2012-11-09 10:07:01 UTC ---
This occurred to me as well.


^ permalink raw reply	[flat|nested] 4+ messages in thread

* [Bug target/55246] Define a macro for 16*1024*1024 in i386.c
  2012-11-09  1:44 [Bug target/55246] New: Define a macro for 16*1024*1024 hjl.tools at gmail dot com
  2012-11-09 10:07 ` [Bug target/55246] " ebotcazou at gcc dot gnu.org
@ 2012-12-09  1:10 ` pinskia at gcc dot gnu.org
  2021-08-16 23:13 ` pinskia at gcc dot gnu.org
  2 siblings, 0 replies; 4+ messages in thread
From: pinskia at gcc dot gnu.org @ 2012-12-09  1:10 UTC (permalink / raw)
  To: gcc-bugs


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=55246

Andrew Pinski <pinskia at gcc dot gnu.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Target|                            |i?86-*-* x86_64-linux-gnu
            Summary|Define a macro for          |Define a macro for
                   |16*1024*1024                |16*1024*1024 in i386.c
           Severity|normal                      |enhancement

--- Comment #2 from Andrew Pinski <pinskia at gcc dot gnu.org> 2012-12-09 01:10:28 UTC ---
I don't understand why you just did not post a patch for this.


^ permalink raw reply	[flat|nested] 4+ messages in thread

* [Bug target/55246] Define a macro for 16*1024*1024 in i386.c
  2012-11-09  1:44 [Bug target/55246] New: Define a macro for 16*1024*1024 hjl.tools at gmail dot com
  2012-11-09 10:07 ` [Bug target/55246] " ebotcazou at gcc dot gnu.org
  2012-12-09  1:10 ` [Bug target/55246] Define a macro for 16*1024*1024 in i386.c pinskia at gcc dot gnu.org
@ 2021-08-16 23:13 ` pinskia at gcc dot gnu.org
  2 siblings, 0 replies; 4+ messages in thread
From: pinskia at gcc dot gnu.org @ 2021-08-16 23:13 UTC (permalink / raw)
  To: gcc-bugs

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=55246

Andrew Pinski <pinskia at gcc dot gnu.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Keywords|                            |internal-improvement

--- Comment #3 from Andrew Pinski <pinskia at gcc dot gnu.org> ---
i386/i386.c:      if (INTVAL (op1) >= 16*1024*1024
i386/i386.c:          || INTVAL (op1) < -16*1024*1024)
i386/i386.c:              if (INTVAL (op1) < -16*1024*1024
i386/i386.c:                  || INTVAL (op1) >= 16*1024*1024)
i386/i386.c:              if (INTVAL (new_rtx) < -16*1024*1024
i386/i386.c:                  || INTVAL (new_rtx) >= 16*1024*1024)
i386/i386.c:           && INTVAL (disp) < -16*1024*1024)
i386/i386.c:         displacements if they < -16*1024*1024, which is also used
i386/predicates.md:               && offset < 16*1024*1024)
i386/predicates.md:               && offset < 16*1024*1024)

Still there today.

^ permalink raw reply	[flat|nested] 4+ messages in thread

end of thread, other threads:[~2021-08-16 23:13 UTC | newest]

Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2012-11-09  1:44 [Bug target/55246] New: Define a macro for 16*1024*1024 hjl.tools at gmail dot com
2012-11-09 10:07 ` [Bug target/55246] " ebotcazou at gcc dot gnu.org
2012-12-09  1:10 ` [Bug target/55246] Define a macro for 16*1024*1024 in i386.c pinskia at gcc dot gnu.org
2021-08-16 23:13 ` pinskia at gcc dot gnu.org

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).